From: Anshuman Khandual <anshuman.khandual@arm.com> To: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, punit.agrawal@arm.com, will.deacon@arm.com, Steven.Price@arm.com, catalin.marinas@arm.com, mhocko@kernel.org, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com Subject: [PATCH 2/4] mm/hugetlb: Enable arch specific huge page size support for migration Date: Tue, 2 Oct 2018 17:45:29 +0530 [thread overview] Message-ID: <1538482531-26883-3-git-send-email-anshuman.khandual@arm.com> (raw) In-Reply-To: <1538482531-26883-1-git-send-email-anshuman.khandual@arm.com> Architectures like arm64 have HugeTLB page sizes which are different than generic sizes at PMD, PUD, PGD level and implemented via contiguous bits. At present these special size HugeTLB pages cannot be identified through macros like (PMD|PUD|PGDIR)_SHIFT and hence chosen not be migrated. Enabling migration support for these special HugeTLB page sizes along with the generic ones (PMD|PUD|PGD) would require identifying all of them on a given platform. A platform specific hook can precisely enumerate all huge page sizes supported for migration. Instead of comparing against standard huge page orders let hugetlb_migration_support() function call a platform hook arch_hugetlb_migration_support(). Default definition for the platform hook maintains existing semantics which checks standard huge page order. But an architecture can choose to override the default and provide support for a comprehensive set of huge page sizes. Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> --- include/linux/hugetlb.h | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 9c1b77f..9df1d59 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -479,18 +479,29 @@ static inline pgoff_t basepage_index(struct page *page) extern int dissolve_free_huge_page(struct page *page); extern int dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn); -static inline bool hugepage_migration_supported(struct hstate *h) -{ + #ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION +#ifndef arch_hugetlb_migration_supported +static inline bool arch_hugetlb_migration_supported(struct hstate *h) +{ if ((huge_page_shift(h) == PMD_SHIFT) || (huge_page_shift(h) == PUD_SHIFT) || (huge_page_shift(h) == PGDIR_SHIFT)) return true; else return false; +} +#endif #else +static inline bool arch_hugetlb_migration_supported(struct hstate *h) +{ return false; +} #endif + +static inline bool hugepage_migration_supported(struct hstate *h) +{ + return arch_hugetlb_migration_supported(h); } static inline spinlock_t *huge_pte_lockptr(struct hstate *h, -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: anshuman.khandual@arm.com (Anshuman Khandual) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] mm/hugetlb: Enable arch specific huge page size support for migration Date: Tue, 2 Oct 2018 17:45:29 +0530 [thread overview] Message-ID: <1538482531-26883-3-git-send-email-anshuman.khandual@arm.com> (raw) In-Reply-To: <1538482531-26883-1-git-send-email-anshuman.khandual@arm.com> Architectures like arm64 have HugeTLB page sizes which are different than generic sizes at PMD, PUD, PGD level and implemented via contiguous bits. At present these special size HugeTLB pages cannot be identified through macros like (PMD|PUD|PGDIR)_SHIFT and hence chosen not be migrated. Enabling migration support for these special HugeTLB page sizes along with the generic ones (PMD|PUD|PGD) would require identifying all of them on a given platform. A platform specific hook can precisely enumerate all huge page sizes supported for migration. Instead of comparing against standard huge page orders let hugetlb_migration_support() function call a platform hook arch_hugetlb_migration_support(). Default definition for the platform hook maintains existing semantics which checks standard huge page order. But an architecture can choose to override the default and provide support for a comprehensive set of huge page sizes. Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> --- include/linux/hugetlb.h | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 9c1b77f..9df1d59 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -479,18 +479,29 @@ static inline pgoff_t basepage_index(struct page *page) extern int dissolve_free_huge_page(struct page *page); extern int dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn); -static inline bool hugepage_migration_supported(struct hstate *h) -{ + #ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION +#ifndef arch_hugetlb_migration_supported +static inline bool arch_hugetlb_migration_supported(struct hstate *h) +{ if ((huge_page_shift(h) == PMD_SHIFT) || (huge_page_shift(h) == PUD_SHIFT) || (huge_page_shift(h) == PGDIR_SHIFT)) return true; else return false; +} +#endif #else +static inline bool arch_hugetlb_migration_supported(struct hstate *h) +{ return false; +} #endif + +static inline bool hugepage_migration_supported(struct hstate *h) +{ + return arch_hugetlb_migration_supported(h); } static inline spinlock_t *huge_pte_lockptr(struct hstate *h, -- 2.7.4
next prev parent reply other threads:[~2018-10-02 12:15 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-02 12:15 [PATCH 0/4] arm64/mm: Enable HugeTLB migration Anshuman Khandual 2018-10-02 12:15 ` Anshuman Khandual 2018-10-02 12:15 ` [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration Anshuman Khandual 2018-10-02 12:15 ` Anshuman Khandual 2018-10-02 12:38 ` Suzuki K Poulose 2018-10-02 12:38 ` Suzuki K Poulose 2018-10-02 12:56 ` Anshuman Khandual 2018-10-02 12:56 ` Anshuman Khandual 2018-10-02 12:56 ` Anshuman Khandual 2018-10-03 10:22 ` Suzuki K Poulose 2018-10-03 10:22 ` Suzuki K Poulose 2018-10-03 10:22 ` Suzuki K Poulose 2018-10-03 11:10 ` Anshuman Khandual 2018-10-03 11:10 ` Anshuman Khandual 2018-10-03 11:10 ` Anshuman Khandual 2018-10-03 11:17 ` Suzuki K Poulose 2018-10-03 11:17 ` Suzuki K Poulose 2018-10-03 11:17 ` Suzuki K Poulose 2018-10-03 11:27 ` Michal Hocko 2018-10-03 11:27 ` Michal Hocko 2018-10-02 12:39 ` Michal Hocko 2018-10-02 12:39 ` Michal Hocko 2018-10-03 2:16 ` Anshuman Khandual 2018-10-03 2:16 ` Anshuman Khandual 2018-10-03 6:58 ` Michal Hocko 2018-10-03 6:58 ` Michal Hocko 2018-10-03 9:58 ` Anshuman Khandual 2018-10-03 9:58 ` Anshuman Khandual 2018-10-03 10:59 ` Michal Hocko 2018-10-03 10:59 ` Michal Hocko 2018-10-03 11:37 ` Anshuman Khandual 2018-10-03 11:37 ` Anshuman Khandual 2018-10-03 11:48 ` Michal Hocko 2018-10-03 11:48 ` Michal Hocko 2018-10-03 13:06 ` Anshuman Khandual 2018-10-03 13:06 ` Anshuman Khandual 2018-10-03 13:36 ` Michal Hocko 2018-10-03 13:36 ` Michal Hocko 2018-10-05 7:34 ` Anshuman Khandual 2018-10-05 7:34 ` Anshuman Khandual 2018-10-09 14:14 ` Michal Hocko 2018-10-09 14:14 ` Michal Hocko 2018-10-10 3:09 ` Anshuman Khandual 2018-10-10 3:09 ` Anshuman Khandual 2018-10-10 9:39 ` Michal Hocko 2018-10-10 9:39 ` Michal Hocko 2018-10-11 3:16 ` Anshuman Khandual 2018-10-11 3:16 ` Anshuman Khandual 2018-10-02 12:15 ` Anshuman Khandual [this message] 2018-10-02 12:15 ` [PATCH 2/4] mm/hugetlb: Enable arch specific huge page size support for migration Anshuman Khandual 2018-10-02 12:15 ` [PATCH 3/4] arm64/mm: Enable HugeTLB migration Anshuman Khandual 2018-10-02 12:15 ` Anshuman Khandual 2018-10-02 12:15 ` [PATCH 4/4] arm64/mm: Enable HugeTLB migration for contiguous bit HugeTLB pages Anshuman Khandual 2018-10-02 12:15 ` Anshuman Khandual
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1538482531-26883-3-git-send-email-anshuman.khandual@arm.com \ --to=anshuman.khandual@arm.com \ --cc=Steven.Price@arm.com \ --cc=catalin.marinas@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=mike.kravetz@oracle.com \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=punit.agrawal@arm.com \ --cc=suzuki.poulose@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.