All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jenny TC <jenny.tc@intel.com>
To: alsa-devel@alsa-project.org
Cc: Jairaj Arava <jairaj.arava@intel.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Harshapriya N <harshapriya.n@intel.com>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Jenny TC <jenny.tc@intel.com>
Subject: [PATCH] ASoC: dmic: Introduce mode switch delay
Date: Fri,  2 Nov 2018 13:00:47 +0530	[thread overview]
Message-ID: <1541143847-30450-2-git-send-email-jenny.tc@intel.com> (raw)
In-Reply-To: <1541143847-30450-1-git-send-email-jenny.tc@intel.com>

Some DMICs require a delay as defined in the DMIC data sheet to complete
DMIC mode transitions. DMIC may enter a bad state if the clock is stopped
before successful mode transition. To handle this, a delay is introduced
in the STOP STREAM to ensure the clock is running for the mode switch delay
duration. A module parameter is introduced to pass the delay as a module
parameter.

Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Signed-off-by: Jairaj Arava <jairaj.arava@intel.com>
Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
---
 sound/soc/codecs/dmic.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c
index 8c4926d..0527bc2 100644
--- a/sound/soc/codecs/dmic.c
+++ b/sound/soc/codecs/dmic.c
@@ -30,9 +30,35 @@
 #include <sound/soc.h>
 #include <sound/soc-dapm.h>
 
+static int modeswitch_delay_ms;
+module_param(modeswitch_delay_ms, uint, 0644);
+
 struct dmic {
 	struct gpio_desc *gpio_en;
 	int wakeup_delay;
+	/* Delay after DMIC mode switch */
+	int modeswitch_delay_ms;
+};
+
+int dmic_daiops_trigger(struct snd_pcm_substream *substream,
+		int cmd, struct snd_soc_dai *dai)
+{
+	struct snd_soc_component *component = dai->component;
+	struct dmic *dmic = snd_soc_component_get_drvdata(component);
+
+	switch (cmd) {
+	case SNDRV_PCM_TRIGGER_STOP:
+		if (dmic->modeswitch_delay_ms)
+			mdelay(dmic->modeswitch_delay_ms);
+
+		break;
+	}
+
+	return 0;
+}
+
+static const struct snd_soc_dai_ops dmic_dai_ops = {
+	.trigger	= dmic_daiops_trigger,
 };
 
 static int dmic_aif_event(struct snd_soc_dapm_widget *w,
@@ -68,6 +94,7 @@ static int dmic_aif_event(struct snd_soc_dapm_widget *w,
 			| SNDRV_PCM_FMTBIT_S24_LE
 			| SNDRV_PCM_FMTBIT_S16_LE,
 	},
+	.ops    = &dmic_dai_ops,
 };
 
 static int dmic_component_probe(struct snd_soc_component *component)
@@ -85,6 +112,10 @@ static int dmic_component_probe(struct snd_soc_component *component)
 
 	device_property_read_u32(component->dev, "wakeup-delay-ms",
 				 &dmic->wakeup_delay);
+	device_property_read_u32(component->dev, "modeswitch_delay_ms",
+				 &dmic->modeswitch_delay_ms);
+	if (modeswitch_delay_ms)
+		dmic->modeswitch_delay_ms  = modeswitch_delay_ms;
 
 	snd_soc_component_set_drvdata(component, dmic);
 
-- 
1.9.1

  reply	other threads:[~2018-11-02  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02  7:30 [PATCH v2 0/1] Introduce dmic mode switch delay parameter Jenny TC
2018-11-02  7:30 ` Jenny TC [this message]
2018-11-02  7:37   ` [PATCH] ASoC: dmic: Introduce mode switch delay Takashi Iwai
2018-11-02 14:34   ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541143847-30450-2-git-send-email-jenny.tc@intel.com \
    --to=jenny.tc@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=harshapriya.n@intel.com \
    --cc=jairaj.arava@intel.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=mka@chromium.org \
    --cc=sathyanarayana.nujella@intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.