All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
To: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>,
	Florian Fainelli
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Michal Suchanek <msuchanek-l3A5Bk7waGM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH 5/7] mmc: bcm2835: Terminate timeout work synchronously
Date: Sun, 11 Nov 2018 14:45:28 +0100	[thread overview]
Message-ID: <1541943930-23873-6-git-send-email-stefan.wahren@i2se.com> (raw)
In-Reply-To: <1541943930-23873-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>

It's better to make sure that the timeout work is really terminated
before calling mmc_request_done.

Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
---
 drivers/mmc/host/bcm2835.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index 1c60798..2c7589f 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -608,7 +608,7 @@ static void bcm2835_finish_request(struct bcm2835_host *host)
 	struct dma_chan *terminate_chan = NULL;
 	struct mmc_request *mrq;
 
-	cancel_delayed_work(&host->timeout_work);
+	cancel_delayed_work_sync(&host->timeout_work);
 
 	mrq = host->mrq;
 
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: stefan.wahren@i2se.com (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] mmc: bcm2835: Terminate timeout work synchronously
Date: Sun, 11 Nov 2018 14:45:28 +0100	[thread overview]
Message-ID: <1541943930-23873-6-git-send-email-stefan.wahren@i2se.com> (raw)
In-Reply-To: <1541943930-23873-1-git-send-email-stefan.wahren@i2se.com>

It's better to make sure that the timeout work is really terminated
before calling mmc_request_done.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 drivers/mmc/host/bcm2835.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index 1c60798..2c7589f 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -608,7 +608,7 @@ static void bcm2835_finish_request(struct bcm2835_host *host)
 	struct dma_chan *terminate_chan = NULL;
 	struct mmc_request *mrq;
 
-	cancel_delayed_work(&host->timeout_work);
+	cancel_delayed_work_sync(&host->timeout_work);
 
 	mrq = host->mrq;
 
-- 
2.7.4

  parent reply	other threads:[~2018-11-11 13:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 13:45 [PATCH 0/7] mmc: Several fixes for bcm2835 driver Stefan Wahren
2018-11-11 13:45 ` Stefan Wahren
     [not found] ` <1541943930-23873-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2018-11-11 13:45   ` [PATCH 1/7] mmc: bcm2835: reset host on timeout Stefan Wahren
2018-11-11 13:45     ` Stefan Wahren
2018-11-11 13:45   ` Stefan Wahren [this message]
2018-11-11 13:45     ` [PATCH 5/7] mmc: bcm2835: Terminate timeout work synchronously Stefan Wahren
2018-11-11 13:45 ` [PATCH 2/7] mmc: bcm2835: Recover from MMC_SEND_EXT_CSD Stefan Wahren
2018-11-11 13:45   ` Stefan Wahren
2018-11-11 13:45 ` [PATCH 3/7] mmc: bcm2835: Release DMA channel on driver unload Stefan Wahren
2018-11-11 13:45   ` Stefan Wahren
2018-11-11 13:45 ` [PATCH 4/7] mmc: bcm2835: Avoid possible races on data requests Stefan Wahren
2018-11-11 13:45   ` Stefan Wahren
2018-11-11 13:45 ` [PATCH 6/7] mmc: bcm2835: Refactor dma_map_sg handling Stefan Wahren
2018-11-11 13:45   ` Stefan Wahren
2018-11-11 13:45 ` [PATCH 7/7] mmc: bcm2835: Properly handle dmaengine_prep_slave_sg Stefan Wahren
2018-11-11 13:45   ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541943930-23873-6-git-send-email-stefan.wahren@i2se.com \
    --to=stefan.wahren-es4nqchxeme@public.gmane.org \
    --cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \
    --cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=msuchanek-l3A5Bk7waGM@public.gmane.org \
    --cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.