All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Michal Simek <monstr@monstr.eu>
Cc: linux-kbuild@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 6/7] microblaze: fix race condition in building boot images
Date: Mon,  3 Dec 2018 16:50:56 +0900	[thread overview]
Message-ID: <1543823457-32478-7-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1543823457-32478-1-git-send-email-yamada.masahiro@socionext.com>

I fixed a race condition in the parallel building of ARM in commit
3939f3345050 ("ARM: 8418/1: add boot image dependencies to not
generate invalid images").

I see the same problem for MicroBlaze too.

"make -j<N> ARCH=microblaze all linux.bin.ub" results in a broken build
since two threads descend into arch/microblaze/boot simultaneously.

Add proper dependencies to avoid it.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/microblaze/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
index 7a5df02..544796d 100644
--- a/arch/microblaze/Makefile
+++ b/arch/microblaze/Makefile
@@ -79,13 +79,15 @@ all: linux.bin
 archclean:
 	$(Q)$(MAKE) $(clean)=$(boot)
 
+linux.bin.ub linux.bin.gz: linux.bin
+
 PHONY += linux.bin linux.bin.gz linux.bin.ub
 linux.bin linux.bin.gz linux.bin.ub: vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
 	@echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')'
 
 PHONY += simpleImage.$(DTB)
-simpleImage.$(DTB): vmlinux
+simpleImage.$(DTB): linux.bin.ub
 	$(Q)$(MAKE) $(build)=$(boot) simple_images
 	@echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')'
 
-- 
2.7.4


  parent reply	other threads:[~2018-12-03  7:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03  7:50 [PATCH 0/7] microblaze: fix various problems in building boot images Masahiro Yamada
2018-12-03  7:50 ` [PATCH 1/7] microblaze: fix cleaning of " Masahiro Yamada
2018-12-05 15:41   ` Michal Simek
2018-12-03  7:50 ` [PATCH 2/7] microblaze: adjust the help to the real behavior Masahiro Yamada
2018-12-05 15:40   ` Michal Simek
2018-12-06  5:27     ` Masahiro Yamada
2018-12-06 12:52       ` Michal Simek
2018-12-07  9:50         ` Masahiro Yamada
2018-12-07 10:21         ` Masahiro Yamada
2018-12-07 10:47           ` Michal Simek
2018-12-03  7:50 ` [PATCH 3/7] microblaze: move "... is ready" message to arch/microblaze/Makefile Masahiro Yamada
2018-12-05 15:47   ` Michal Simek
2018-12-03  7:50 ` [PATCH 4/7] microblaze: fix multiple bugs in arch/microblaze/boot/Makefile Masahiro Yamada
2018-12-05 15:57   ` Michal Simek
2018-12-03  7:50 ` [PATCH 5/7] microblaze: add linux.bin* and simpleImage.* to PHONY Masahiro Yamada
2018-12-05 15:59   ` Michal Simek
2018-12-03  7:50 ` Masahiro Yamada [this message]
2018-12-05 16:31   ` [PATCH 6/7] microblaze: fix race condition in building boot images Michal Simek
2018-12-08  6:51     ` Masahiro Yamada
2018-12-03  7:50 ` [PATCH 7/7] microblaze: remove the unneeded code just in case file copy fails Masahiro Yamada
2018-12-05 16:33   ` Michal Simek
2018-12-05 16:41 ` [PATCH 0/7] microblaze: fix various problems in building boot images Michal Simek
2018-12-06  5:08   ` Masahiro Yamada
2018-12-06 13:09     ` Michal Simek
2018-12-07 11:25       ` Masahiro Yamada
2018-12-06 14:44 ` Michal Simek
2018-12-07 11:29   ` Masahiro Yamada
2018-12-07 13:29     ` Michal Simek
2018-12-07 15:19       ` Michal Simek
2018-12-08  6:14         ` Masahiro Yamada
2018-12-12 13:50           ` Michal Simek
2018-12-12 14:11             ` Masahiro Yamada
2018-12-12 14:21               ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1543823457-32478-7-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.