All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	eblake@redhat.com
Subject: [Qemu-devel] [PATCH for-4.0 3/5] tests/machine-none: Make test independent of global_qtest
Date: Thu,  6 Dec 2018 17:49:56 +0100	[thread overview]
Message-ID: <1544114998-1513-4-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1544114998-1513-1-git-send-email-thuth@redhat.com>

Apart from using qmp() in one spot, this test does not have any
dependencies to the global_qtest variable, so we can simply get
rid of it here by replacing the qmp() with qtest_qmp().

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/machine-none-test.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c
index 2b3b750..4c6d470 100644
--- a/tests/machine-none-test.c
+++ b/tests/machine-none-test.c
@@ -75,6 +75,7 @@ static void test_machine_cpu_cli(void)
     QDict *response;
     const char *arch = qtest_get_arch();
     const char *cpu_model = get_cpu_model_by_arch(arch);
+    QTestState *qts;
 
     if (!cpu_model) {
         if (!(!strcmp(arch, "microblaze") || !strcmp(arch, "microblazeel"))) {
@@ -83,13 +84,13 @@ static void test_machine_cpu_cli(void)
         }
         return; /* TODO: die here to force all targets have a test */
     }
-    global_qtest = qtest_initf("-machine none -cpu '%s'", cpu_model);
+    qts = qtest_initf("-machine none -cpu '%s'", cpu_model);
 
-    response = qmp("{ 'execute': 'quit' }");
+    response = qtest_qmp(qts, "{ 'execute': 'quit' }");
     g_assert(qdict_haskey(response, "return"));
     qobject_unref(response);
 
-    qtest_quit(global_qtest);
+    qtest_quit(qts);
 }
 
 int main(int argc, char **argv)
-- 
1.8.3.1

  parent reply	other threads:[~2018-12-06 16:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 16:49 [Qemu-devel] [PATCH for-4.0 0/5] Make more tests independent of global_qtest Thomas Huth
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 1/5] tests/boot-serial: Get rid of global_qtest variable Thomas Huth
2018-12-06 18:42   ` Eric Blake
2018-12-06 19:34     ` Thomas Huth
2018-12-06 19:56       ` Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 2/5] tests/test-filter: Make tests independent of global_qtest Thomas Huth
2018-12-06 18:43   ` Eric Blake
2018-12-06 16:49 ` Thomas Huth [this message]
2018-12-06 18:44   ` [Qemu-devel] [PATCH for-4.0 3/5] tests/machine-none: Make test " Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 4/5] tests/prom-env: " Thomas Huth
2018-12-06 18:46   ` Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 5/5] tests/pxe: Make test independent from global_qtest Thomas Huth
2018-12-06 18:50   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544114998-1513-4-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.