All of lore.kernel.org
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH -next] mmc: remove set but not used variables 'len, clock_out'
Date: Fri, 07 Dec 2018 06:34:47 +0000	[thread overview]
Message-ID: <1544164487-52246-1-git-send-email-yuehaibing@huawei.com> (raw)

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/mmc/host/alcor.c: In function 'alcor_data_set_dma':
drivers/mmc/host/alcor.c:124:12: warning:
 variable 'len' set but not used [-Wunused-but-set-variable]

drivers/mmc/host/alcor.c:648:15: warning:
 variable 'clock_out' set but not used [-Wunused-but-set-variable]

It never used since introduction in commit 2a9a4742e825 ("mmc: add new Alcor
Micro Cardreader SD/MMC driver")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/mmc/host/alcor.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mmc/host/alcor.c b/drivers/mmc/host/alcor.c
index f729a64..c712b7d 100644
--- a/drivers/mmc/host/alcor.c
+++ b/drivers/mmc/host/alcor.c
@@ -121,7 +121,7 @@ static void alcor_reset(struct alcor_sdmmc_host *host, u8 val)
 static void alcor_data_set_dma(struct alcor_sdmmc_host *host)
 {
 	struct alcor_pci_priv *priv = host->alcor_pci;
-	u32 addr, len;
+	u32 addr;
 
 	if (!host->sg_count)
 		return;
@@ -138,7 +138,6 @@ static void alcor_data_set_dma(struct alcor_sdmmc_host *host)
 
 
 	addr = (u32)sg_dma_address(host->sg);
-	len = sg_dma_len(host->sg);
 
 	alcor_write32(priv, addr, AU6601_REG_SDMA_ADDR);
 	host->sg = sg_next(host->sg);
@@ -645,7 +644,6 @@ static irqreturn_t alcor_irq(int irq, void *d)
 static void alcor_set_clock(struct alcor_sdmmc_host *host, unsigned int clock)
 {
 	struct alcor_pci_priv *priv = host->alcor_pci;
-	unsigned int clock_out = 0;
 	int i, diff = 0x7fffffff, tmp_clock = 0;
 	u16 clk_src = 0;
 	u8 clk_div = 0;
@@ -670,7 +668,6 @@ static void alcor_set_clock(struct alcor_sdmmc_host *host, unsigned int clock)
 			diff = tmp_diff;
 			clk_src = cfg->clk_src_reg;
 			clk_div = tmp_div;
-			clock_out = tmp_clock;
 		}
 	}
 

             reply	other threads:[~2018-12-07  6:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  6:34 YueHaibing [this message]
2018-12-07 18:04 ` [PATCH -next] mmc: remove set but not used variables 'len, clock_out' Oleksij Rempel
2018-12-11  9:31 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544164487-52246-1-git-send-email-yuehaibing@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.