All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: thierry.reding@gmail.com
Cc: linux-pwm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: [PATCH 1/5] pwm: rcar: add rcar_pwm_calc_counter() to calculate PWMCNT value only
Date: Fri,  7 Dec 2018 17:29:29 +0900	[thread overview]
Message-ID: <1544171373-29618-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw)
In-Reply-To: <1544171373-29618-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>

To add a workaround in the future, this patch adds a function
rcar_pwm_calc_counter() from rcar_pwm_set_counter().
The rcar_pwm_calc_counter() calculates PWMCNT value only, and
rcar_pwm_set_counter() set the PWMCNT register by using
the calculated value. No change in behavior.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/pwm/pwm-rcar.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c
index a41812f..9cf4567 100644
--- a/drivers/pwm/pwm-rcar.c
+++ b/drivers/pwm/pwm-rcar.c
@@ -36,6 +36,7 @@ struct rcar_pwm_chip {
 	struct pwm_chip chip;
 	void __iomem *base;
 	struct clk *clk;
+	u32 pwmcnt;
 };
 
 static inline struct rcar_pwm_chip *to_rcar_pwm_chip(struct pwm_chip *chip)
@@ -102,8 +103,8 @@ static void rcar_pwm_set_clock_control(struct rcar_pwm_chip *rp,
 	rcar_pwm_write(rp, value, RCAR_PWMCR);
 }
 
-static int rcar_pwm_set_counter(struct rcar_pwm_chip *rp, int div, int duty_ns,
-				int period_ns)
+static void rcar_pwm_calc_counter(struct rcar_pwm_chip *rp, int div,
+				  int duty_ns, int period_ns)
 {
 	unsigned long long one_cycle, tmp;	/* 0.01 nanoseconds */
 	unsigned long clk_rate = clk_get_rate(rp->clk);
@@ -120,11 +121,17 @@ static int rcar_pwm_set_counter(struct rcar_pwm_chip *rp, int div, int duty_ns,
 	do_div(tmp, one_cycle);
 	ph = tmp & RCAR_PWMCNT_PH0_MASK;
 
+	rp->pwmcnt = cyc | ph;
+}
+
+static int rcar_pwm_set_counter(struct rcar_pwm_chip *rp)
+{
 	/* Avoid prohibited setting */
-	if (cyc == 0 || ph == 0)
+	if ((rp->pwmcnt & RCAR_PWMCNT_CYC0_MASK) == 0 ||
+	    (rp->pwmcnt & RCAR_PWMCNT_PH0_MASK) == 0)
 		return -EINVAL;
 
-	rcar_pwm_write(rp, cyc | ph, RCAR_PWMCNT);
+	rcar_pwm_write(rp, rp->pwmcnt, RCAR_PWMCNT);
 
 	return 0;
 }
@@ -159,7 +166,8 @@ static int rcar_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 
 	rcar_pwm_update(rp, RCAR_PWMCR_SYNC, RCAR_PWMCR_SYNC, RCAR_PWMCR);
 
-	ret = rcar_pwm_set_counter(rp, div, duty_ns, period_ns);
+	rcar_pwm_calc_counter(rp, div, duty_ns, period_ns);
+	ret = rcar_pwm_set_counter(rp);
 	if (!ret)
 		rcar_pwm_set_clock_control(rp, div);
 
-- 
1.9.1

  reply	other threads:[~2018-12-07  8:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  8:29 [PATCH 0/5] pwm: rcar: Add support "atomic" API and workaround Yoshihiro Shimoda
2018-12-07  8:29 ` Yoshihiro Shimoda [this message]
2018-12-07  9:00   ` [PATCH 1/5] pwm: rcar: add rcar_pwm_calc_counter() to calculate PWMCNT value only Uwe Kleine-König
2018-12-07  9:00     ` Uwe Kleine-König
2018-12-07  8:29 ` [PATCH 2/5] pwm: rcar: Add support "atomic" API Yoshihiro Shimoda
2018-12-07  9:07   ` Uwe Kleine-König
2018-12-07  9:07     ` Uwe Kleine-König
2018-12-07  9:57     ` Geert Uytterhoeven
2018-12-07 10:45       ` Uwe Kleine-König
2018-12-07 10:45         ` Uwe Kleine-König
2018-12-10  4:58         ` Yoshihiro Shimoda
2018-12-07  8:29 ` [PATCH 3/5] pwm: rcar: Use "atomic" API on rcar_pwm_resume() Yoshihiro Shimoda
2018-12-07  8:29 ` [PATCH 4/5] pwm: rcar: remove legacy APIs Yoshihiro Shimoda
2018-12-07  8:29 ` [PATCH 5/5] pwm: rcar: add workaround to output "pseudo" low level Yoshihiro Shimoda
2018-12-07  9:13   ` Uwe Kleine-König
2018-12-07  9:13     ` Uwe Kleine-König
2018-12-10  4:49     ` Yoshihiro Shimoda
2018-12-10  8:11       ` Uwe Kleine-König
2018-12-10  8:11         ` Uwe Kleine-König
2018-12-12  3:19         ` Yoshihiro Shimoda
2018-12-12  3:19           ` Yoshihiro Shimoda
2018-12-12  7:37           ` Uwe Kleine-König
2018-12-12  7:37             ` Uwe Kleine-König
2018-12-12 10:49             ` Yoshihiro Shimoda
2018-12-12 10:49               ` Yoshihiro Shimoda
2018-12-13  9:47     ` Yoshihiro Shimoda
2018-12-13  9:47       ` Yoshihiro Shimoda
2018-12-13  9:52       ` Uwe Kleine-König
2018-12-13  9:52         ` Uwe Kleine-König
2018-12-13 10:53         ` Yoshihiro Shimoda
2018-12-13 10:53           ` Yoshihiro Shimoda
2018-12-07 21:49 ` pwm: rcar: improve calculation of divider Uwe Kleine-König
2018-12-07 21:49   ` Uwe Kleine-König
2018-12-09 20:55   ` Laurent Pinchart
2018-12-10  5:09     ` Yoshihiro Shimoda
2018-12-10  8:04       ` Uwe Kleine-König
2018-12-10  8:04         ` Uwe Kleine-König
2018-12-12  3:13         ` Yoshihiro Shimoda
2018-12-12  3:13           ` Yoshihiro Shimoda
2018-12-09 22:48 ` [PATCH 0/5] pwm: rcar: Add support "atomic" API and workaround Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544171373-29618-2-git-send-email-yoshihiro.shimoda.uh@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.