All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: Geoffrey McRae <geoff@hostfission.com>,
	Eric Auger <eric.auger@redhat.com>
Subject: [Qemu-devel] [PATCH v5 7/8] vfio/pci: Remove PCIe Link Status emulation
Date: Wed, 12 Dec 2018 12:39:56 -0700	[thread overview]
Message-ID: <154464359673.9828.13600047795249996191.stgit@gimli.home> (raw)
In-Reply-To: <154464279386.9828.10219496338109023342.stgit@gimli.home>

Now that the downstream port will virtually negotiate itself to the
link status of the downstream device, we can remove this emulation.
It's not clear that it was every terribly useful anyway.

Tested-by: Geoffrey McRae <geoff@hostfission.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/vfio/pci.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 74f9a46b4be0..c0cb1ec28908 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1901,12 +1901,6 @@ static int vfio_setup_pcie_cap(VFIOPCIDevice *vdev, int pos, uint8_t size,
                            QEMU_PCI_EXP_LNKCAP_MLS(QEMU_PCI_EXP_LNK_2_5GT), ~0);
             vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKCTL, 0, ~0);
         }
-
-        /* Mark the Link Status bits as emulated to allow virtual negotiation */
-        vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKSTA,
-                               pci_get_word(vdev->pdev.config + pos +
-                                            PCI_EXP_LNKSTA),
-                               PCI_EXP_LNKCAP_MLW | PCI_EXP_LNKCAP_SLS);
     }
 
     /*

  parent reply	other threads:[~2018-12-12 19:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 19:38 [Qemu-devel] [PATCH v5 0/8] pcie: Enhanced link speed and width support Alex Williamson
2018-12-12 19:38 ` [Qemu-devel] [PATCH v5 1/8] pcie: Create enums for link speed and width Alex Williamson
2018-12-12 19:38 ` [Qemu-devel] [PATCH v5 2/8] pci: Sync PCIe downstream port LNKSTA on read Alex Williamson
2018-12-12 19:39 ` [Qemu-devel] [PATCH v5 3/8] qapi: Define PCIe link speed and width properties Alex Williamson
2018-12-12 19:39 ` [Qemu-devel] [PATCH v5 4/8] pcie: Add link speed and width fields to PCIESlot Alex Williamson
2018-12-12 19:39 ` [Qemu-devel] [PATCH v5 5/8] pcie: Fill PCIESlot link fields to support higher speeds and widths Alex Williamson
2018-12-12 19:39 ` [Qemu-devel] [PATCH v5 6/8] pcie: Allow generic PCIe root port to specify link speed and width Alex Williamson
2018-12-18  1:29   ` Michael S. Tsirkin
2018-12-18  1:44     ` Alex Williamson
2018-12-18  1:47       ` Michael S. Tsirkin
2018-12-18  1:54         ` Alex Williamson
2018-12-18  2:27           ` Michael S. Tsirkin
2018-12-12 19:39 ` Alex Williamson [this message]
2018-12-12 19:40 ` [Qemu-devel] [PATCH v5 8/8] pcie: Fast PCIe root ports for new machines Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154464359673.9828.13600047795249996191.stgit@gimli.home \
    --to=alex.williamson@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=geoff@hostfission.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.