From: YueHaibing <yuehaibing@huawei.com> To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com> Cc: YueHaibing <yuehaibing@huawei.com>, <linux-btrfs@vger.kernel.org>, <kernel-janitors@vger.kernel.org> Subject: [PATCH -next] btrfs: remove set but not used variable 'num_pages' Date: Sat, 15 Dec 2018 06:31:07 +0000 [thread overview] Message-ID: <1544855467-154115-1-git-send-email-yuehaibing@huawei.com> (raw) Fixes gcc '-Wunused-but-set-variable' warning: fs/btrfs/ioctl.c: In function 'btrfs_extent_same': fs/btrfs/ioctl.c:3260:6: warning: variable 'num_pages' set but not used [-Wunused-but-set-variable] It not used any more since commit 9ee8234e6220 ("Btrfs: use generic_remap_file_range_prep() for cloning and deduplication") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- fs/btrfs/ioctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index fab9443..15fc467 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3257,7 +3257,6 @@ static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen, struct inode *dst, u64 dst_loff) { int ret; - int num_pages = PAGE_ALIGN(BTRFS_MAX_DEDUPE_LEN) >> PAGE_SHIFT; u64 i, tail_len, chunk_count; /* don't make the dst file partly checksummed */ @@ -3270,8 +3269,6 @@ static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen, tail_len = olen % BTRFS_MAX_DEDUPE_LEN; chunk_count = div_u64(olen, BTRFS_MAX_DEDUPE_LEN); - if (chunk_count == 0) - num_pages = PAGE_ALIGN(tail_len) >> PAGE_SHIFT; for (i = 0; i < chunk_count; i++) { ret = btrfs_extent_same_range(src, loff, BTRFS_MAX_DEDUPE_LEN,
WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com> To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com> Cc: YueHaibing <yuehaibing@huawei.com>, linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH -next] btrfs: remove set but not used variable 'num_pages' Date: Sat, 15 Dec 2018 06:31:07 +0000 [thread overview] Message-ID: <1544855467-154115-1-git-send-email-yuehaibing@huawei.com> (raw) In-Reply-To: <1541643283-109411-1-git-send-email-yuehaibing@huawei.com> Fixes gcc '-Wunused-but-set-variable' warning: fs/btrfs/ioctl.c: In function 'btrfs_extent_same': fs/btrfs/ioctl.c:3260:6: warning: variable 'num_pages' set but not used [-Wunused-but-set-variable] It not used any more since commit 9ee8234e6220 ("Btrfs: use generic_remap_file_range_prep() for cloning and deduplication") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- fs/btrfs/ioctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index fab9443..15fc467 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3257,7 +3257,6 @@ static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen, struct inode *dst, u64 dst_loff) { int ret; - int num_pages = PAGE_ALIGN(BTRFS_MAX_DEDUPE_LEN) >> PAGE_SHIFT; u64 i, tail_len, chunk_count; /* don't make the dst file partly checksummed */ @@ -3270,8 +3269,6 @@ static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen, tail_len = olen % BTRFS_MAX_DEDUPE_LEN; chunk_count = div_u64(olen, BTRFS_MAX_DEDUPE_LEN); - if (chunk_count = 0) - num_pages = PAGE_ALIGN(tail_len) >> PAGE_SHIFT; for (i = 0; i < chunk_count; i++) { ret = btrfs_extent_same_range(src, loff, BTRFS_MAX_DEDUPE_LEN,
next reply other threads:[~2018-12-15 6:23 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-15 6:31 YueHaibing [this message] 2018-12-15 6:31 ` [PATCH -next] btrfs: remove set but not used variable 'num_pages' YueHaibing 2018-12-17 3:02 ` Anand Jain 2019-01-04 15:51 ` David Sterba 2019-01-04 15:51 ` David Sterba -- strict thread matches above, loose matches on Subject: below -- 2019-04-18 6:43 [PATCH -next] btrfs: Remove set but not used variable 'fs_info' YueHaibing 2019-04-18 6:43 ` YueHaibing 2019-04-18 6:37 ` Nikolay Borisov 2019-04-18 6:37 ` Nikolay Borisov 2019-04-18 7:34 ` YueHaibing 2019-04-18 7:34 ` YueHaibing 2019-04-18 13:43 ` David Sterba 2019-04-18 13:43 ` David Sterba 2019-03-27 3:20 [PATCH -next] btrfs: remove set but not used variable 'fs_devices' YueHaibing 2019-03-27 3:20 ` YueHaibing 2019-03-28 14:27 ` David Sterba 2019-03-28 14:27 ` David Sterba 2018-11-08 2:14 [PATCH -next] btrfs: remove set but not used variable 'tree' YueHaibing 2018-11-08 2:14 ` YueHaibing 2018-11-08 6:53 ` Nikolay Borisov 2018-11-08 6:53 ` Nikolay Borisov 2018-11-08 12:11 ` David Sterba 2018-11-08 12:11 ` David Sterba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1544855467-154115-1-git-send-email-yuehaibing@huawei.com \ --to=yuehaibing@huawei.com \ --cc=clm@fb.com \ --cc=dsterba@suse.com \ --cc=josef@toxicpanda.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.