All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yong Wu <yong.wu@mediatek.com>
To: Joerg Roedel <joro@8bytes.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
	Tomasz Figa <tfiga@google.com>, Will Deacon <will.deacon@arm.com>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<iommu@lists.linux-foundation.org>, <arnd@arndb.de>,
	<yingjoe.chen@mediatek.com>, <yong.wu@mediatek.com>,
	<youlin.pei@mediatek.com>,
	Nicolas Boichat <drinkcat@chromium.org>
Subject: [PATCH 10/13] memory: mtk-smi: Get rid of mtk_smi_larb_get/put
Date: Tue, 1 Jan 2019 12:51:13 +0800	[thread overview]
Message-ID: <1546318276-18993-11-git-send-email-yong.wu@mediatek.com> (raw)
In-Reply-To: <1546318276-18993-1-git-send-email-yong.wu@mediatek.com>

After adding device_link between the iommu consumer and smi-larb,
the pm_runtime_get(_sync) of smi-larb and smi-common will be called
automatically. we can get rid of mtk_smi_larb_get/put.

CC: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
 drivers/memory/mtk-smi.c   | 14 --------------
 include/soc/mediatek/smi.h | 20 --------------------
 2 files changed, 34 deletions(-)

diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 30930e4..a1dc34b 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -123,20 +123,6 @@ static void mtk_smi_clk_disable(const struct mtk_smi *smi)
 	clk_disable_unprepare(smi->clk_apb);
 }
 
-int mtk_smi_larb_get(struct device *larbdev)
-{
-	int ret = pm_runtime_get_sync(larbdev);
-
-	return (ret < 0) ? ret : 0;
-}
-EXPORT_SYMBOL_GPL(mtk_smi_larb_get);
-
-void mtk_smi_larb_put(struct device *larbdev)
-{
-	pm_runtime_put_sync(larbdev);
-}
-EXPORT_SYMBOL_GPL(mtk_smi_larb_put);
-
 static int
 mtk_smi_larb_bind(struct device *dev, struct device *master, void *data)
 {
diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h
index 2b410d2..b993aa2 100644
--- a/include/soc/mediatek/smi.h
+++ b/include/soc/mediatek/smi.h
@@ -25,26 +25,6 @@ struct mtk_smi_iommu {
 	struct mtk_smi_larb_iommu larb_imu[MTK_LARB_NR_MAX];
 };
 
-/*
- * mtk_smi_larb_get: Enable the power domain and clocks for this local arbiter.
- *                   It also initialize some basic setting(like iommu).
- * mtk_smi_larb_put: Disable the power domain and clocks for this local arbiter.
- * Both should be called in non-atomic context.
- *
- * Returns 0 if successful, negative on failure.
- */
-int mtk_smi_larb_get(struct device *larbdev);
-void mtk_smi_larb_put(struct device *larbdev);
-
-#else
-
-static inline int mtk_smi_larb_get(struct device *larbdev)
-{
-	return 0;
-}
-
-static inline void mtk_smi_larb_put(struct device *larbdev) { }
-
 #endif
 
 #endif
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Yong Wu <yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: youlin.pei-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Nicolas Boichat
	<drinkcat-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	arnd-r2nGTMty4D4@public.gmane.org,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Tomasz Figa <tfiga-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH 10/13] memory: mtk-smi: Get rid of mtk_smi_larb_get/put
Date: Tue, 1 Jan 2019 12:51:13 +0800	[thread overview]
Message-ID: <1546318276-18993-11-git-send-email-yong.wu@mediatek.com> (raw)
In-Reply-To: <1546318276-18993-1-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

After adding device_link between the iommu consumer and smi-larb,
the pm_runtime_get(_sync) of smi-larb and smi-common will be called
automatically. we can get rid of mtk_smi_larb_get/put.

CC: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Yong Wu <yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 drivers/memory/mtk-smi.c   | 14 --------------
 include/soc/mediatek/smi.h | 20 --------------------
 2 files changed, 34 deletions(-)

diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 30930e4..a1dc34b 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -123,20 +123,6 @@ static void mtk_smi_clk_disable(const struct mtk_smi *smi)
 	clk_disable_unprepare(smi->clk_apb);
 }
 
-int mtk_smi_larb_get(struct device *larbdev)
-{
-	int ret = pm_runtime_get_sync(larbdev);
-
-	return (ret < 0) ? ret : 0;
-}
-EXPORT_SYMBOL_GPL(mtk_smi_larb_get);
-
-void mtk_smi_larb_put(struct device *larbdev)
-{
-	pm_runtime_put_sync(larbdev);
-}
-EXPORT_SYMBOL_GPL(mtk_smi_larb_put);
-
 static int
 mtk_smi_larb_bind(struct device *dev, struct device *master, void *data)
 {
diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h
index 2b410d2..b993aa2 100644
--- a/include/soc/mediatek/smi.h
+++ b/include/soc/mediatek/smi.h
@@ -25,26 +25,6 @@ struct mtk_smi_iommu {
 	struct mtk_smi_larb_iommu larb_imu[MTK_LARB_NR_MAX];
 };
 
-/*
- * mtk_smi_larb_get: Enable the power domain and clocks for this local arbiter.
- *                   It also initialize some basic setting(like iommu).
- * mtk_smi_larb_put: Disable the power domain and clocks for this local arbiter.
- * Both should be called in non-atomic context.
- *
- * Returns 0 if successful, negative on failure.
- */
-int mtk_smi_larb_get(struct device *larbdev);
-void mtk_smi_larb_put(struct device *larbdev);
-
-#else
-
-static inline int mtk_smi_larb_get(struct device *larbdev)
-{
-	return 0;
-}
-
-static inline void mtk_smi_larb_put(struct device *larbdev) { }
-
 #endif
 
 #endif
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Yong Wu <yong.wu@mediatek.com>
To: Joerg Roedel <joro@8bytes.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org,
	Nicolas Boichat <drinkcat@chromium.org>,
	arnd@arndb.de, srv_heupstream@mediatek.com,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, Tomasz Figa <tfiga@google.com>,
	iommu@lists.linux-foundation.org,
	linux-mediatek@lists.infradead.org, yong.wu@mediatek.com,
	yingjoe.chen@mediatek.com, Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/13] memory: mtk-smi: Get rid of mtk_smi_larb_get/put
Date: Tue, 1 Jan 2019 12:51:13 +0800	[thread overview]
Message-ID: <1546318276-18993-11-git-send-email-yong.wu@mediatek.com> (raw)
In-Reply-To: <1546318276-18993-1-git-send-email-yong.wu@mediatek.com>

After adding device_link between the iommu consumer and smi-larb,
the pm_runtime_get(_sync) of smi-larb and smi-common will be called
automatically. we can get rid of mtk_smi_larb_get/put.

CC: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
 drivers/memory/mtk-smi.c   | 14 --------------
 include/soc/mediatek/smi.h | 20 --------------------
 2 files changed, 34 deletions(-)

diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 30930e4..a1dc34b 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -123,20 +123,6 @@ static void mtk_smi_clk_disable(const struct mtk_smi *smi)
 	clk_disable_unprepare(smi->clk_apb);
 }
 
-int mtk_smi_larb_get(struct device *larbdev)
-{
-	int ret = pm_runtime_get_sync(larbdev);
-
-	return (ret < 0) ? ret : 0;
-}
-EXPORT_SYMBOL_GPL(mtk_smi_larb_get);
-
-void mtk_smi_larb_put(struct device *larbdev)
-{
-	pm_runtime_put_sync(larbdev);
-}
-EXPORT_SYMBOL_GPL(mtk_smi_larb_put);
-
 static int
 mtk_smi_larb_bind(struct device *dev, struct device *master, void *data)
 {
diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h
index 2b410d2..b993aa2 100644
--- a/include/soc/mediatek/smi.h
+++ b/include/soc/mediatek/smi.h
@@ -25,26 +25,6 @@ struct mtk_smi_iommu {
 	struct mtk_smi_larb_iommu larb_imu[MTK_LARB_NR_MAX];
 };
 
-/*
- * mtk_smi_larb_get: Enable the power domain and clocks for this local arbiter.
- *                   It also initialize some basic setting(like iommu).
- * mtk_smi_larb_put: Disable the power domain and clocks for this local arbiter.
- * Both should be called in non-atomic context.
- *
- * Returns 0 if successful, negative on failure.
- */
-int mtk_smi_larb_get(struct device *larbdev);
-void mtk_smi_larb_put(struct device *larbdev);
-
-#else
-
-static inline int mtk_smi_larb_get(struct device *larbdev)
-{
-	return 0;
-}
-
-static inline void mtk_smi_larb_put(struct device *larbdev) { }
-
 #endif
 
 #endif
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-01-01  4:53 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  4:51 [PATCH 00/13] Clean up "mediatek,larb" after adding device_link Yong Wu
2019-01-01  4:51 ` Yong Wu
2019-01-01  4:51 ` Yong Wu
2019-01-01  4:51 ` [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW Yong Wu
2019-01-01  4:51   ` [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek, larb " Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-11 14:58   ` [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek,larb " Rob Herring
2019-01-11 14:58     ` [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek, larb " Rob Herring
2019-01-11 14:58     ` [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek,larb " Rob Herring
2019-02-25 23:54   ` Evan Green
2019-02-25 23:54     ` [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek, larb " Evan Green
2019-02-25 23:54     ` [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek,larb " Evan Green
2019-01-01  4:51 ` [PATCH 02/13] driver core: Remove the link if there is no driver with AUTO flag Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:53   ` Evan Green
2019-02-25 23:53     ` Evan Green
2019-02-25 23:53     ` Evan Green
2019-02-27 14:33     ` Yong Wu
2019-02-27 14:33       ` Yong Wu
2019-02-27 14:33       ` Yong Wu
2019-03-05 19:03       ` Evan Green
2019-03-05 19:03         ` Evan Green
2019-03-05 19:03         ` Evan Green
2019-03-12 14:21         ` Matthias Brugger
2019-03-12 14:21           ` Matthias Brugger
2019-03-12 14:21           ` Matthias Brugger
2019-03-12 23:17           ` Evan Green
2019-03-12 23:17             ` Evan Green
2019-03-12 23:17             ` Evan Green
2019-03-13  9:08             ` Yong Wu
2019-03-13  9:08               ` Yong Wu
2019-03-13  9:08               ` Yong Wu
2019-01-01  4:51 ` [PATCH 03/13] iommu/mediatek: Add probe_defer for smi-larb Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:54   ` Evan Green
2019-02-25 23:54     ` Evan Green
2019-02-25 23:54     ` Evan Green
2019-02-27 14:33     ` Yong Wu
2019-02-27 14:33       ` Yong Wu
2019-02-27 14:33       ` Yong Wu
2019-03-05 19:02       ` Evan Green
2019-03-05 19:02         ` Evan Green
2019-03-05 19:02         ` Evan Green
2019-01-01  4:51 ` [PATCH 04/13] iommu/mediatek: Add device_link between the consumer and the larb devices Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:54   ` Evan Green
2019-02-25 23:54     ` Evan Green
2019-02-25 23:54     ` Evan Green
2019-02-27 14:34     ` Yong Wu
2019-02-27 14:34       ` Yong Wu
2019-02-27 14:34       ` Yong Wu
2019-02-27 19:30   ` Robin Murphy
2019-02-27 19:30     ` Robin Murphy
2019-03-13  9:11     ` Yong Wu
2019-03-13  9:11       ` Yong Wu
2019-03-13  9:11       ` Yong Wu
2019-01-01  4:51 ` [PATCH 05/13] memory: mtk-smi: Add device-link between smi-larb and smi-common Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:54   ` Evan Green
2019-02-25 23:54     ` Evan Green
2019-02-25 23:54     ` Evan Green
2019-02-27 14:33     ` Yong Wu
2019-02-27 14:33       ` Yong Wu
2019-02-27 14:33       ` Yong Wu
2019-03-05 19:02       ` Evan Green
2019-03-05 19:02         ` Evan Green
2019-03-05 19:02         ` Evan Green
2019-01-01  4:51 ` [PATCH 06/13] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:55   ` Evan Green
2019-02-25 23:55     ` Evan Green
2019-02-25 23:55     ` Evan Green
2019-01-01  4:51 ` [PATCH 07/13] media: mtk-mdp: " Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:55   ` Evan Green
2019-02-25 23:55     ` Evan Green
2019-02-25 23:55     ` Evan Green
2019-01-01  4:51 ` [PATCH 08/13] media: mtk-vcodec: " Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:55   ` Evan Green
2019-02-25 23:55     ` Evan Green
2019-02-25 23:55     ` Evan Green
2019-01-01  4:51 ` [PATCH 09/13] drm/mediatek: " Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:55   ` Evan Green
2019-02-25 23:55     ` Evan Green
2019-02-25 23:55     ` Evan Green
2019-01-01  4:51 ` Yong Wu [this message]
2019-01-01  4:51   ` [PATCH 10/13] memory: mtk-smi: " Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:56   ` Evan Green
2019-02-25 23:56     ` Evan Green
2019-02-25 23:56     ` Evan Green
2019-01-01  4:51 ` [PATCH 11/13] iommu/mediatek: Use builtin_platform_driver Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:56   ` Evan Green
2019-02-25 23:56     ` Evan Green
2019-02-25 23:56     ` Evan Green
2019-02-27 14:33     ` Yong Wu
2019-02-27 14:33       ` Yong Wu
2019-02-27 14:33       ` Yong Wu
2019-03-05 19:03       ` Evan Green
2019-03-05 19:03         ` Evan Green
2019-03-05 19:03         ` Evan Green
2019-01-01  4:51 ` [PATCH 12/13] arm: dts: mediatek: Get rid of mediatek,larb for MM nodes Yong Wu
2019-01-01  4:51   ` [PATCH 12/13] arm: dts: mediatek: Get rid of mediatek, larb " Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:56   ` [PATCH 12/13] arm: dts: mediatek: Get rid of mediatek,larb " Evan Green
2019-02-25 23:56     ` [PATCH 12/13] arm: dts: mediatek: Get rid of mediatek, larb " Evan Green
2019-02-25 23:56     ` Evan Green
2019-01-01  4:51 ` [PATCH 13/13] arm64: dts: mediatek: Get rid of mediatek,larb " Yong Wu
2019-01-01  4:51   ` [PATCH 13/13] arm64: dts: mediatek: Get rid of mediatek, larb " Yong Wu
2019-01-01  4:51   ` Yong Wu
2019-02-25 23:56   ` [PATCH 13/13] arm64: dts: mediatek: Get rid of mediatek,larb " Evan Green
2019-02-25 23:56     ` [PATCH 13/13] arm64: dts: mediatek: Get rid of mediatek, larb " Evan Green
2019-02-25 23:56     ` Evan Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1546318276-18993-11-git-send-email-yong.wu@mediatek.com \
    --to=yong.wu@mediatek.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@google.com \
    --cc=will.deacon@arm.com \
    --cc=yingjoe.chen@mediatek.com \
    --cc=youlin.pei@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.