All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sameer Pujar <spujar@nvidia.com>
To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, Sameer Pujar <spujar@nvidia.com>
Subject: [PATCH 3/5] ALSA: hda: add register offset for stripe control
Date: Thu, 10 Jan 2019 22:33:23 +0530	[thread overview]
Message-ID: <1547139805-1904-3-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1547139805-1904-1-git-send-email-spujar@nvidia.com>

bits 16:17 in SD_CTL register refer to stripe control. Added an
offset register(AZX_REG_SD_CTL_3B) to have exclusive read/write
of corresponding register byte. This helps to avoid unnecessary
32-bit read/write of SD_CTL whenever only stripe or other bits of
corresponding byte need to be updated. Also HD audio spec defines
SD_CTL as 3 byte register.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>
Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>
---
 include/sound/hda_register.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/sound/hda_register.h b/include/sound/hda_register.h
index 2ab39fb..5b1f5d8 100644
--- a/include/sound/hda_register.h
+++ b/include/sound/hda_register.h
@@ -79,6 +79,7 @@ enum { SDI0, SDI1, SDI2, SDI3, SDO0, SDO1, SDO2, SDO3 };
 
 /* stream register offsets from stream base */
 #define AZX_REG_SD_CTL			0x00
+#define AZX_REG_SD_CTL_3B		0x02 /* 3rd byte of SD_CTL register */
 #define AZX_REG_SD_STS			0x03
 #define AZX_REG_SD_LPIB			0x04
 #define AZX_REG_SD_CBL			0x08
-- 
2.7.4


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

  parent reply	other threads:[~2019-01-10 17:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 17:03 [PATCH 1/5] ALSA: hda: add verbs for stripe control Sameer Pujar
2019-01-10 17:03 ` [PATCH 2/5] ALSA: hda: Add api to program stripe control bits Sameer Pujar
2019-01-10 17:03 ` Sameer Pujar [this message]
2019-01-10 17:03 ` [PATCH 4/5] ALSA: hda: program stripe bits for controller Sameer Pujar
2019-01-11 11:20   ` Takashi Iwai
2019-01-10 17:03 ` [PATCH 5/5] ALSA: hda: program stripe control for codec Sameer Pujar
2019-01-11 11:21   ` Takashi Iwai
2019-01-11 11:22 ` [PATCH 1/5] ALSA: hda: add verbs for stripe control Takashi Iwai
2019-01-11 11:30   ` Sameer Pujar
2019-01-11 11:47     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547139805-1904-3-git-send-email-spujar@nvidia.com \
    --to=spujar@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.