From: qii wang <qii.wang@mediatek.com>
To: <wsa@the-dreams.de>
Cc: <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
<qii.wang@mediatek.com>, <ryder.lee@mediatek.com>,
<xinping.qian@mediatek.com>, <liguo.zhang@mediatek.com>
Subject: [PATCH v3 3/6] i2c: mediatek: remove completion_done()
Date: Mon, 21 Jan 2019 15:59:31 +0800 [thread overview]
Message-ID: <1548057574-8061-4-git-send-email-qii.wang@mediatek.com> (raw)
In-Reply-To: <1548057574-8061-1-git-send-email-qii.wang@mediatek.com>
Completion_done() is useless when we don't use its return value,
so we remove it.
Signed-off-by: qii wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 7396449..660de1e 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -642,8 +642,6 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
return -ETIMEDOUT;
}
- completion_done(&i2c->msg_complete);
-
if (i2c->irq_stat & (I2C_HS_NACKERR | I2C_ACKERR)) {
dev_dbg(i2c->dev, "addr: %x, transfer ACK error\n", msgs->addr);
mtk_i2c_init_hw(i2c);
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: qii wang <qii.wang@mediatek.com>
To: wsa@the-dreams.de
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
srv_heupstream@mediatek.com, leilk.liu@mediatek.com,
qii.wang@mediatek.com, ryder.lee@mediatek.com,
xinping.qian@mediatek.com, liguo.zhang@mediatek.com
Subject: [PATCH v3 3/6] i2c: mediatek: remove completion_done()
Date: Mon, 21 Jan 2019 15:59:31 +0800 [thread overview]
Message-ID: <1548057574-8061-4-git-send-email-qii.wang@mediatek.com> (raw)
In-Reply-To: <1548057574-8061-1-git-send-email-qii.wang@mediatek.com>
Completion_done() is useless when we don't use its return value,
so we remove it.
Signed-off-by: qii wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 7396449..660de1e 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -642,8 +642,6 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
return -ETIMEDOUT;
}
- completion_done(&i2c->msg_complete);
-
if (i2c->irq_stat & (I2C_HS_NACKERR | I2C_ACKERR)) {
dev_dbg(i2c->dev, "addr: %x, transfer ACK error\n", msgs->addr);
mtk_i2c_init_hw(i2c);
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: qii wang <qii.wang@mediatek.com>
To: <wsa@the-dreams.de>
Cc: devicetree@vger.kernel.org, ryder.lee@mediatek.com,
qii.wang@mediatek.com, srv_heupstream@mediatek.com,
leilk.liu@mediatek.com, xinping.qian@mediatek.com,
linux-kernel@vger.kernel.org, liguo.zhang@mediatek.com,
linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/6] i2c: mediatek: remove completion_done()
Date: Mon, 21 Jan 2019 15:59:31 +0800 [thread overview]
Message-ID: <1548057574-8061-4-git-send-email-qii.wang@mediatek.com> (raw)
In-Reply-To: <1548057574-8061-1-git-send-email-qii.wang@mediatek.com>
Completion_done() is useless when we don't use its return value,
so we remove it.
Signed-off-by: qii wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 7396449..660de1e 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -642,8 +642,6 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
return -ETIMEDOUT;
}
- completion_done(&i2c->msg_complete);
-
if (i2c->irq_stat & (I2C_HS_NACKERR | I2C_ACKERR)) {
dev_dbg(i2c->dev, "addr: %x, transfer ACK error\n", msgs->addr);
mtk_i2c_init_hw(i2c);
--
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-21 8:00 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 7:59 [PATCH v3 0/6] add i2c support for mt7629 and mt8183 qii wang
2019-01-21 7:59 ` qii wang
2019-01-21 7:59 ` qii wang
2019-01-21 7:59 ` [PATCH v3 1/6] dt-bindings: i2c: Add Mediatek MT7629 i2c binding qii wang
2019-01-21 7:59 ` qii wang
2019-01-21 7:59 ` qii wang
2019-02-05 13:10 ` Wolfram Sang
2019-02-05 13:10 ` Wolfram Sang
2019-01-21 7:59 ` [PATCH v3 2/6] i2c: mediatek: speeds is replaced by macros definitions qii wang
2019-01-21 7:59 ` qii wang
2019-01-21 7:59 ` qii wang
2019-02-05 13:11 ` Wolfram Sang
2019-02-05 13:11 ` Wolfram Sang
2019-01-21 7:59 ` qii wang [this message]
2019-01-21 7:59 ` [PATCH v3 3/6] i2c: mediatek: remove completion_done() qii wang
2019-01-21 7:59 ` qii wang
2019-02-05 13:13 ` Wolfram Sang
2019-02-05 13:13 ` Wolfram Sang
2019-01-21 7:59 ` [PATCH v3 4/6] i2c: mediatek: Add offsets array for new i2c registers qii wang
2019-01-21 7:59 ` qii wang
2019-01-21 7:59 ` qii wang
2019-01-21 7:59 ` [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding qii wang
2019-01-21 7:59 ` qii wang
2019-01-21 7:59 ` qii wang
2019-02-05 13:16 ` Wolfram Sang
2019-02-05 13:16 ` Wolfram Sang
2019-02-14 1:54 ` Qii Wang
2019-02-14 1:54 ` Qii Wang
2019-02-14 1:54 ` Qii Wang
2019-02-15 9:02 ` Wolfram Sang
2019-02-15 9:02 ` Wolfram Sang
2019-02-16 11:32 ` Qii Wang
2019-02-16 11:32 ` Qii Wang
2019-02-16 11:32 ` Qii Wang
2019-02-16 12:29 ` Wolfram Sang
2019-02-16 12:29 ` Wolfram Sang
2019-02-19 13:13 ` Qii Wang
2019-02-19 13:13 ` Qii Wang
2019-02-19 13:13 ` Qii Wang
2019-02-19 13:27 ` Wolfram Sang
2019-02-19 13:27 ` Wolfram Sang
2019-01-21 7:59 ` [PATCH v3 6/6] i2c: mediatek: Add i2c support for MediaTek MT8183 qii wang
2019-01-21 7:59 ` qii wang
2019-01-21 7:59 ` qii wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548057574-8061-4-git-send-email-qii.wang@mediatek.com \
--to=qii.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=ryder.lee@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
--cc=xinping.qian@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.