From: Zhoujie Wu <zjwu@marvell.com>
To: <mb@lightnvm.io>, <linux-block@vger.kernel.org>, <javier@javigon.com>
Cc: <hongd@marvell.com>, Zhoujie Wu <zjwu@marvell.com>
Subject: [PATCH v2] lightnvm: pblk: ignore bad block wp for pblk_line_wp_is_unbalanced
Date: Thu, 24 Jan 2019 11:47:40 -0800 [thread overview]
Message-ID: <1548359260-11005-1-git-send-email-zjwu@marvell.com> (raw)
The write pointer of the bad block could be 0 or undefined, ignore
the checking of the bad block wp for pblk_line_wp_is_unbalanced to
avoid fake warning.
Signed-off-by: Zhoujie Wu <zjwu@marvell.com>
---
v2: changed according to Javier's comments.
drivers/lightnvm/pblk-recovery.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c
index 6761d2a..3a3ca95 100644
--- a/drivers/lightnvm/pblk-recovery.c
+++ b/drivers/lightnvm/pblk-recovery.c
@@ -312,21 +312,27 @@ static int pblk_line_wp_is_unbalanced(struct pblk *pblk,
struct nvm_chk_meta *chunk;
struct ppa_addr ppa;
u64 line_wp;
- int pos, i;
+ int pos, i, bit;
- rlun = &pblk->luns[0];
+ bit = find_first_zero_bit(line->blk_bitmap, lm->blk_per_line);
+ if (bit > lm->blk_per_line)
+ return 0;
+ rlun = &pblk->luns[bit];
ppa = rlun->bppa;
pos = pblk_ppa_to_pos(geo, ppa);
chunk = &line->chks[pos];
line_wp = chunk->wp;
- for (i = 1; i < lm->blk_per_line; i++) {
+ for (i = bit + 1; i < lm->blk_per_line; i++) {
rlun = &pblk->luns[i];
ppa = rlun->bppa;
pos = pblk_ppa_to_pos(geo, ppa);
chunk = &line->chks[pos];
+ if (chunk->state & NVM_CHK_ST_OFFLINE)
+ continue;
+
if (chunk->wp > line_wp)
return 1;
else if (chunk->wp < line_wp)
--
1.9.1
reply other threads:[~2019-01-24 19:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548359260-11005-1-git-send-email-zjwu@marvell.com \
--to=zjwu@marvell.com \
--cc=hongd@marvell.com \
--cc=javier@javigon.com \
--cc=linux-block@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.