All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	Chaotian Jing <chaotian.jing@mediatek.com>,
	Avri Altman <avri.altman@wdc.com>,
	Kyle Roeschley <kyle.roeschley@ni.com>,
	Hongjie Fang <hongjiefang@asrmicro.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>
Subject: [PATCH v2 1/2] mmc: core: do not retry CMD6 in __mmc_switch()
Date: Fri, 15 Feb 2019 13:59:34 +0800	[thread overview]
Message-ID: <1550210375-32270-2-git-send-email-chaotian.jing@mediatek.com> (raw)
In-Reply-To: <1550210375-32270-1-git-send-email-chaotian.jing@mediatek.com>

the response type of CMD6 is R1B, when the first CMD6 gets response
CRC error, do retry may get timeout error due to card may still in
busy state, which cause this retry make no sense.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/core/mmc_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index 9054329..c5208fb 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -562,7 +562,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
 	if (index == EXT_CSD_SANITIZE_START)
 		cmd.sanitize_busy = true;
 
-	err = mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
+	err = mmc_wait_for_cmd(host, &cmd, 0);
 	if (err)
 		goto out;
 
-- 
1.8.1.1.dirty


WARNING: multiple messages have this Message-ID (diff)
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	Chaotian Jing <chaotian.jing@mediatek.com>,
	Avri Altman <avri.altman@wdc.com>,
	Kyle Roeschley <kyle.roeschley@ni.com>,
	Hongjie Fang <hongjiefang@asrmicro.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com
Subject: [PATCH v2 1/2] mmc: core: do not retry CMD6 in __mmc_switch()
Date: Fri, 15 Feb 2019 13:59:34 +0800	[thread overview]
Message-ID: <1550210375-32270-2-git-send-email-chaotian.jing@mediatek.com> (raw)
In-Reply-To: <1550210375-32270-1-git-send-email-chaotian.jing@mediatek.com>

the response type of CMD6 is R1B, when the first CMD6 gets response
CRC error, do retry may get timeout error due to card may still in
busy state, which cause this retry make no sense.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/core/mmc_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index 9054329..c5208fb 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -562,7 +562,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
 	if (index == EXT_CSD_SANITIZE_START)
 		cmd.sanitize_busy = true;
 
-	err = mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
+	err = mmc_wait_for_cmd(host, &cmd, 0);
 	if (err)
 		goto out;
 
-- 
1.8.1.1.dirty

WARNING: multiple messages have this Message-ID (diff)
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: srv_heupstream@mediatek.com, Shawn Lin <shawn.lin@rock-chips.com>,
	linux-mmc@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-kernel@vger.kernel.org, Avri Altman <avri.altman@wdc.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Hongjie Fang <hongjiefang@asrmicro.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	Kyle Roeschley <kyle.roeschley@ni.com>,
	Chaotian Jing <chaotian.jing@mediatek.com>
Subject: [PATCH v2 1/2] mmc: core: do not retry CMD6 in __mmc_switch()
Date: Fri, 15 Feb 2019 13:59:34 +0800	[thread overview]
Message-ID: <1550210375-32270-2-git-send-email-chaotian.jing@mediatek.com> (raw)
In-Reply-To: <1550210375-32270-1-git-send-email-chaotian.jing@mediatek.com>

the response type of CMD6 is R1B, when the first CMD6 gets response
CRC error, do retry may get timeout error due to card may still in
busy state, which cause this retry make no sense.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/core/mmc_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index 9054329..c5208fb 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -562,7 +562,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
 	if (index == EXT_CSD_SANITIZE_START)
 		cmd.sanitize_busy = true;
 
-	err = mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
+	err = mmc_wait_for_cmd(host, &cmd, 0);
 	if (err)
 		goto out;
 
-- 
1.8.1.1.dirty


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-02-15  5:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  5:59 [PATCH v2] Fix HS setting in mmc_hs400_to_hs200() Chaotian Jing
2019-02-15  5:59 ` Chaotian Jing
2019-02-15  5:59 ` Chaotian Jing
2019-02-15  5:59 ` Chaotian Jing [this message]
2019-02-15  5:59   ` [PATCH v2 1/2] mmc: core: do not retry CMD6 in __mmc_switch() Chaotian Jing
2019-02-15  5:59   ` Chaotian Jing
2019-02-26  8:18   ` Ulf Hansson
2019-02-26  8:18     ` Ulf Hansson
2019-02-15  5:59 ` [PATCH v2 2/2] mmc: mmc: Fix HS setting in mmc_hs400_to_hs200() Chaotian Jing
2019-02-15  5:59   ` Chaotian Jing
2019-02-15  5:59   ` Chaotian Jing
2019-02-25 16:08   ` Ulf Hansson
2019-02-25 16:08     ` Ulf Hansson
2019-02-25 16:08     ` Ulf Hansson
2019-02-23  6:42 ` [PATCH v2] " Chaotian Jing
2019-02-23  6:42   ` Chaotian Jing
2019-02-23  6:42   ` Chaotian Jing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1550210375-32270-2-git-send-email-chaotian.jing@mediatek.com \
    --to=chaotian.jing@mediatek.com \
    --cc=adrian.hunter@intel.com \
    --cc=avri.altman@wdc.com \
    --cc=hongjiefang@asrmicro.com \
    --cc=horms+renesas@verge.net.au \
    --cc=kyle.roeschley@ni.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.