All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jenny TC <jenny.tc@intel.com>
To: alsa-devel@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Rakesh Ughreja <rakesh.a.ughreja@intel.com>,
	Sriram Periyasamy <sriramx.periyasamy@intel.com>,
	Abhijeet Kumar <abhijeet.kumar@intel.com>,
	Sanyog Kale <sanyog.r.kale@intel.com>
Cc: N Harshapriya <harshapriya.n@intel.com>,
	M Naveen <naveen.m@intel.com>,
	M R Sathya Prakash <sathya.prakash.m.r@intel.com>,
	jenny.tc@intel.com,
	Nujella Sathyanarayana <sathyanarayana.nujella@intel.com>
Subject: [PATCH] ASoC: Intel: Skylake: Set sample_type in base config
Date: Wed, 27 Feb 2019 12:34:52 +0530	[thread overview]
Message-ID: <1551251092-28304-1-git-send-email-jenny.tc@intel.com> (raw)

sample_type defined in topology configuration is not getting reflected
in the dsp param. This patch sets sample_type in base config so that
the sample type defined in the topology is reflected int eh dsp params.
This issues was uncovered while debugging the S24_LE format which
require the MSB byte in 32 bit word to be skipped. Setting sample_type
to 1 helps to fix this.

Signed-off-by: Jenny TC <jenny.tc@intel.com>
---
 sound/soc/intel/skylake/skl-messages.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index b0e6fb9..9260e9a 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -483,6 +483,7 @@ static void skl_set_base_module_format(struct skl_sst *ctx,
 	base_cfg->audio_fmt.bit_depth = format->bit_depth;
 	base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth;
 	base_cfg->audio_fmt.ch_cfg = format->ch_cfg;
+	base_cfg->audio_fmt.sample_type = format->sample_type;
 
 	dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n",
 			format->bit_depth, format->valid_bit_depth,
-- 
1.9.1

             reply	other threads:[~2019-02-27  7:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27  7:04 Jenny TC [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-02-27  6:49 [PATCH] ASoC: Intel: Skylake: Set sample_type in base config Jenny TC
2019-02-27 14:45 ` Pierre-Louis Bossart
2019-02-28  4:19   ` Tc, Jenny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1551251092-28304-1-git-send-email-jenny.tc@intel.com \
    --to=jenny.tc@intel.com \
    --cc=abhijeet.kumar@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=harshapriya.n@intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=naveen.m@intel.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rakesh.a.ughreja@intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=sathya.prakash.m.r@intel.com \
    --cc=sathyanarayana.nujella@intel.com \
    --cc=sriramx.periyasamy@intel.com \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.