All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Yang <wen.yang99@zte.com.cn>
To: liviu.dudau@arm.com
Cc: sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
	linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kgene@kernel.org, krzk@kernel.org,
	linux-samsung-soc@vger.kernel.org, michal.simek@xilinx.com,
	afaerber@suse.de, manivannan.sadhasivam@linaro.org,
	dinguyen@kernel.org, heiko@sntech.de,
	linux-rockchip@lists.infradead.org, f.fainelli@gmail.com,
	rjui@broadcom.com, sbranden@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com, linus.walleij@linaro.org,
	avifishman70@gmail.com, tmaimon77@gmail.com, venture@google.com,
	yuenn@google.com, brendanhiggins@google.com,
	openbmc@lists.ozlabs.org, xuwei5@hisilicon.com,
	maxime.ripard@bootlin.com, wens@csie.org,
	catalin.marinas@arm.com, will.deacon@arm.com, horms@verge.net.au,
	magnus.damm@gmail.com, linux-renesas-soc@vger.kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com,
	wang.yi59@zte.com.cn, Wen Yang <wen.yang99@zte.com.cn>
Subject: [PATCH 11/15] ARM: versatile: fix a leaked reference by addingmissing of_node_put
Date: Fri, 1 Mar 2019 16:56:52 +0800	[thread overview]
Message-ID: <1551430616-42014-11-git-send-email-wen.yang99@zte.com.cn> (raw)
In-Reply-To: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn>

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-versatile/versatile_dt.c:315:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.
./arch/arm/mach-versatile/versatile_dt.c:320:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/mach-versatile/versatile_dt.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-versatile/versatile_dt.c b/arch/arm/mach-versatile/versatile_dt.c
index e9d6068..028463a 100644
--- a/arch/arm/mach-versatile/versatile_dt.c
+++ b/arch/arm/mach-versatile/versatile_dt.c
@@ -312,12 +312,12 @@ static void __init versatile_dt_pci_init(void)
 		 * driver had it so we will keep it.
 		 */
 		writel(1, versatile_sys_base + VERSATILE_SYS_PCICTL_OFFSET);
-		return;
+		goto out_put_node;
 	}
 
 	newprop = kzalloc(sizeof(*newprop), GFP_KERNEL);
 	if (!newprop)
-		return;
+		goto out_put_node;
 
 	newprop->name = kstrdup("status", GFP_KERNEL);
 	newprop->value = kstrdup("disabled", GFP_KERNEL);
@@ -325,6 +325,9 @@ static void __init versatile_dt_pci_init(void)
 	of_update_property(np, newprop);
 
 	pr_info("Not plugged into PCI backplane!\n");
+
+out_put_node:
+	of_node_put(np);
 }
 
 static void __init versatile_dt_init(void)
-- 
2.9.5


WARNING: multiple messages have this Message-ID (diff)
From: Wen Yang <wen.yang99@zte.com.cn>
To: liviu.dudau@arm.com
Cc: sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
	linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kgene@kernel.org, krzk@kernel.org,
	linux-samsung-soc@vger.kernel.org, michal.simek@xilinx.com,
	afaerber@suse.de, manivannan.sadhasivam@linaro.org,
	dinguyen@kernel.org, heiko@sntech.de,
	linux-rockchip@lists.infradead.org, f.fainelli@gmail.com,
	rjui@broadcom.com, sbranden@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com, linus.walleij@linaro.org,
	avifishman70@gmail.com, tmaimon77@gmail.com, venture@google.com,
	yuenn@google.com, brendanhiggins@google.com,
	openbmc@lists.ozlabs.org, xuwei5@hisilicon.com,
	maxime.ripard@bootlin.com, wens@csie.org,
	catalin.marinas@arm.com, will.deacon@arm.com, horms@verge.net.au,
	magnus.damm@gmail.comlinux
Subject: [PATCH 11/15] ARM: versatile: fix a leaked reference by addingmissing of_node_put
Date: Fri, 1 Mar 2019 16:56:52 +0800	[thread overview]
Message-ID: <1551430616-42014-11-git-send-email-wen.yang99@zte.com.cn> (raw)
In-Reply-To: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn>

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-versatile/versatile_dt.c:315:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.
./arch/arm/mach-versatile/versatile_dt.c:320:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/mach-versatile/versatile_dt.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-versatile/versatile_dt.c b/arch/arm/mach-versatile/versatile_dt.c
index e9d6068..028463a 100644
--- a/arch/arm/mach-versatile/versatile_dt.c
+++ b/arch/arm/mach-versatile/versatile_dt.c
@@ -312,12 +312,12 @@ static void __init versatile_dt_pci_init(void)
 		 * driver had it so we will keep it.
 		 */
 		writel(1, versatile_sys_base + VERSATILE_SYS_PCICTL_OFFSET);
-		return;
+		goto out_put_node;
 	}
 
 	newprop = kzalloc(sizeof(*newprop), GFP_KERNEL);
 	if (!newprop)
-		return;
+		goto out_put_node;
 
 	newprop->name = kstrdup("status", GFP_KERNEL);
 	newprop->value = kstrdup("disabled", GFP_KERNEL);
@@ -325,6 +325,9 @@ static void __init versatile_dt_pci_init(void)
 	of_update_property(np, newprop);
 
 	pr_info("Not plugged into PCI backplane!\n");
+
+out_put_node:
+	of_node_put(np);
 }
 
 static void __init versatile_dt_init(void)
-- 
2.9.5

WARNING: multiple messages have this Message-ID (diff)
From: Wen Yang <wen.yang99@zte.com.cn>
To: liviu.dudau@arm.com
Cc: heiko@sntech.de, maxime.ripard@bootlin.com,
	catalin.marinas@arm.com, linus.walleij@linaro.org,
	brendanhiggins@google.com, michal.simek@xilinx.com,
	xuwei5@hisilicon.com, manivannan.sadhasivam@linaro.org,
	Wen Yang <wen.yang99@zte.com.cn>,
	tmaimon77@gmail.com, f.fainelli@gmail.com,
	linux-rockchip@lists.infradead.org, will.deacon@arm.com,
	openbmc@lists.ozlabs.org, magnus.damm@gmail.com,
	linux@armlinux.org.uk, krzk@kernel.org,
	linux-samsung-soc@vger.kernel.org, wens@csie.org,
	kgene@kernel.org, bcm-kernel-feedback-list@broadcom.com,
	linux-imx@nxp.com, wang.yi59@zte.com.cn, rjui@broadcom.com,
	s.hauer@pengutronix.de, lorenzo.pieralisi@arm.com,
	yuenn@google.com, linux-arm-kernel@lists.infradead.org,
	sbranden@broadcom.com, avifishman70@gmail.com,
	venture@google.com, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, dinguyen@kernel.org,
	horms@verge.net.au, kernel@pengutronix.de, sudeep.holla@arm.com,
	fabio.estevam@nxp.com, shawnguo@kernel.org, afaerber@suse.de
Subject: [PATCH 11/15] ARM: versatile: fix a leaked reference by addingmissing of_node_put
Date: Fri, 1 Mar 2019 16:56:52 +0800	[thread overview]
Message-ID: <1551430616-42014-11-git-send-email-wen.yang99@zte.com.cn> (raw)
In-Reply-To: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn>

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-versatile/versatile_dt.c:315:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.
./arch/arm/mach-versatile/versatile_dt.c:320:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/mach-versatile/versatile_dt.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-versatile/versatile_dt.c b/arch/arm/mach-versatile/versatile_dt.c
index e9d6068..028463a 100644
--- a/arch/arm/mach-versatile/versatile_dt.c
+++ b/arch/arm/mach-versatile/versatile_dt.c
@@ -312,12 +312,12 @@ static void __init versatile_dt_pci_init(void)
 		 * driver had it so we will keep it.
 		 */
 		writel(1, versatile_sys_base + VERSATILE_SYS_PCICTL_OFFSET);
-		return;
+		goto out_put_node;
 	}
 
 	newprop = kzalloc(sizeof(*newprop), GFP_KERNEL);
 	if (!newprop)
-		return;
+		goto out_put_node;
 
 	newprop->name = kstrdup("status", GFP_KERNEL);
 	newprop->value = kstrdup("disabled", GFP_KERNEL);
@@ -325,6 +325,9 @@ static void __init versatile_dt_pci_init(void)
 	of_update_property(np, newprop);
 
 	pr_info("Not plugged into PCI backplane!\n");
+
+out_put_node:
+	of_node_put(np);
 }
 
 static void __init versatile_dt_init(void)
-- 
2.9.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-03-01  8:57 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01  8:56 [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put Wen Yang
2019-03-01  8:56 ` Wen Yang
2019-03-01  8:56 ` Wen Yang
2019-03-01  8:56 ` [PATCH 02/15] ARM: bcm: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01 18:28   ` Florian Fainelli
2019-03-01 18:28     ` Florian Fainelli
2019-03-01 18:28     ` Florian Fainelli
2019-03-01  8:56 ` [PATCH 03/15] ARM: exynos: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  9:14   ` Krzysztof Kozlowski
2019-03-01  9:14     ` Krzysztof Kozlowski
2019-03-01  9:14     ` Krzysztof Kozlowski
2019-03-01  9:14     ` Krzysztof Kozlowski
2019-03-01  8:56 ` [PATCH 04/15] ARM: hisi: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56 ` [PATCH 05/15] ARM: imx51: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-04  5:37   ` Shawn Guo
2019-03-04  5:37     ` Shawn Guo
2019-03-04  5:37     ` Shawn Guo
2019-03-01  8:56 ` [PATCH 06/15] arm: npcm: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-04 15:39   ` Avi Fishman
2019-03-04 15:39     ` Avi Fishman
2019-03-04 15:39     ` Avi Fishman
2019-03-04 15:39     ` Avi Fishman
2019-03-01  8:56 ` [PATCH 07/15] ARM: rockchip: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56 ` [PATCH 08/15] ARM: shmobile: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  9:51   ` Geert Uytterhoeven
2019-03-01  9:51     ` Geert Uytterhoeven
2019-03-01  9:51     ` Geert Uytterhoeven
2019-03-04 10:24     ` Simon Horman
2019-03-04 10:24       ` Simon Horman
2019-03-04 10:24       ` Simon Horman
2019-03-04 10:55       ` Fabrizio Castro
2019-03-04 10:55         ` Fabrizio Castro
2019-03-04 10:55         ` Fabrizio Castro
2019-03-06 13:00         ` Simon Horman
2019-03-06 13:00           ` Simon Horman
2019-03-06 13:00           ` Simon Horman
2019-03-01  8:56 ` [PATCH 09/15] ARM: socfpga: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56 ` [PATCH 10/15] ARM: sunxi: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56 ` Wen Yang [this message]
2019-03-01  8:56   ` [PATCH 11/15] ARM: versatile: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01 13:30   ` Linus Walleij
2019-03-01 13:30     ` Linus Walleij
2019-03-01 13:30     ` Linus Walleij
2019-03-01  8:56 ` [PATCH 12/15] ARM: vexpress: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-04 14:46   ` Sudeep Holla
2019-03-04 14:46     ` Sudeep Holla
2019-03-04 14:46     ` Sudeep Holla
2019-03-05  1:27     ` [PATCH 12/15] ARM: vexpress: fix a leaked reference byaddingmissing of_node_put wen.yang99
2019-03-01  8:56 ` [PATCH 13/15] ARM: zynq: fix a leaked reference by addingmissing of_node_put Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56 ` [PATCH 14/15] arm64: cpu_ops: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56 ` [PATCH 15/15] ARM: axxia: " Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01  8:56   ` Wen Yang
2019-03-01 15:55 ` [PATCH 01/15] ARM: actions: " Manivannan Sadhasivam
2019-03-01 15:55   ` Manivannan Sadhasivam
2019-03-01 15:55   ` Manivannan Sadhasivam
2019-03-04 12:29   ` Linus Walleij
2019-03-04 12:29     ` Linus Walleij
2019-03-04 12:29     ` Linus Walleij
2019-03-04 14:48     ` Manivannan Sadhasivam
2019-03-04 14:48       ` Manivannan Sadhasivam
2019-03-04 14:48       ` Manivannan Sadhasivam
2019-03-04 22:37       ` Linus Walleij
2019-03-04 22:37         ` Linus Walleij
2019-03-04 22:37         ` Linus Walleij
2019-03-05  1:51         ` Manivannan Sadhasivam
2019-03-05  9:55           ` Russell King - ARM Linux admin
2019-03-05  9:55             ` Russell King - ARM Linux admin
2019-03-05  9:55             ` Russell King - ARM Linux admin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1551430616-42014-11-git-send-email-wen.yang99@zte.com.cn \
    --to=wen.yang99@zte.com.cn \
    --cc=afaerber@suse.de \
    --cc=avifishman70@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=brendanhiggins@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=dinguyen@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=heiko@sntech.de \
    --cc=horms@verge.net.au \
    --cc=kernel@pengutronix.de \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=magnus.damm@gmail.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=michal.simek@xilinx.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=rjui@broadcom.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sbranden@broadcom.com \
    --cc=shawnguo@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=wang.yi59@zte.com.cn \
    --cc=wens@csie.org \
    --cc=will.deacon@arm.com \
    --cc=xuwei5@hisilicon.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.