From: tangwenji <hndksztwj@163.com>
To: target-devel@vger.kernel.org
Subject: [PATCH] target:iscsi:fix np_ip_proto and np_sock_type in iscsit_setup_np
Date: Wed, 13 Mar 2019 14:56:38 +0000 [thread overview]
Message-ID: <1552488998-3604-1-git-send-email-hndksztwj@163.com> (raw)
From: tangwenji <tang.wenji@zte.com.cn>
In the switch, np_ip_proto and np_sock_type set different values according to np_network_transport, and then uniformly assign values, so the previous values are overwritten.
Signed-off-by: tangwenji <tang.wenji@zte.com.cn>
---
drivers/target/iscsi/iscsi_target_login.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
index ae3209e..c526e66 100644
--- a/drivers/target/iscsi/iscsi_target_login.c
+++ b/drivers/target/iscsi/iscsi_target_login.c
@@ -883,9 +883,6 @@ int iscsit_setup_np(
return -EINVAL;
}
- np->np_ip_proto = IPPROTO_TCP;
- np->np_sock_type = SOCK_STREAM;
-
ret = sock_create(sockaddr->ss_family, np->np_sock_type,
np->np_ip_proto, &sock);
if (ret < 0) {
--
2.5.0.windows.1
next reply other threads:[~2019-03-13 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 14:56 tangwenji [this message]
2019-03-20 16:59 ` [PATCH] target:iscsi:fix np_ip_proto and np_sock_type in iscsit_setup_np Mike Christie
2019-03-21 0:37 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552488998-3604-1-git-send-email-hndksztwj@163.com \
--to=hndksztwj@163.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.