From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 1/4] btrfs: fix zstd compression parameter
Date: Thu, 14 Mar 2019 13:05:03 +0800 [thread overview]
Message-ID: <1552539906-29703-2-git-send-email-anand.jain@oracle.com> (raw)
In-Reply-To: <1552539906-29703-1-git-send-email-anand.jain@oracle.com>
We let to pass zstd compression parameter even if its not fully written.
For example:
btrfs prop set /btrfs compression zst
btrfs prop get /btrfs compression
compression=zst
zlib and lzo are fine.
Fix it by using the expected number of char in strncmp().
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/props.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/props.c b/fs/btrfs/props.c
index f1a8be67f639..3cc007e3c7f8 100644
--- a/fs/btrfs/props.c
+++ b/fs/btrfs/props.c
@@ -304,7 +304,7 @@ static int prop_compression_apply(struct inode *inode, const char *value,
btrfs_set_fs_incompat(fs_info, COMPRESS_LZO);
} else if (!strncmp("zlib", value, 4)) {
type = BTRFS_COMPRESS_ZLIB;
- } else if (!strncmp("zstd", value, len)) {
+ } else if (!strncmp("zstd", value, 4)) {
type = BTRFS_COMPRESS_ZSTD;
btrfs_set_fs_incompat(fs_info, COMPRESS_ZSTD);
} else {
--
1.8.3.1
next prev parent reply other threads:[~2019-03-14 5:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 5:05 [PATCH 0/4] btrfs: fix property bugs Anand Jain
2019-03-14 5:05 ` Anand Jain [this message]
2019-03-14 5:05 ` [PATCH 2/4] btrfs: fix vanished compression property after failed set Anand Jain
2019-03-14 8:32 ` Nikolay Borisov
2019-03-14 8:57 ` Anand Jain
2019-03-14 5:05 ` [PATCH 3/4] btrfs: open code btrfs_set_prop in inherit_prop Anand Jain
2019-03-14 8:57 ` Nikolay Borisov
2019-03-14 9:08 ` Anand Jain
2019-03-14 5:05 ` [PATCH 4/4] btrfs: fix property validate fail should not increment generation Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552539906-29703-2-git-send-email-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.