All of lore.kernel.org
 help / color / mirror / Atom feed
From: libin.yang@intel.com
To: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org,
	pierre-louis.bossart@linux.intel.com
Cc: libin.yang@intel.com
Subject: [PATCH v3 07/12] ASoC: intel: kbl_da7219_max98927: add device_link to HDMI audio
Date: Thu, 11 Apr 2019 22:19:55 +0800	[thread overview]
Message-ID: <1554992400-28777-8-git-send-email-libin.yang@intel.com> (raw)
In-Reply-To: <1554992400-28777-1-git-send-email-libin.yang@intel.com>

From: Libin Yang <libin.yang@intel.com>

In resume from S3, HDAC HDMI codec driver dapm event callback may be
operated before HDMI codec driver turns on the display audio power
domain because of the contest between display driver and hdmi codec driver.

This patch adds the device_link between kbl_da7219_max98927 machine device
(consumer) and hdmi codec device (supplier) to make sure the sequence is
always correct.

Signed-off-by: Libin Yang <libin.yang@intel.com>
---
 sound/soc/intel/boards/kbl_da7219_max98927.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/kbl_da7219_max98927.c b/sound/soc/intel/boards/kbl_da7219_max98927.c
index f72a7bf..575c21e 100644
--- a/sound/soc/intel/boards/kbl_da7219_max98927.c
+++ b/sound/soc/intel/boards/kbl_da7219_max98927.c
@@ -21,6 +21,7 @@
 #include "../../codecs/hdac_hdmi.h"
 #include "../skylake/skl.h"
 #include "../../codecs/da7219-aad.h"
+#include "hdac_hdmi_common.h"
 
 #define KBL_DIALOG_CODEC_DAI	"da7219-hifi"
 #define MAX98927_CODEC_DAI	"max98927-aif1"
@@ -48,6 +49,7 @@ struct kbl_hdmi_pcm {
 struct kbl_codec_private {
 	struct snd_soc_jack kabylake_headset;
 	struct list_head hdmi_pcm_list;
+	struct device_link *link;
 };
 
 enum {
@@ -339,7 +341,8 @@ static int kabylake_hdmi_init(struct snd_soc_pcm_runtime *rtd, int device)
 
 	list_add_tail(&pcm->head, &ctx->hdmi_pcm_list);
 
-	return 0;
+	/* Setup a device_link between machine device and HDMI codec device. */
+	return hdac_hdmi_add_device_link(rtd->card->dev, dai->dev, &ctx->link);
 }
 
 static int kabylake_hdmi1_init(struct snd_soc_pcm_runtime *rtd)
-- 
2.7.4

  parent reply	other threads:[~2019-04-11 14:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 14:19 [PATCH v3 00/12] ASoC: intel: add device_link to HDMI audio libin.yang
2019-04-11 14:19 ` [PATCH v3 01/12] ASoC: intel: boards: define some general functions for hdac_hdmi libin.yang
2019-04-11 14:47   ` Takashi Iwai
2019-04-12  2:35     ` Yang, Libin
2019-04-11 14:19 ` [PATCH v3 02/12] ASoC: intel: skl_hda_dsp_generic: add device_link to HDMI audio libin.yang
2019-04-11 14:19 ` [PATCH v3 03/12] ASoC: intel: bxt_da7219_max98357a: " libin.yang
2019-04-11 14:19 ` [PATCH v3 04/12] ASoC: intel: bxt_rt298: " libin.yang
2019-04-11 14:19 ` [PATCH v3 05/12] ASoC: intel: glk_rt5682_max98357a: " libin.yang
2019-04-11 14:19 ` [PATCH v3 06/12] ASoC: intel: kbl_da7219_max98357a: " libin.yang
2019-04-11 14:19 ` libin.yang [this message]
2019-04-11 14:19 ` [PATCH v3 08/12] ASoC: intel: kbl_rt5660: " libin.yang
2019-04-11 14:19 ` [PATCH v3 09/12] ASoC: intel: kbl_rt5663_max98927 " libin.yang
2019-04-11 14:19 ` [PATCH v3 10/12] ASoC: intel: kbl_rt5663_rt5514_max98927 " libin.yang
2019-04-11 14:19 ` [PATCH v3 11/12] ASoC: intel: skl_nau88l25_max98357a " libin.yang
2019-04-11 14:20 ` [PATCH v3 12/12] ASoC: intel: skl_nau88l25_ssm4567 " libin.yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554992400-28777-8-git-send-email-libin.yang@intel.com \
    --to=libin.yang@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.