From: "Petr Štetiar" <ynezz@true.cz> To: netdev@vger.kernel.org, devicetree@vger.kernel.org, QCA ath9k Development <ath9k-devel@qca.qualcomm.com>, Kalle Valo <kvalo@codeaurora.org>, Stanislaw Gruszka <sgruszka@redhat.com>, Helmut Schaa <helmut.schaa@googlemail.com>, Matthias Brugger <matthias.bgg@gmail.com> Cc: "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail.com>, "Heiner Kallweit" <hkallweit1@gmail.com>, "Frank Rowand" <frowand.list@gmail.com>, "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>, "Maxime Ripard" <maxime.ripard@bootlin.com>, "Petr Štetiar" <ynezz@true.cz>, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 07/10] net: wireless: support of_get_mac_address new ERR_PTR error Date: Fri, 3 May 2019 09:56:04 +0200 [thread overview] Message-ID: <1556870168-26864-8-git-send-email-ynezz@true.cz> (raw) In-Reply-To: <1556870168-26864-1-git-send-email-ynezz@true.cz> There was NVMEM support added to of_get_mac_address, so it could now return NULL and ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. Signed-off-by: Petr Štetiar <ynezz@true.cz> --- drivers/net/wireless/ath/ath9k/init.c | 2 +- drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c index 98141b6..8be2da8 100644 --- a/drivers/net/wireless/ath/ath9k/init.c +++ b/drivers/net/wireless/ath/ath9k/init.c @@ -642,7 +642,7 @@ static int ath9k_of_init(struct ath_softc *sc) } mac = of_get_mac_address(np); - if (mac) + if (!IS_ERR_OR_NULL(mac)) ether_addr_copy(common->macaddr, mac); return 0; diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c index a1529920d..7cb16ba 100644 --- a/drivers/net/wireless/mediatek/mt76/eeprom.c +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c @@ -94,7 +94,7 @@ return; mac = of_get_mac_address(np); - if (mac) + if (!IS_ERR_OR_NULL(mac)) memcpy(dev->macaddr, mac, ETH_ALEN); #endif diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c index 357c094..ef52467 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c @@ -1007,7 +1007,7 @@ void rt2x00lib_set_mac_address(struct rt2x00_dev *rt2x00dev, u8 *eeprom_mac_addr const char *mac_addr; mac_addr = of_get_mac_address(rt2x00dev->dev->of_node); - if (mac_addr) + if (!IS_ERR_OR_NULL(mac_addr)) ether_addr_copy(eeprom_mac_addr, mac_addr); if (!is_valid_ether_addr(eeprom_mac_addr)) { -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: "Petr Štetiar" <ynezz@true.cz> To: netdev@vger.kernel.org, devicetree@vger.kernel.org, QCA ath9k Development <ath9k-devel@qca.qualcomm.com>, Kalle Valo <kvalo@codeaurora.org>, Stanislaw Gruszka <sgruszka@redhat.com>, Helmut Schaa <helmut.schaa@googlemail.com>, Matthias Brugger <matthias.bgg@gmail.com> Cc: "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail.com>, "Maxime Ripard" <maxime.ripard@bootlin.com>, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>, linux-mediatek@lists.infradead.org, "Petr Štetiar" <ynezz@true.cz>, "Frank Rowand" <frowand.list@gmail.com>, linux-arm-kernel@lists.infradead.org, "Heiner Kallweit" <hkallweit1@gmail.com> Subject: [PATCH v3 07/10] net: wireless: support of_get_mac_address new ERR_PTR error Date: Fri, 3 May 2019 09:56:04 +0200 [thread overview] Message-ID: <1556870168-26864-8-git-send-email-ynezz@true.cz> (raw) In-Reply-To: <1556870168-26864-1-git-send-email-ynezz@true.cz> There was NVMEM support added to of_get_mac_address, so it could now return NULL and ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. Signed-off-by: Petr Štetiar <ynezz@true.cz> --- drivers/net/wireless/ath/ath9k/init.c | 2 +- drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c index 98141b6..8be2da8 100644 --- a/drivers/net/wireless/ath/ath9k/init.c +++ b/drivers/net/wireless/ath/ath9k/init.c @@ -642,7 +642,7 @@ static int ath9k_of_init(struct ath_softc *sc) } mac = of_get_mac_address(np); - if (mac) + if (!IS_ERR_OR_NULL(mac)) ether_addr_copy(common->macaddr, mac); return 0; diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c index a1529920d..7cb16ba 100644 --- a/drivers/net/wireless/mediatek/mt76/eeprom.c +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c @@ -94,7 +94,7 @@ return; mac = of_get_mac_address(np); - if (mac) + if (!IS_ERR_OR_NULL(mac)) memcpy(dev->macaddr, mac, ETH_ALEN); #endif diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c index 357c094..ef52467 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c @@ -1007,7 +1007,7 @@ void rt2x00lib_set_mac_address(struct rt2x00_dev *rt2x00dev, u8 *eeprom_mac_addr const char *mac_addr; mac_addr = of_get_mac_address(rt2x00dev->dev->of_node); - if (mac_addr) + if (!IS_ERR_OR_NULL(mac_addr)) ether_addr_copy(eeprom_mac_addr, mac_addr); if (!is_valid_ether_addr(eeprom_mac_addr)) { -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-03 7:57 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-03 7:55 [PATCH v3 00/10] of_net: Add NVMEM support to of_get_mac_address Petr Štetiar 2019-05-03 7:55 ` Petr Štetiar 2019-05-03 7:55 ` [PATCH v3 01/10] of_net: add " Petr Štetiar 2019-05-03 8:44 ` Sergei Shtylyov 2019-05-03 9:15 ` Petr Štetiar 2019-05-03 9:36 ` Maxime Ripard 2019-05-03 12:05 ` Andrew Lunn 2019-05-03 7:55 ` [PATCH v3 02/10] dt-bindings: doc: reflect new NVMEM of_get_mac_address behaviour Petr Štetiar 2019-05-03 7:55 ` Petr Štetiar 2019-05-03 7:55 ` Petr Štetiar 2019-05-03 7:56 ` [PATCH v3 03/10] net: macb: support of_get_mac_address new ERR_PTR error Petr Štetiar 2019-05-03 7:56 ` [PATCH v3 04/10] net: davinci: " Petr Štetiar 2019-05-03 7:56 ` [PATCH v3 05/10] net: ethernet: " Petr Štetiar 2019-05-03 7:56 ` Petr Štetiar 2019-05-03 7:56 ` Petr Štetiar 2019-05-03 7:56 ` [PATCH v3 06/10] net: usb: " Petr Štetiar 2019-05-03 7:56 ` [v3,06/10] " Petr Štetiar 2019-05-03 7:56 ` Petr Štetiar [this message] 2019-05-03 7:56 ` [PATCH v3 07/10] net: wireless: " Petr Štetiar 2019-05-03 7:56 ` [PATCH v3 08/10] staging: octeon-ethernet: " Petr Štetiar 2019-05-03 10:34 ` Dan Carpenter 2019-05-03 10:34 ` Dan Carpenter 2019-05-03 19:07 ` Petr Štetiar 2019-05-03 19:07 ` Petr Štetiar 2019-05-03 19:40 ` Dan Carpenter 2019-05-03 19:40 ` Dan Carpenter 2019-05-03 7:56 ` [PATCH v3 09/10] ARM: Kirkwood: " Petr Štetiar 2019-05-03 7:56 ` Petr Štetiar 2019-05-03 7:56 ` [PATCH v3 10/10] powerpc: tsi108: " Petr Štetiar 2019-05-03 7:56 ` Petr Štetiar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1556870168-26864-8-git-send-email-ynezz@true.cz \ --to=ynezz@true.cz \ --cc=andrew@lunn.ch \ --cc=ath9k-devel@qca.qualcomm.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=frowand.list@gmail.com \ --cc=helmut.schaa@googlemail.com \ --cc=hkallweit1@gmail.com \ --cc=kvalo@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=maxime.ripard@bootlin.com \ --cc=netdev@vger.kernel.org \ --cc=sgruszka@redhat.com \ --cc=srinivas.kandagatla@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.