All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chun-Hung Wu <chun-hung.wu@mediatek.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <wsd_upstream@mediatek.com>,
	<peter.wang@mediatek.com>, <kuohong.wang@mediatek.com>,
	<jg_poxu@mediatek.com>, Chun-Hung Wu <chun-hung.wu@mediatek.com>
Subject: [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall
Date: Thu, 16 May 2019 16:10:47 +0800	[thread overview]
Message-ID: <1557994247-16739-5-git-send-email-chun-hung.wu@mediatek.com> (raw)
In-Reply-To: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com>

  Move auxadc platform_driver_register() from module_init
to subsys_initcall because auxadc user drivers
are all moudle drivers, need to gurantee
auxadc driver ready before module_init.

Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
---
 drivers/iio/adc/mt6577_auxadc.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index 58d7cb2..cb8e3dd 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -350,7 +350,19 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
 	.probe	= mt6577_auxadc_probe,
 	.remove	= mt6577_auxadc_remove,
 };
-module_platform_driver(mt6577_auxadc_driver);
+
+static int __init mt6577_auxadc_init(void)
+{
+	return platform_driver_register(&mt6577_auxadc_driver);
+}
+
+static void __exit mt6577_auxadc_exit(void)
+{
+	platform_driver_unregister(&mt6577_auxadc_driver);
+}
+
+subsys_initcall(mt6577_auxadc_init);
+module_exit(mt6577_auxadc_exit);
 
 MODULE_AUTHOR("Zhiyong Tao <zhiyong.tao@mediatek.com>");
 MODULE_DESCRIPTION("MTK AUXADC Device Driver");
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Chun-Hung Wu <chun-hung.wu@mediatek.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
	linux-iio@vger.kernel.org,
	Chun-Hung Wu <chun-hung.wu@mediatek.com>,
	kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
	jg_poxu@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall
Date: Thu, 16 May 2019 16:10:47 +0800	[thread overview]
Message-ID: <1557994247-16739-5-git-send-email-chun-hung.wu@mediatek.com> (raw)
In-Reply-To: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com>

  Move auxadc platform_driver_register() from module_init
to subsys_initcall because auxadc user drivers
are all moudle drivers, need to gurantee
auxadc driver ready before module_init.

Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
---
 drivers/iio/adc/mt6577_auxadc.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index 58d7cb2..cb8e3dd 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -350,7 +350,19 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
 	.probe	= mt6577_auxadc_probe,
 	.remove	= mt6577_auxadc_remove,
 };
-module_platform_driver(mt6577_auxadc_driver);
+
+static int __init mt6577_auxadc_init(void)
+{
+	return platform_driver_register(&mt6577_auxadc_driver);
+}
+
+static void __exit mt6577_auxadc_exit(void)
+{
+	platform_driver_unregister(&mt6577_auxadc_driver);
+}
+
+subsys_initcall(mt6577_auxadc_init);
+module_exit(mt6577_auxadc_exit);
 
 MODULE_AUTHOR("Zhiyong Tao <zhiyong.tao@mediatek.com>");
 MODULE_DESCRIPTION("MTK AUXADC Device Driver");
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Chun-Hung Wu <chun-hung.wu@mediatek.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
	linux-iio@vger.kernel.org,
	Chun-Hung Wu <chun-hung.wu@mediatek.com>,
	kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
	jg_poxu@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall
Date: Thu, 16 May 2019 16:10:47 +0800	[thread overview]
Message-ID: <1557994247-16739-5-git-send-email-chun-hung.wu@mediatek.com> (raw)
In-Reply-To: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com>

  Move auxadc platform_driver_register() from module_init
to subsys_initcall because auxadc user drivers
are all moudle drivers, need to gurantee
auxadc driver ready before module_init.

Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
---
 drivers/iio/adc/mt6577_auxadc.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index 58d7cb2..cb8e3dd 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -350,7 +350,19 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
 	.probe	= mt6577_auxadc_probe,
 	.remove	= mt6577_auxadc_remove,
 };
-module_platform_driver(mt6577_auxadc_driver);
+
+static int __init mt6577_auxadc_init(void)
+{
+	return platform_driver_register(&mt6577_auxadc_driver);
+}
+
+static void __exit mt6577_auxadc_exit(void)
+{
+	platform_driver_unregister(&mt6577_auxadc_driver);
+}
+
+subsys_initcall(mt6577_auxadc_init);
+module_exit(mt6577_auxadc_exit);
 
 MODULE_AUTHOR("Zhiyong Tao <zhiyong.tao@mediatek.com>");
 MODULE_DESCRIPTION("MTK AUXADC Device Driver");
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-05-16  8:11 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  8:10 [PATCH 0/4] iio: adc: mediatek: add mt6765 driver support Chun-Hung Wu
2019-05-16  8:10 ` Chun-Hung Wu
2019-05-16  8:10 ` Chun-Hung Wu
2019-05-16  8:10 ` [PATCH 1/4] dt-bindings: iio: adc: mediatek: Add document for mt6765 Chun-Hung Wu
2019-05-16  8:10   ` Chun-Hung Wu
2019-05-16  8:10   ` Chun-Hung Wu
2019-05-18 10:33   ` Jonathan Cameron
2019-05-18 10:33     ` Jonathan Cameron
2019-05-18 10:33     ` Jonathan Cameron
2019-05-20  6:47     ` Chun-Hung Wu
2019-05-20  6:47       ` Chun-Hung Wu
2019-05-20  6:47       ` Chun-Hung Wu
2019-05-16  8:10 ` [PATCH 2/4] iio: adc: mediatek: mt6765 upstream driver Chun-Hung Wu
2019-05-16  8:10   ` Chun-Hung Wu
2019-05-16  8:10   ` Chun-Hung Wu
2019-05-18 10:33   ` Jonathan Cameron
2019-05-18 10:33     ` Jonathan Cameron
2019-05-18 10:33     ` Jonathan Cameron
2019-05-16  8:10 ` [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support Chun-Hung Wu
2019-05-16  8:10   ` Chun-Hung Wu
2019-05-16  8:10   ` Chun-Hung Wu
2019-05-18 10:35   ` Jonathan Cameron
2019-05-18 10:35     ` Jonathan Cameron
2019-05-18 10:35     ` Jonathan Cameron
2019-05-20  6:03     ` Chun-Hung Wu
2019-05-20  6:03       ` Chun-Hung Wu
2019-05-20  6:03       ` Chun-Hung Wu
2019-05-22 16:28       ` Matthias Brugger
2019-05-22 16:28         ` Matthias Brugger
2019-05-28 10:59         ` Chun-Hung Wu
2019-05-28 10:59           ` Chun-Hung Wu
2019-05-28 10:59           ` Chun-Hung Wu
2019-06-06 15:46           ` Jonathan Cameron
2019-06-06 15:46             ` Jonathan Cameron
2019-06-06 15:46             ` Jonathan Cameron
2019-05-16  8:10 ` Chun-Hung Wu [this message]
2019-05-16  8:10   ` [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall Chun-Hung Wu
2019-05-16  8:10   ` Chun-Hung Wu
2019-05-18 10:36   ` Jonathan Cameron
2019-05-18 10:36     ` Jonathan Cameron
2019-05-18 10:36     ` Jonathan Cameron
2019-05-20  6:06     ` Chun-Hung Wu
2019-05-20  6:06       ` Chun-Hung Wu
2019-05-20  6:06       ` Chun-Hung Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1557994247-16739-5-git-send-email-chun-hung.wu@mediatek.com \
    --to=chun-hung.wu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jg_poxu@mediatek.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=kuohong.wang@mediatek.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=peter.wang@mediatek.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.