From: Nguyen An Hoan <na-hoan@jinso.co.jp>
To: linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be,
linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
linux@roeck-us.net, wsa+renesas@sang-engineering.com
Cc: kuninori.morimoto.gx@renesas.com,
yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp,
cv-dong@jinso.co.jp
Subject: [PATCH] watchdog: renesas_wdt: Fix interrupt enable for timer
Date: Thu, 23 May 2019 18:29:37 +0900 [thread overview]
Message-ID: <1558603778-20848-1-git-send-email-na-hoan@jinso.co.jp> (raw)
From: Hoan Nguyen An <na-hoan@jinso.co.jp>
Fix setting for bit WOVFE of RWTCSRA. Keep it enable follow hardware document.
Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>
---
drivers/watchdog/renesas_wdt.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
index 565dbc1..a6aca0e 100644
--- a/drivers/watchdog/renesas_wdt.c
+++ b/drivers/watchdog/renesas_wdt.c
@@ -19,6 +19,7 @@
#define RWTCNT 0
#define RWTCSRA 4
+#define RWTCSRA_WOVFE BIT(3)
#define RWTCSRA_WOVF BIT(4)
#define RWTCSRA_WRFLG BIT(5)
#define RWTCSRA_TME BIT(7)
@@ -82,13 +83,14 @@ static int rwdt_start(struct watchdog_device *wdev)
rwdt_write(priv, val, RWTCSRA);
rwdt_init_timeout(wdev);
- rwdt_write(priv, priv->cks, RWTCSRA);
+ val |= priv->cks;
+ rwdt_write(priv, val, RWTCSRA);
rwdt_write(priv, 0, RWTCSRB);
while (readb_relaxed(priv->base + RWTCSRA) & RWTCSRA_WRFLG)
cpu_relax();
-
- rwdt_write(priv, priv->cks | RWTCSRA_TME, RWTCSRA);
+ /* Enable interrupt and timer */
+ rwdt_write(priv, val | RWTCSRA_WOVFE | RWTCSRA_TME, RWTCSRA);
return 0;
}
--
2.7.4
next reply other threads:[~2019-05-23 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:29 Nguyen An Hoan [this message]
2019-05-23 9:29 ` [PATCH] watchdog: renesas_wdt: Use 'dev' instead of dereferencing it repeatedly Nguyen An Hoan
2019-05-23 11:06 ` Wolfram Sang
2019-05-27 16:22 ` Guenter Roeck
2019-05-28 7:38 ` Geert Uytterhoeven
2019-06-07 17:31 ` Guenter Roeck
2019-06-13 9:28 ` Simon Horman
2019-05-23 11:04 ` [PATCH] watchdog: renesas_wdt: Fix interrupt enable for timer Wolfram Sang
2019-05-23 11:26 ` Geert Uytterhoeven
2019-05-24 1:13 ` "グェン・アン・ホァン"
2019-05-24 2:01 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558603778-20848-1-git-send-email-na-hoan@jinso.co.jp \
--to=na-hoan@jinso.co.jp \
--cc=cv-dong@jinso.co.jp \
--cc=geert+renesas@glider.be \
--cc=h-inayoshi@jinso.co.jp \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.