From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca,
viro@zeniv.linux.org.uk, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, jk@ozlabs.org
Cc: reiserfs-devel@vger.kernel.org, linux-efi@vger.kernel.org,
devel@lists.orangefs.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [PATCH v3 0/6] vfs: make immutable files actually immutable
Date: Mon, 10 Jun 2019 21:46:09 -0700 [thread overview]
Message-ID: <156022836912.3227213.13598042497272336695.stgit@magnolia> (raw)
Hi all,
The chattr(1) manpage has this to say about the immutable bit that
system administrators can set on files:
"A file with the 'i' attribute cannot be modified: it cannot be deleted
or renamed, no link can be created to this file, most of the file's
metadata can not be modified, and the file can not be opened in write
mode."
Given the clause about how the file 'cannot be modified', it is
surprising that programs holding writable file descriptors can continue
to write to and truncate files after the immutable flag has been set,
but they cannot call other things such as utimes, fallocate, unlink,
link, setxattr, or reflink.
Since the immutable flag is only settable by administrators, resolve
this inconsistent behavior in favor of the documented behavior -- once
the flag is set, the file cannot be modified, period. We presume that
administrators must be trusted to know what they're doing, and that
cutting off programs with writable fds will probably break them.
Therefore, add immutability checks to the relevant VFS functions, then
refactor the SETFLAGS and FSSETXATTR implementations to use common
argument checking functions so that we can then force pagefaults on all
the file data when setting immutability.
Note that various distro manpages points out the inconsistent behavior
of the various Linux filesystems w.r.t. immutable. This fixes all that.
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This has been lightly tested with fstests. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=immutable-files
fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=immutable-files
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca,
viro@zeniv.linux.org.uk, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, jk@ozlabs.org
Cc: reiserfs-devel@vger.kernel.org, linux-efi@vger.kernel.org,
devel@lists.orangefs.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH v3 0/6] vfs: make immutable files actually immutable
Date: Mon, 10 Jun 2019 21:46:09 -0700 [thread overview]
Message-ID: <156022836912.3227213.13598042497272336695.stgit@magnolia> (raw)
Hi all,
The chattr(1) manpage has this to say about the immutable bit that
system administrators can set on files:
"A file with the 'i' attribute cannot be modified: it cannot be deleted
or renamed, no link can be created to this file, most of the file's
metadata can not be modified, and the file can not be opened in write
mode."
Given the clause about how the file 'cannot be modified', it is
surprising that programs holding writable file descriptors can continue
to write to and truncate files after the immutable flag has been set,
but they cannot call other things such as utimes, fallocate, unlink,
link, setxattr, or reflink.
Since the immutable flag is only settable by administrators, resolve
this inconsistent behavior in favor of the documented behavior -- once
the flag is set, the file cannot be modified, period. We presume that
administrators must be trusted to know what they're doing, and that
cutting off programs with writable fds will probably break them.
Therefore, add immutability checks to the relevant VFS functions, then
refactor the SETFLAGS and FSSETXATTR implementations to use common
argument checking functions so that we can then force pagefaults on all
the file data when setting immutability.
Note that various distro manpages points out the inconsistent behavior
of the various Linux filesystems w.r.t. immutable. This fixes all that.
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This has been lightly tested with fstests. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=immutable-files
fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=immutable-files
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca,
viro@zeniv.linux.org.uk, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, jk@ozlabs.org
Cc: linux-efi@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, devel@lists.orangefs.org
Subject: [PATCH v3 0/6] vfs: make immutable files actually immutable
Date: Mon, 10 Jun 2019 21:46:09 -0700 [thread overview]
Message-ID: <156022836912.3227213.13598042497272336695.stgit@magnolia> (raw)
Hi all,
The chattr(1) manpage has this to say about the immutable bit that
system administrators can set on files:
"A file with the 'i' attribute cannot be modified: it cannot be deleted
or renamed, no link can be created to this file, most of the file's
metadata can not be modified, and the file can not be opened in write
mode."
Given the clause about how the file 'cannot be modified', it is
surprising that programs holding writable file descriptors can continue
to write to and truncate files after the immutable flag has been set,
but they cannot call other things such as utimes, fallocate, unlink,
link, setxattr, or reflink.
Since the immutable flag is only settable by administrators, resolve
this inconsistent behavior in favor of the documented behavior -- once
the flag is set, the file cannot be modified, period. We presume that
administrators must be trusted to know what they're doing, and that
cutting off programs with writable fds will probably break them.
Therefore, add immutability checks to the relevant VFS functions, then
refactor the SETFLAGS and FSSETXATTR implementations to use common
argument checking functions so that we can then force pagefaults on all
the file data when setting immutability.
Note that various distro manpages points out the inconsistent behavior
of the various Linux filesystems w.r.t. immutable. This fixes all that.
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This has been lightly tested with fstests. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=immutable-files
fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=immutable-files
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca,
viro@zeniv.linux.org.uk, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, jk@ozlabs.org
Cc: linux-efi@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, devel@lists.orangefs.org
Subject: [f2fs-dev] [PATCH v3 0/6] vfs: make immutable files actually immutable
Date: Mon, 10 Jun 2019 21:46:09 -0700 [thread overview]
Message-ID: <156022836912.3227213.13598042497272336695.stgit@magnolia> (raw)
Message-ID: <20190611044609.TfG_-c9bR8Vl-QLdthaZl75In43PERsVKA2IrIQ3hVQ@z> (raw)
Hi all,
The chattr(1) manpage has this to say about the immutable bit that
system administrators can set on files:
"A file with the 'i' attribute cannot be modified: it cannot be deleted
or renamed, no link can be created to this file, most of the file's
metadata can not be modified, and the file can not be opened in write
mode."
Given the clause about how the file 'cannot be modified', it is
surprising that programs holding writable file descriptors can continue
to write to and truncate files after the immutable flag has been set,
but they cannot call other things such as utimes, fallocate, unlink,
link, setxattr, or reflink.
Since the immutable flag is only settable by administrators, resolve
this inconsistent behavior in favor of the documented behavior -- once
the flag is set, the file cannot be modified, period. We presume that
administrators must be trusted to know what they're doing, and that
cutting off programs with writable fds will probably break them.
Therefore, add immutability checks to the relevant VFS functions, then
refactor the SETFLAGS and FSSETXATTR implementations to use common
argument checking functions so that we can then force pagefaults on all
the file data when setting immutability.
Note that various distro manpages points out the inconsistent behavior
of the various Linux filesystems w.r.t. immutable. This fixes all that.
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This has been lightly tested with fstests. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=immutable-files
fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=immutable-files
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
darrick.wong@oracle.com, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca,
viro@zeniv.linux.org.uk, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, jk@ozlabs.org
Cc: linux-efi@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, devel@lists.orangefs.org
Subject: [PATCH v3 0/6] vfs: make immutable files actually immutable
Date: Mon, 10 Jun 2019 21:46:09 -0700 [thread overview]
Message-ID: <156022836912.3227213.13598042497272336695.stgit@magnolia> (raw)
Hi all,
The chattr(1) manpage has this to say about the immutable bit that
system administrators can set on files:
"A file with the 'i' attribute cannot be modified: it cannot be deleted
or renamed, no link can be created to this file, most of the file's
metadata can not be modified, and the file can not be opened in write
mode."
Given the clause about how the file 'cannot be modified', it is
surprising that programs holding writable file descriptors can continue
to write to and truncate files after the immutable flag has been set,
but they cannot call other things such as utimes, fallocate, unlink,
link, setxattr, or reflink.
Since the immutable flag is only settable by administrators, resolve
this inconsistent behavior in favor of the documented behavior -- once
the flag is set, the file cannot be modified, period. We presume that
administrators must be trusted to know what they're doing, and that
cutting off programs with writable fds will probably break them.
Therefore, add immutability checks to the relevant VFS functions, then
refactor the SETFLAGS and FSSETXATTR implementations to use common
argument checking functions so that we can then force pagefaults on all
the file data when setting immutability.
Note that various distro manpages points out the inconsistent behavior
of the various Linux filesystems w.r.t. immutable. This fixes all that.
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This has been lightly tested with fstests. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=immutable-files
fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=immutable-files
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2019-06-11 4:47 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 4:46 Darrick J. Wong [this message]
2019-06-11 4:46 ` [PATCH v3 0/6] vfs: make immutable files actually immutable Darrick J. Wong
2019-06-11 4:46 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-11 4:46 ` [PATCH 1/6] mm/fs: don't allow writes to immutable files Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-20 21:52 ` Theodore Ts'o
2019-06-20 21:52 ` Theodore Ts'o
2019-06-20 21:52 ` [f2fs-dev] " Theodore Ts'o
2019-06-20 21:52 ` [Ocfs2-devel] " Theodore Ts'o
2019-06-20 22:13 ` Darrick J. Wong
2019-06-20 22:13 ` Darrick J. Wong
2019-06-20 22:13 ` [f2fs-dev] " Darrick J. Wong
2019-06-20 22:13 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-21 0:54 ` Theodore Ts'o
2019-06-21 0:54 ` Theodore Ts'o
2019-06-21 0:54 ` [f2fs-dev] " Theodore Ts'o
2019-06-21 0:54 ` [Ocfs2-devel] " Theodore Ts'o
2019-06-11 4:46 ` [PATCH 2/6] vfs: flush and wait for io when setting the immutable flag via SETFLAGS Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-20 14:00 ` Jan Kara
2019-06-20 14:00 ` Jan Kara
2019-06-20 14:00 ` [f2fs-dev] " Jan Kara
2019-06-20 14:00 ` [Ocfs2-devel] " Jan Kara
2019-06-20 22:09 ` Darrick J. Wong
2019-06-20 22:09 ` Darrick J. Wong
2019-06-20 22:09 ` [f2fs-dev] " Darrick J. Wong
2019-06-20 22:09 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-11 4:46 ` [PATCH 3/6] vfs: flush and wait for io when setting the immutable flag via FSSETXATTR Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-11 4:46 ` [PATCH 4/6] vfs: don't allow most setxattr to immutable files Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-20 14:03 ` Jan Kara
2019-06-20 14:03 ` Jan Kara
2019-06-20 14:03 ` [f2fs-dev] " Jan Kara
2019-06-20 14:03 ` [Ocfs2-devel] " Jan Kara
2019-06-20 21:36 ` Darrick J. Wong
2019-06-20 21:36 ` Darrick J. Wong
2019-06-20 21:36 ` Darrick J. Wong
2019-06-20 21:36 ` [f2fs-dev] " Darrick J. Wong
2019-06-20 21:36 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-11 4:46 ` [PATCH 5/6] xfs: refactor setflags to use setattr code directly Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-11 4:47 ` [PATCH 6/6] xfs: clean up xfs_merge_ioc_xflags Darrick J. Wong
2019-06-11 4:47 ` Darrick J. Wong
2019-06-11 4:47 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:47 ` Darrick J. Wong
2019-06-11 4:47 ` [Ocfs2-devel] " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156022836912.3227213.13598042497272336695.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=ard.biesheuvel@linaro.org \
--cc=clm@fb.com \
--cc=devel@lists.orangefs.org \
--cc=dsterba@suse.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jk@ozlabs.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.