All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Guenter Roeck <linux@roeck-us.net>,
	David Sterba <dsterba@suse.com>
Subject: [PATCH -next] btrfs: Select LIBCRC32C again
Date: Mon,  8 Jul 2019 06:43:23 -0700	[thread overview]
Message-ID: <1562593403-19545-1-git-send-email-linux@roeck-us.net> (raw)

With CONFIG_BTRFS_FS=y and CONFIG_CRYPTO_CRC32C=m, we get:

fs/btrfs/super.o: In function `btrfs_mount_root':
fs/btrfs/super.c:1557: undefined reference to `crc32c_impl'
fs/btrfs/super.o: In function `btrfs_print_mod_info':
fs/btrfs/super.c:2348: undefined reference to `crc32c_impl'
fs/btrfs/extent-tree.o: In function `btrfs_crc32c':
fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
fs/btrfs/dir-item.o: In function `btrfs_name_hash':
fs/btrfs/ctree.h:2619: undefined reference to `crc32c'
fs/btrfs/ctree.h:2619: undefined reference to `crc32c'

and more.

Note that the comment in the offending commit "The module dependency on
crc32c is preserved via MODULE_SOFTDEP("pre: crc32c"), which was previously
provided by LIBCRC32C config option doing the same." is wrong, since it
permits CONFIG_BTRFS_FS=y in combination with CONFIG_CRYPTO_CRC32C=m.

Cc: David Sterba <dsterba@suse.com>
Fixes: d5178578bcd4 ("btrfs: directly call into crypto framework for checksumming")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 fs/btrfs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 212b4a854f2c..4c80c70597f9 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -2,6 +2,7 @@
 
 config BTRFS_FS
 	tristate "Btrfs filesystem support"
+	select LIBCRC32C
 	select CRYPTO
 	select CRYPTO_CRC32C
 	select ZLIB_INFLATE
-- 
2.7.4


             reply	other threads:[~2019-07-08 13:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 13:43 Guenter Roeck [this message]
2019-07-09 16:10 ` [PATCH -next] btrfs: Select LIBCRC32C again Guenter Roeck
2019-07-17 14:10 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1562593403-19545-1-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.