All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Chen <vincent.chen@sifive.com>
To: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@sifive.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Vincent Chen <vincent.chen@sifive.com>,
	linux-stable <stable@vger.kernel.org>
Subject: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.
Date: Wed, 14 Aug 2019 16:23:53 +0800	[thread overview]
Message-ID: <1565771033-1831-3-git-send-email-vincent.chen@sifive.com> (raw)
In-Reply-To: <1565771033-1831-1-git-send-email-vincent.chen@sifive.com>

Make the __fstate_clean() function correctly set the
state of sstatus.FS in pt_regs to SR_FS_CLEAN.

Fixes: 7db91e5 ("RISC-V: Task implementation")
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>

---
 arch/riscv/include/asm/switch_to.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/include/asm/switch_to.h b/arch/riscv/include/asm/switch_to.h
index 0575b8a..0aa5b94 100644
--- a/arch/riscv/include/asm/switch_to.h
+++ b/arch/riscv/include/asm/switch_to.h
@@ -16,7 +16,7 @@ extern void __fstate_restore(struct task_struct *restore_from);
 
 static inline void __fstate_clean(struct pt_regs *regs)
 {
-	regs->sstatus |= (regs->sstatus & ~(SR_FS)) | SR_FS_CLEAN;
+	regs->sstatus = (regs->sstatus & ~SR_FS) | SR_FS_CLEAN;
 }
 
 static inline void fstate_off(struct task_struct *task,
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Vincent Chen <vincent.chen@sifive.com>
To: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@sifive.com>
Cc: Vincent Chen <vincent.chen@sifive.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-stable <stable@vger.kernel.org>
Subject: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.
Date: Wed, 14 Aug 2019 16:23:53 +0800	[thread overview]
Message-ID: <1565771033-1831-3-git-send-email-vincent.chen@sifive.com> (raw)
In-Reply-To: <1565771033-1831-1-git-send-email-vincent.chen@sifive.com>

Make the __fstate_clean() function correctly set the
state of sstatus.FS in pt_regs to SR_FS_CLEAN.

Fixes: 7db91e5 ("RISC-V: Task implementation")
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>

---
 arch/riscv/include/asm/switch_to.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/include/asm/switch_to.h b/arch/riscv/include/asm/switch_to.h
index 0575b8a..0aa5b94 100644
--- a/arch/riscv/include/asm/switch_to.h
+++ b/arch/riscv/include/asm/switch_to.h
@@ -16,7 +16,7 @@ extern void __fstate_restore(struct task_struct *restore_from);
 
 static inline void __fstate_clean(struct pt_regs *regs)
 {
-	regs->sstatus |= (regs->sstatus & ~(SR_FS)) | SR_FS_CLEAN;
+	regs->sstatus = (regs->sstatus & ~SR_FS) | SR_FS_CLEAN;
 }
 
 static inline void fstate_off(struct task_struct *task,
-- 
2.7.4


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2019-08-14  8:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14  8:23 [PATCH v2 0/2] riscv: Correct the initialized flow of FP and __fstate_clean() Vincent Chen
2019-08-14  8:23 ` Vincent Chen
2019-08-14  8:23 ` [PATCH v2 1/2] riscv: Correct the initialized flow of FP register Vincent Chen
2019-08-14  8:23   ` Vincent Chen
2019-08-14 20:24   ` Paul Walmsley
2019-08-14 20:24     ` Paul Walmsley
2019-08-14  8:23 ` Vincent Chen [this message]
2019-08-14  8:23   ` [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly Vincent Chen
2019-08-14 20:32   ` Paul Walmsley
2019-08-14 20:32     ` Paul Walmsley
2019-08-14 21:29     ` Palmer Dabbelt
2019-08-14 21:29       ` Palmer Dabbelt
2019-08-14 22:17       ` Andreas Schwab
2019-08-14 22:17         ` Andreas Schwab
2019-08-15  1:53         ` Palmer Dabbelt
2019-08-15  1:53           ` Palmer Dabbelt
2019-08-15  2:53         ` Vincent Chen
2019-08-15  2:53           ` Vincent Chen
2019-09-11  7:22         ` Geert Uytterhoeven
2019-09-11  7:22           ` Geert Uytterhoeven
2019-09-11  7:31           ` Andreas Schwab
2019-09-11  7:31             ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1565771033-1831-3-git-send-email-vincent.chen@sifive.com \
    --to=vincent.chen@sifive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.