All of lore.kernel.org
 help / color / mirror / Atom feed
From: biju.das@bp.renesas.com (Biju Das)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [PATCH 4.19.y-cip 12/22] thermal: rcar_gen3_thermal: Fix init value of IRQCTL register
Date: Mon,  2 Sep 2019 16:57:46 +0100	[thread overview]
Message-ID: <1567439876-1886-13-git-send-email-biju.das@bp.renesas.com> (raw)
In-Reply-To: <1567439876-1886-1-git-send-email-biju.das@bp.renesas.com>

From: Hoan Nguyen An <na-hoan@jinso.co.jp>

commit ed1b1ac1425b3d4399553411f305ce12fb3a6c54 upstream.

Fix setting value for IRQCTL register. We are setting the last 6 bits
of (IRQCTL) to be 1 (0x3f), this is only suitable for H3ES1.*, according
to Hardware manual values 1 are "setting prohibited" for Gen3.

Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 drivers/thermal/rcar_gen3_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
index 40a442e..7bbfde4 100644
--- a/drivers/thermal/rcar_gen3_thermal.c
+++ b/drivers/thermal/rcar_gen3_thermal.c
@@ -307,7 +307,7 @@ static void rcar_gen3_thermal_init(struct rcar_gen3_thermal_tsc *tsc)
 
 	usleep_range(1000, 2000);
 
-	rcar_gen3_thermal_write(tsc, REG_GEN3_IRQCTL, 0x3F);
+	rcar_gen3_thermal_write(tsc, REG_GEN3_IRQCTL, 0);
 	rcar_gen3_thermal_write(tsc, REG_GEN3_IRQMSK, 0);
 	rcar_gen3_thermal_write(tsc, REG_GEN3_IRQEN, IRQ_TEMPD1 | IRQ_TEMP2);
 
-- 
2.7.4

  parent reply	other threads:[~2019-09-02 15:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 15:57 [cip-dev] [PATCH 4.19.y-cip 00/22] Add Watchdog/CMT/TMU/Thermal support Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 01/22] watchdog: renesas_wdt: stop when unregistering Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 02/22] watchdog: renesas_wdt: Fix typos Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 03/22] watchdog: renesas_wdt: don't keep timer value during suspend/resume Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 04/22] watchdog: renesas_wdt: drop superfluous glob pattern Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 05/22] watchdog: renesas_wdt: Use 'dev' instead of dereferencing it repeatedly Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 06/22] watchdog: renesas_wdt: Add a few cycles delay Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 07/22] arm64: dts: renesas: hihope-common: Add RWDT support Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 08/22] arm64: dts: renesas: r8a774a1: Add CMT device nodes Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 09/22] clk: renesas: r8a774a1: Add TMU clock Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 10/22] arm64: dts: renesas: r8a774a1: Add TMU device nodes Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 11/22] thermal: rcar_gen3_thermal: Register hwmon sysfs interface Biju Das
2019-09-02 15:57 ` Biju Das [this message]
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 13/22] thermal: rcar_gen3_thermal: fix interrupt type Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 14/22] thermal: rcar_gen3_thermal: Fix to show correct trip points number Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 15/22] thermal: rcar_gen3_thermal: Update value of Tj_1 Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 16/22] thermal: rcar_gen3_thermal: Update calculation formula of IRQTEMP Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 17/22] thermal: rcar_gen3_thermal: Update temperature conversion method Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 18/22] arm64: dts: renesas: r8a774a1: Add operating points Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 19/22] arm64: dts: renesas: r8a774a1: Add CPU topology on r8a774a1 SoC Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 20/22] arm64: dts: renesas: r8a774a1: Add CPU capacity-dmips-mhz Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 21/22] arm64: dts: renesas: r8a774a1: Create thermal zone to support IPA Biju Das
2019-09-02 15:57 ` [cip-dev] [PATCH 4.19.y-cip 22/22] arm64: dts: renesas: r8a774a1: Add dynamic power coefficient Biju Das
2019-09-05  9:39 ` [cip-dev] [PATCH 4.19.y-cip 00/22] Add Watchdog/CMT/TMU/Thermal support nobuhiro1.iwamatsu at toshiba.co.jp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1567439876-1886-13-git-send-email-biju.das@bp.renesas.com \
    --to=biju.das@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.