All of lore.kernel.org
 help / color / mirror / Atom feed
From: fabrizio.castro@bp.renesas.com (Fabrizio Castro)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [PATCH 4.19.y-cip v2 18/32] drm: rcar-du: Rename and document dpll_ch field
Date: Tue, 17 Sep 2019 14:07:46 +0100	[thread overview]
Message-ID: <1568725680-32730-19-git-send-email-fabrizio.castro@bp.renesas.com> (raw)
In-Reply-To: <1568725680-32730-1-git-send-email-fabrizio.castro@bp.renesas.com>

From: Jacopo Mondi <jacopo+renesas@jmondi.org>

commit 9fe50e64fac7a7301f82e31dbd87a4145384005e upstream.

Document and re-name the 'dpll_ch' field to a more precise 'dpll_mask' for
consistency with the 'channels_mask' field defined in 'struct
rcar_du_device_info'.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +-
 drivers/gpu/drm/rcar-du/rcar_du_drv.c  | 6 +++---
 drivers/gpu/drm/rcar-du/rcar_du_drv.h  | 3 ++-
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index 342519c..107cbf2 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -210,7 +210,7 @@ static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
 	u32 dsmr;
 	u32 escr;
 
-	if (rcdu->info->dpll_ch & (1 << rcrtc->index)) {
+	if (rcdu->info->dpll_mask & (1 << rcrtc->index)) {
 		unsigned long target = mode_clock;
 		struct dpll_info dpll = { 0 };
 		unsigned long extclk;
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index ba360e4..5380f0e 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -259,7 +259,7 @@ static const struct rcar_du_device_info rcar_du_r8a7795_info = {
 		},
 	},
 	.num_lvds = 1,
-	.dpll_ch =  BIT(2) | BIT(1),
+	.dpll_mask =  BIT(2) | BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a7796_info = {
@@ -289,7 +289,7 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = {
 		},
 	},
 	.num_lvds = 1,
-	.dpll_ch =  BIT(1),
+	.dpll_mask =  BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a77965_info = {
@@ -319,7 +319,7 @@ static const struct rcar_du_device_info rcar_du_r8a77965_info = {
 		},
 	},
 	.num_lvds = 1,
-	.dpll_ch =  BIT(1),
+	.dpll_mask =  BIT(1),
 };
 
 static const struct rcar_du_device_info rcar_du_r8a77970_info = {
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h b/drivers/gpu/drm/rcar-du/rcar_du_drv.h
index 970c077..a6e6316 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h
@@ -57,6 +57,7 @@ struct rcar_du_output_routing {
  * @channels_mask: bit mask of available DU channels
  * @routes: array of CRTC to output routes, indexed by output (RCAR_DU_OUTPUT_*)
  * @num_lvds: number of internal LVDS encoders
+ * @dpll_mask: bit mask of DU channels equipped with a DPLL
  */
 struct rcar_du_device_info {
 	unsigned int gen;
@@ -65,7 +66,7 @@ struct rcar_du_device_info {
 	unsigned int channels_mask;
 	struct rcar_du_output_routing routes[RCAR_DU_OUTPUT_MAX];
 	unsigned int num_lvds;
-	unsigned int dpll_ch;
+	unsigned int dpll_mask;
 };
 
 #define RCAR_DU_MAX_CRTCS		4
-- 
2.7.4

  parent reply	other threads:[~2019-09-17 13:07 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 13:07 [cip-dev] [PATCH 4.19.y-cip v2 00/32] Add PCIe and HDMI support to HiHope RZ/G2M Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 01/32] dt-bindings: PCI: rcar: Add device tree support for r8a774a1 Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 02/32] dt-bindings: display: renesas: du: Document the r8a774a1 bindings Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 03/32] dt-bindings: display: renesas: lvds: Document " Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 04/32] dt-bindings: display: renesas: Add r8a774a1 support Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 05/32] PCI: rcar: Replace unsigned long with u32/unsigned int in register accessors Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 06/32] PCI: rcar: Replace various variable types with unsigned ones for register values Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 07/32] PCI: rcar: Clean up debug messages Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 08/32] PCI: rcar: Do not shadow the 'irq' variable Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 09/32] drm: rcar-du: Add R8A774A1 support Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 10/32] drm: rcar-du: lvds: Add r8a774a1 support Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 11/32] drm: rcar-du: dw-hdmi: Reject modes with a too high clock frequency Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 12/32] drm: rcar-du: Refactor Feature and Quirk definitions Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 13/32] drm: rcar-du: Add interlaced feature flag Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 14/32] drm: rcar-du: Cache DSYSR value to ensure known initial value Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 15/32] drm: rcar-du: Don't use TV sync mode when not supported by the hardware Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 16/32] drm: rcar-du: Support interlaced video output through vsp1 Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 17/32] drm: rcar-du: Rework clock configuration based on hardware limits Fabrizio Castro
2019-09-17 13:07 ` Fabrizio Castro [this message]
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 19/32] drm: rcar-du: Add support for missing pixel formats Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 20/32] drm: rcar-du: Store V4L2 fourcc in rcar_du_format_info structure Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 21/32] drm: rcar-du: Update framebuffer pitch and alignment limits for Gen3 Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 22/32] arm64: dts: renesas: r8a774a1: Add PCIe device nodes Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 23/32] arm64: dts: renesas: hihope-common: Declare pcie bus clock Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 24/32] arm64: dts: renesas: hihope-rzg2-ex: Enable PCIe support Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 25/32] arm64: dts: renesas: r8a774a1: Add VSP instances Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 26/32] arm64: dts: renesas: r8a774a1: Add DU device to DT Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 27/32] arm64: dts: renesas: r8a774a1: Add FDP1 instance Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 28/32] arm64: dts: renesas: r8a774a1: Tie SYS-DMAC to IPMMU-DS0/1 Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 29/32] arm64: dts: renesas: r8a774a1: Tie Audio-DMAC to IPMMU-MP Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 30/32] arm64: dts: renesas: r8a774a1: Connect Ethernet-AVB to IPMMU-DS0 Fabrizio Castro
2019-09-17 13:07 ` [cip-dev] [PATCH 4.19.y-cip v2 31/32] arm64: dts: renesas: r8a774a1: Add HDMI encoder instance Fabrizio Castro
2019-09-17 13:08 ` [cip-dev] [PATCH 4.19.y-cip v2 32/32] arm64: dts: renesas: hihope-common: Add HDMI support Fabrizio Castro
2019-09-17 13:57 ` [cip-dev] [PATCH 4.19.y-cip v2 00/32] Add PCIe and HDMI support to HiHope RZ/G2M nobuhiro1.iwamatsu at toshiba.co.jp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1568725680-32730-19-git-send-email-fabrizio.castro@bp.renesas.com \
    --to=fabrizio.castro@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.