All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: linux-xfs <linux-xfs@vger.kernel.org>
Cc: Brian Foster <bfoster@redhat.com>,
	Eric Sandeen <sandeen@sandeen.net>,
	David Howells <dhowells@redhat.com>,
	Dave Chinner <dchinner@redhat.com>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: [PATCH v6 01/12] vfs: add missing blkdev_put() in get_tree_bdev()
Date: Wed, 16 Oct 2019 08:40:47 +0800	[thread overview]
Message-ID: <157118644757.9678.8135598206478346052.stgit@fedora-28> (raw)
In-Reply-To: <157118625324.9678.16275725173770634823.stgit@fedora-28>

There appear to be a couple of missing blkdev_put() in get_tree_bdev().
This change has been sent to Linus and has been included in the current
rc kernel but is not present in the xfs-linux tree.
---
 fs/super.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/super.c b/fs/super.c
index f627b7c53d2b..cfadab2cbf35 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1300,6 +1300,7 @@ int get_tree_bdev(struct fs_context *fc,
 	mutex_lock(&bdev->bd_fsfreeze_mutex);
 	if (bdev->bd_fsfreeze_count > 0) {
 		mutex_unlock(&bdev->bd_fsfreeze_mutex);
+		blkdev_put(bdev, mode);
 		warnf(fc, "%pg: Can't mount, blockdev is frozen", bdev);
 		return -EBUSY;
 	}
@@ -1308,8 +1309,10 @@ int get_tree_bdev(struct fs_context *fc,
 	fc->sget_key = bdev;
 	s = sget_fc(fc, test_bdev_super_fc, set_bdev_super_fc);
 	mutex_unlock(&bdev->bd_fsfreeze_mutex);
-	if (IS_ERR(s))
+	if (IS_ERR(s)) {
+		blkdev_put(bdev, mode);
 		return PTR_ERR(s);
+	}
 
 	if (s->s_root) {
 		/* Don't summarily change the RO/RW state. */


  reply	other threads:[~2019-10-16  0:41 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16  0:40 [PATCH v6 00/12] xfs: mount API patch series Ian Kent
2019-10-16  0:40 ` Ian Kent [this message]
2019-10-16  0:40 ` [PATCH v6 02/12] xfs: remove very old mount option Ian Kent
2019-10-16  8:26   ` Christoph Hellwig
2019-10-16 18:25   ` Darrick J. Wong
2019-10-16  0:40 ` [PATCH v6 03/12] xfs: remove unused mount info field m_fsname_len Ian Kent
2019-10-16  8:26   ` Christoph Hellwig
2019-10-16 18:26   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 04/12] xfs: use super s_id instead of mount info m_fsname Ian Kent
2019-10-16  8:27   ` Christoph Hellwig
2019-10-16 18:27   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 05/12] xfs: dont use XFS_IS_QUOTA_RUNNING() for option check Ian Kent
2019-10-16  8:28   ` Christoph Hellwig
2019-10-16 18:28   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 06/12] xfs: add xfs_remount_rw() helper Ian Kent
2019-10-16  8:30   ` Christoph Hellwig
2019-10-16 18:29   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 07/12] xfs: add xfs_remount_ro() helper Ian Kent
2019-10-16  8:31   ` Christoph Hellwig
2019-10-16 18:29   ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 08/12] xfs: refactor suffix_kstrtoint() Ian Kent
2019-10-16  8:34   ` Christoph Hellwig
2019-10-16 15:37     ` Darrick J. Wong
2019-10-16  0:41 ` [PATCH v6 09/12] xfs: refactor xfs_parseags() Ian Kent
2019-10-16  8:36   ` Christoph Hellwig
2019-10-16  0:41 ` [PATCH v6 10/12] xfs: move xfs_parseargs() validation to a helper Ian Kent
2019-10-16  8:40   ` Christoph Hellwig
2019-10-17  0:58     ` Ian Kent
2019-10-17  6:48       ` Christoph Hellwig
2019-10-23  2:59     ` Ian Kent
2019-10-16  0:41 ` [PATCH v6 11/12] xfs: dont set sb in xfs_mount_alloc() Ian Kent
2019-10-16  8:36   ` Christoph Hellwig
2019-10-16  0:41 ` [PATCH v6 12/12] xfs: switch to use the new mount-api Ian Kent
2019-10-16 18:18   ` Christoph Hellwig
2019-10-17  1:13     ` Ian Kent
2019-10-17  4:53       ` Darrick J. Wong
2019-10-17  6:51         ` Christoph Hellwig
2019-10-18  0:38           ` Ian Kent
2019-10-23  3:17     ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157118644757.9678.8135598206478346052.stgit@fedora-28 \
    --to=raven@themaw.net \
    --cc=bfoster@redhat.com \
    --cc=dchinner@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.