From: Can Guo <cang@qti.qualcomm.com>
To: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com, cang@codeaurora.org
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Subhash Jadavani <subhashj@codeaurora.org>,
Tomas Winkler <tomas.winkler@intel.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 3/5] scsi: ufs: Release clock if DMA map fails
Date: Fri, 1 Nov 2019 18:20:28 -0700 [thread overview]
Message-ID: <1572657631-25749-4-git-send-email-cang@qti.qualcomm.com> (raw)
In-Reply-To: <1572657631-25749-1-git-send-email-cang@qti.qualcomm.com>
From: Can Guo <cang@codeaurora.org>
In queuecommand path, if DMA map fails, it bails out with clock held.
In this case, release the clock to keep its usage paired.
Signed-off-by: Can Guo <cang@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 0a6b8f9..979b161 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -2504,6 +2504,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
if (err) {
lrbp->cmd = NULL;
clear_bit_unlock(tag, &hba->lrb_in_use);
+ ufshcd_release(hba);
goto out;
}
/* Make sure descriptors are ready before ringing the doorbell */
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-11-02 1:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 1:20 [PATCH v3 0/5] UFS driver general fixes bundle 1 Can Guo
2019-11-02 1:20 ` [PATCH v3 1/5] scsi: Adjust DBD setting in mode sense for caching mode page per LLD Can Guo
2019-11-02 1:20 ` [PATCH v3 2/5] scsi: ufs: Set DBD setting in mode sense for caching mode page Can Guo
2019-11-02 1:20 ` Can Guo [this message]
2019-11-02 1:20 ` [PATCH v3 4/5] scsi: ufs: Do not clear the DL layer timers Can Guo
2019-11-02 1:20 ` [PATCH v3 5/5] scsi: ufs: Do not free irq in suspend Can Guo
2019-11-02 5:01 [PATCH v3 0/5] UFS driver general fixes bundle 1 Can Guo
2019-11-02 5:01 ` [PATCH v3 3/5] scsi: ufs: Release clock if DMA map fails Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572657631-25749-4-git-send-email-cang@qti.qualcomm.com \
--to=cang@qti.qualcomm.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=subhashj@codeaurora.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.