From: Peng Fan <peng.fan@nxp.com> To: "sboyd@kernel.org" <sboyd@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, Abel Vesa <abel.vesa@nxp.com> Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Leonard Crestez <leonard.crestez@nxp.com>, Alice Guo <alice.guo@nxp.com>, Peng Fan <peng.fan@nxp.com>, Will Deacon <will@kernel.org> Subject: [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed Date: Wed, 13 Nov 2019 07:24:48 +0000 [thread overview] Message-ID: <1573629763-18389-2-git-send-email-peng.fan@nxp.com> (raw) In-Reply-To: <1573629763-18389-1-git-send-email-peng.fan@nxp.com> From: Peng Fan <peng.fan@nxp.com> It not make sense to use writel, use relaxed variant. Cc: Will Deacon <will@kernel.org> Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/clk/imx/clk-pll14xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index 5682fce9f5e5..e34813904023 100644 --- a/drivers/clk/imx/clk-pll14xx.c +++ b/drivers/clk/imx/clk-pll14xx.c @@ -199,7 +199,7 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate, /* Enable BYPASS */ tmp |= BYPASS_MASK; - writel(tmp, pll->base); + writel_relaxed(tmp, pll->base); div_val = (rate->mdiv << MDIV_SHIFT) | (rate->pdiv << PDIV_SHIFT) | (rate->sdiv << SDIV_SHIFT); -- 2.16.4
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com> To: "sboyd@kernel.org" <sboyd@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, Abel Vesa <abel.vesa@nxp.com> Cc: Aisheng Dong <aisheng.dong@nxp.com>, Peng Fan <peng.fan@nxp.com>, Alice Guo <alice.guo@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Leonard Crestez <leonard.crestez@nxp.com>, Will Deacon <will@kernel.org>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed Date: Wed, 13 Nov 2019 07:24:48 +0000 [thread overview] Message-ID: <1573629763-18389-2-git-send-email-peng.fan@nxp.com> (raw) In-Reply-To: <1573629763-18389-1-git-send-email-peng.fan@nxp.com> From: Peng Fan <peng.fan@nxp.com> It not make sense to use writel, use relaxed variant. Cc: Will Deacon <will@kernel.org> Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/clk/imx/clk-pll14xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index 5682fce9f5e5..e34813904023 100644 --- a/drivers/clk/imx/clk-pll14xx.c +++ b/drivers/clk/imx/clk-pll14xx.c @@ -199,7 +199,7 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate, /* Enable BYPASS */ tmp |= BYPASS_MASK; - writel(tmp, pll->base); + writel_relaxed(tmp, pll->base); div_val = (rate->mdiv << MDIV_SHIFT) | (rate->pdiv << PDIV_SHIFT) | (rate->sdiv << SDIV_SHIFT); -- 2.16.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-13 7:24 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-13 7:24 [PATCH 0/2] clk: imx: pll14xx: io relaxed fix Peng Fan 2019-11-13 7:24 ` Peng Fan 2019-11-13 7:24 ` Peng Fan [this message] 2019-11-13 7:24 ` [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed Peng Fan 2019-11-13 11:10 ` Daniel Baluta 2019-11-13 11:10 ` Daniel Baluta 2019-11-13 12:15 ` Peng Fan 2019-11-13 12:15 ` Peng Fan 2019-11-13 12:35 ` Daniel Baluta 2019-11-13 12:35 ` Daniel Baluta 2019-11-13 7:24 ` [PATCH 2/2] clk: imx: pll14xx: use readl to force write completed Peng Fan 2019-11-13 7:24 ` Peng Fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1573629763-18389-2-git-send-email-peng.fan@nxp.com \ --to=peng.fan@nxp.com \ --cc=abel.vesa@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=alice.guo@nxp.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.