From: Oliver Neukum <oneukum@suse.com>
To: syzbot <syzbot+b6c55daa701fc389e286@syzkaller.appspotmail.com>,
andreyknvl@google.com, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: WARNING: ODEBUG bug in input_ff_destroy
Date: Thu, 14 Nov 2019 11:08:41 +0100 [thread overview]
Message-ID: <1573726121.17351.3.camel@suse.com> (raw)
In-Reply-To: <0000000000005ee2a10597399876@google.com>
Am Mittwoch, den 13.11.2019, 04:35 -0800 schrieb syzbot:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: 3183c037 usb: gadget: add raw-gadget interface
> git tree: https://github.com/google/kasan.git usb-fuzzer
> console output: https://syzkaller.appspot.com/x/log.txt?x=17cf5e72e00000
> kernel config: https://syzkaller.appspot.com/x/.config?x=79de80330003b5f7
> dashboard link: https://syzkaller.appspot.com/bug?extid=b6c55daa701fc389e286
> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10b4e53ae00000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1173fe72e00000
>
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+b6c55daa701fc389e286@syzkaller.appspotmail.com
#syz test: https://github.com/google/kasan.git 3183c037
asix: fix information leak on short answersFrom b72ba3305d1e0405bfff5b6fc936d3769cd46c42 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Thu, 14 Nov 2019 11:03:45 +0100
Subject: [PATCH] ff-memless: kill timer in destroy()
No timer must be left running when the device goes away.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/input/ff-memless.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/ff-memless.c b/drivers/input/ff-memless.c
index 1cb40c7475af..e72543d831cd 100644
--- a/drivers/input/ff-memless.c
+++ b/drivers/input/ff-memless.c
@@ -489,6 +489,7 @@ static void ml_ff_destroy(struct ff_device *ff)
{
struct ml_device *ml = ff->private;
+ del_timer_sync(&ml->timer);
kfree(ml->private);
}
--
2.16.4
next prev parent reply other threads:[~2019-11-14 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 12:35 WARNING: ODEBUG bug in input_ff_destroy syzbot
2019-11-14 10:08 ` Oliver Neukum [this message]
2019-11-15 7:16 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573726121.17351.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=andreyknvl@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=syzbot+b6c55daa701fc389e286@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.