All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lina Iyer <ilina@codeaurora.org>
To: swboyd@chromium.org, maz@kernel.org, linus.walleij@linaro.org,
	bjorn.andersson@linaro.org
Cc: evgreen@chromium.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, mkshah@codeaurora.org,
	linux-gpio@vger.kernel.org, agross@kernel.org,
	dianders@chromium.org, Lina Iyer <ilina@codeaurora.org>
Subject: [PATCH v2 07/12] drivers: irqchip: pdc: Add irqchip set/get state calls
Date: Fri, 15 Nov 2019 15:11:50 -0700	[thread overview]
Message-ID: <1573855915-9841-8-git-send-email-ilina@codeaurora.org> (raw)
In-Reply-To: <1573855915-9841-1-git-send-email-ilina@codeaurora.org>

From: Maulik Shah <mkshah@codeaurora.org>

Add irqchip calls to set/get interrupt state from the parent interrupt
controller. When GPIOs are renabled as interrupt lines, it is desirable
to clear the interrupt state at the GIC. This avoids any unwanted
interrupt as a result of stale pending state recorded when the line was
used as a GPIO.

Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
[updated commit text, rearranged code]
Signed-off-by: Lina Iyer <ilina@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/irqchip/qcom-pdc.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
index 4f2c762..6ae9e1f 100644
--- a/drivers/irqchip/qcom-pdc.c
+++ b/drivers/irqchip/qcom-pdc.c
@@ -5,6 +5,7 @@
 
 #include <linux/err.h>
 #include <linux/init.h>
+#include <linux/interrupt.h>
 #include <linux/irq.h>
 #include <linux/irqchip.h>
 #include <linux/irqdomain.h>
@@ -50,6 +51,26 @@ static u32 pdc_reg_read(int reg, u32 i)
 	return readl_relaxed(pdc_base + reg + i * sizeof(u32));
 }
 
+static int qcom_pdc_gic_get_irqchip_state(struct irq_data *d,
+					  enum irqchip_irq_state which,
+					  bool *state)
+{
+	if (d->hwirq == GPIO_NO_WAKE_IRQ)
+		return 0;
+
+	return irq_chip_get_parent_state(d, which, state);
+}
+
+static int qcom_pdc_gic_set_irqchip_state(struct irq_data *d,
+					  enum irqchip_irq_state which,
+					  bool value)
+{
+	if (d->hwirq == GPIO_NO_WAKE_IRQ)
+		return 0;
+
+	return irq_chip_set_parent_state(d, which, value);
+}
+
 static void pdc_enable_intr(struct irq_data *d, bool on)
 {
 	int pin_out = d->hwirq;
@@ -178,6 +199,8 @@ static struct irq_chip qcom_pdc_gic_chip = {
 	.irq_unmask		= qcom_pdc_gic_unmask,
 	.irq_disable		= qcom_pdc_gic_disable,
 	.irq_enable		= qcom_pdc_gic_enable,
+	.irq_get_irqchip_state	= qcom_pdc_gic_get_irqchip_state,
+	.irq_set_irqchip_state	= qcom_pdc_gic_set_irqchip_state,
 	.irq_retrigger		= irq_chip_retrigger_hierarchy,
 	.irq_set_type		= qcom_pdc_gic_set_type,
 	.flags			= IRQCHIP_MASK_ON_SUSPEND |
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2019-11-15 22:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 22:11 [PATCH v2 00/12] Support wakeup capable GPIOs Lina Iyer
2019-11-15 22:11 ` [PATCH v2 01/12] irqdomain: add bus token DOMAIN_BUS_WAKEUP Lina Iyer
2019-11-20 13:21   ` [tip: irq/core] irqdomain: Add " tip-bot2 for Lina Iyer
2019-11-15 22:11 ` [PATCH v2 02/12] drivers: irqchip: qcom-pdc: update max PDC interrupts Lina Iyer
2019-11-20 13:21   ` [tip: irq/core] irqchip/qcom-pdc: Update " tip-bot2 for Lina Iyer
2019-11-15 22:11 ` [PATCH v2 03/12] drivers: irqchip: pdc: Do not toggle IRQ_ENABLE during mask/unmask Lina Iyer
2019-11-20 13:21   ` [tip: irq/core] irqchip/qcom-pdc: " tip-bot2 for Lina Iyer
2019-11-15 22:11 ` [PATCH v2 04/12] drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs Lina Iyer
2019-11-20 13:21   ` [tip: irq/core] irqchip/qcom-pdc: Add " tip-bot2 for Lina Iyer
2019-11-15 22:11 ` [PATCH v2 05/12] of: irq: document properties for wakeup interrupt parent Lina Iyer
2019-11-20 13:21   ` [tip: irq/core] of/irq: Document " tip-bot2 for Lina Iyer
2019-11-15 22:11 ` [PATCH v2 06/12] genirq: Introduce irq_chip_get/set_parent_state calls Lina Iyer
2019-11-20 13:21   ` [tip: irq/core] " tip-bot2 for Maulik Shah
2019-11-15 22:11 ` Lina Iyer [this message]
2019-11-20 13:21   ` [tip: irq/core] irqchip/qcom-pdc: Add irqchip set/get state calls tip-bot2 for Maulik Shah
2019-11-15 22:11 ` [PATCH v2 08/12] drivers: pinctrl: msm: setup GPIO chip in hierarchy Lina Iyer
2019-11-19 14:51   ` Linus Walleij
2019-11-20 13:21   ` [tip: irq/core] pinctrl/msm: Setup " tip-bot2 for Lina Iyer
2019-11-15 22:11 ` [PATCH v2 09/12] drivers: pinctrl: sdm845: add PDC wakeup interrupt map for GPIOs Lina Iyer
2019-11-20 13:20   ` [tip: irq/core] pinctrl/sdm845: Add " tip-bot2 for Lina Iyer
2019-11-15 22:11 ` [PATCH v2 10/12] arm64: dts: qcom: add PDC interrupt controller for SDM845 Lina Iyer
2019-11-15 22:11 ` [PATCH v2 11/12] arm64: dts: qcom: setup PDC as the wakeup parent for TLMM on SDM845 Lina Iyer
2019-11-15 22:11 ` [PATCH v2 12/12] arm64: defconfig: enable PDC interrupt controller for Qualcomm SDM845 Lina Iyer
2019-11-16 10:30 ` [PATCH v2 00/12] Support wakeup capable GPIOs Marc Zyngier
2019-11-18 23:36   ` Lina Iyer
2019-11-19  1:05 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573855915-9841-8-git-send-email-ilina@codeaurora.org \
    --to=ilina@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=evgreen@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mkshah@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.