From: Ankit Navik <ankit.p.navik@intel.com> To: intel-gfx@lists.freedesktop.org Cc: ankit.p.navik@intel.com, vipin.anand@intel.com Subject: [PATCH v6 1/3] drm/i915: Get active pending request for given context Date: Tue, 26 Nov 2019 10:21:37 +0530 [thread overview] Message-ID: <1574743899-17638-2-git-send-email-ankit.p.navik@intel.com> (raw) In-Reply-To: <1574743899-17638-1-git-send-email-ankit.p.navik@intel.com> This patch gives us the active pending request count which is yet to be submitted to the GPU. V2: * Change 64-bit to atomic for request count. (Tvrtko Ursulin) V3: * Remove mutex for request count. * Rebase. * Fixes hitting underflow for predictive request. (Tvrtko Ursulin) V4: * Rebase. V5: * Rebase. V6 * Rebase. Cc: Vipin Anand <vipin.anand@intel.com> Signed-off-by: Ankit Navik <ankit.p.navik@intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 5 +++++ drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 ++ drivers/gpu/drm/i915/gt/intel_lrc.c | 3 +++ 4 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index c94ac83..8288fb9 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -712,6 +712,7 @@ i915_gem_create_context(struct drm_i915_private *i915, unsigned int flags) } trace_i915_context_create(ctx); + atomic_set(&ctx->req_cnt, 0); return ctx; } diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h index c060bc4..3931c06 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h @@ -168,6 +168,11 @@ struct i915_gem_context { */ struct radix_tree_root handles_vma; + /** req_cnt: tracks the pending commands, based on which we decide to + * go for low/medium/high load configuration of the GPU. + */ + atomic_t req_cnt; + /** jump_whitelist: Bit array for tracking cmds during cmdparsing * Guarded by struct_mutex */ diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 7a87e82..83f4392 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -2700,6 +2700,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, if (eb.batch->private) intel_engine_pool_mark_active(eb.batch->private, eb.request); + atomic_inc(&eb.gem_context->req_cnt); + trace_i915_request_queue(eb.request, eb.batch_flags); err = eb_submit(&eb); err_request: diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 4cd0d46..511d5a1 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -1956,6 +1956,9 @@ static void execlists_dequeue(struct intel_engine_cs *engine) submit = true; last = rq; + + if (atomic_read(&rq->gem_context->req_cnt) > 0) + atomic_dec(&rq->gem_context->req_cnt); } } -- 2.7.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Ankit Navik <ankit.p.navik@intel.com> To: intel-gfx@lists.freedesktop.org Cc: ankit.p.navik@intel.com, vipin.anand@intel.com Subject: [Intel-gfx] [PATCH v6 1/3] drm/i915: Get active pending request for given context Date: Tue, 26 Nov 2019 10:21:37 +0530 [thread overview] Message-ID: <1574743899-17638-2-git-send-email-ankit.p.navik@intel.com> (raw) Message-ID: <20191126045137.CJp84NhKmENyvPQrp64j28UuDGDEVKTutvGcPdMOj6s@z> (raw) In-Reply-To: <1574743899-17638-1-git-send-email-ankit.p.navik@intel.com> This patch gives us the active pending request count which is yet to be submitted to the GPU. V2: * Change 64-bit to atomic for request count. (Tvrtko Ursulin) V3: * Remove mutex for request count. * Rebase. * Fixes hitting underflow for predictive request. (Tvrtko Ursulin) V4: * Rebase. V5: * Rebase. V6 * Rebase. Cc: Vipin Anand <vipin.anand@intel.com> Signed-off-by: Ankit Navik <ankit.p.navik@intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 5 +++++ drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 ++ drivers/gpu/drm/i915/gt/intel_lrc.c | 3 +++ 4 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index c94ac83..8288fb9 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -712,6 +712,7 @@ i915_gem_create_context(struct drm_i915_private *i915, unsigned int flags) } trace_i915_context_create(ctx); + atomic_set(&ctx->req_cnt, 0); return ctx; } diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h index c060bc4..3931c06 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h @@ -168,6 +168,11 @@ struct i915_gem_context { */ struct radix_tree_root handles_vma; + /** req_cnt: tracks the pending commands, based on which we decide to + * go for low/medium/high load configuration of the GPU. + */ + atomic_t req_cnt; + /** jump_whitelist: Bit array for tracking cmds during cmdparsing * Guarded by struct_mutex */ diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 7a87e82..83f4392 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -2700,6 +2700,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, if (eb.batch->private) intel_engine_pool_mark_active(eb.batch->private, eb.request); + atomic_inc(&eb.gem_context->req_cnt); + trace_i915_request_queue(eb.request, eb.batch_flags); err = eb_submit(&eb); err_request: diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 4cd0d46..511d5a1 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -1956,6 +1956,9 @@ static void execlists_dequeue(struct intel_engine_cs *engine) submit = true; last = rq; + + if (atomic_read(&rq->gem_context->req_cnt) > 0) + atomic_dec(&rq->gem_context->req_cnt); } } -- 2.7.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-26 4:52 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-26 4:51 [PATCH v6 0/3] Dynamic EU configuration of Slice/Sub-slice/EU Ankit Navik 2019-11-26 4:51 ` [Intel-gfx] " Ankit Navik 2019-11-26 4:51 ` Ankit Navik [this message] 2019-11-26 4:51 ` [Intel-gfx] [PATCH v6 1/3] drm/i915: Get active pending request for given context Ankit Navik 2019-11-26 10:26 ` Tvrtko Ursulin 2019-11-26 10:26 ` [Intel-gfx] " Tvrtko Ursulin 2019-11-26 4:51 ` [PATCH v6 2/3] drm/i915: set optimum eu/slice/sub-slice configuration based on load type Ankit Navik 2019-11-26 4:51 ` [Intel-gfx] " Ankit Navik 2019-11-26 10:41 ` Tvrtko Ursulin 2019-11-26 10:41 ` [Intel-gfx] " Tvrtko Ursulin 2019-11-26 4:51 ` [PATCH v6 3/3] drm/i915: Predictive governor to control slice/subslice/eu Ankit Navik 2019-11-26 4:51 ` [Intel-gfx] " Ankit Navik 2019-11-26 10:51 ` Tvrtko Ursulin 2019-11-26 10:51 ` [Intel-gfx] " Tvrtko Ursulin 2019-11-26 11:09 ` Chris Wilson 2019-11-26 11:09 ` [Intel-gfx] " Chris Wilson 2019-11-26 11:31 ` Tvrtko Ursulin 2019-11-26 11:31 ` [Intel-gfx] " Tvrtko Ursulin 2019-11-26 13:16 ` Tvrtko Ursulin 2019-11-26 13:16 ` [Intel-gfx] " Tvrtko Ursulin 2019-11-28 10:27 ` Tvrtko Ursulin 2019-11-28 10:27 ` [Intel-gfx] " Tvrtko Ursulin 2019-11-26 13:21 ` Chris Wilson 2019-11-26 13:21 ` [Intel-gfx] " Chris Wilson 2019-11-26 13:39 ` Tvrtko Ursulin 2019-11-26 13:39 ` [Intel-gfx] " Tvrtko Ursulin 2019-11-27 11:06 ` Navik, Ankit P 2019-11-27 11:06 ` [Intel-gfx] " Navik, Ankit P 2019-11-27 11:53 ` Navik, Ankit P 2019-11-27 11:53 ` [Intel-gfx] " Navik, Ankit P 2019-12-20 14:50 ` Tvrtko Ursulin 2019-11-26 5:01 ` ✗ Fi.CI.CHECKPATCH: warning for Dynamic EU configuration of Slice/Sub-slice/EU (rev4) Patchwork 2019-11-26 5:01 ` [Intel-gfx] " Patchwork 2019-11-26 5:24 ` ✓ Fi.CI.BAT: success " Patchwork 2019-11-26 5:24 ` [Intel-gfx] " Patchwork 2019-11-26 11:42 ` ✗ Fi.CI.IGT: failure " Patchwork 2019-11-26 11:42 ` [Intel-gfx] " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2019-11-26 4:08 [PATCH v6 0/3] Dynamic EU configuration of Slice/Sub-slice/EU Ankit Navik 2019-11-26 4:08 ` [PATCH v6 1/3] drm/i915: Get active pending request for given context Ankit Navik 2019-11-25 12:17 [PATCH v6 0/3] Dynamic EU configuration of Slice/Sub-slice/EU Ankit Navik 2019-11-25 12:17 ` [PATCH v6 1/3] drm/i915: Get active pending request for given context Ankit Navik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1574743899-17638-2-git-send-email-ankit.p.navik@intel.com \ --to=ankit.p.navik@intel.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=vipin.anand@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.