From: John Garry <john.garry@huawei.com> To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>, <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>, <namhyung@kernel.org>, <will@kernel.org>, <ak@linux.intel.com> Cc: <linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <suzuki.poulose@arm.com>, <james.clark@arm.com>, <zhangshaokun@hisilicon.com>, <robin.murphy@arm.com>, John Garry <john.garry@huawei.com> Subject: [PATCH RFC 0/7] perf pmu-events: Support event aliasing for system PMUs Date: Fri, 24 Jan 2020 22:34:58 +0800 [thread overview] Message-ID: <1579876505-113251-1-git-send-email-john.garry@huawei.com> (raw) Currently event aliasing for only CPU and uncore PMUs is supported. In fact, only uncore PMUs aliasing for when the uncore PMUs are fixed for a CPU is supported, which may not always be the case for certain architectures. This series adds support for PMU event aliasing for system and other uncore PMUs which are not fixed to a specific CPU. For this, we introduce support for another per-arch mapfile, which maps a particular system identifier to a set of system PMU events for that system. This is much the same as what we do for CPU event aliasing. To support this, we need to change how we match a PMU to a mapfile, whether it should use a CPU or system mapfile. For this we do the following: - For CPU PMU, we always match for the event mapfile based on the CPUID. This has not changed. - For an uncore or system PMU, we match first based on the SYSID (if set). If this fails, then we match on the CPUID. This works for x86, as x86 would not have any system mapfiles for uncore PMUs (and match on the CPUID). Initial reference support is also added for ARM SMMUv3 PMCG (Performance Monitor Event Group) PMU for HiSilicon hip08 platform with only a single event so far - see driver in drivers/perf/arm_smmuv3_pmu.c for that driver. Here is a sample output with this series: root@ubuntu:/# ./perf list [...] smmuv3_pmcg_100020/config_cache_miss/ [Kernel PMU event] smmuv3_pmcg_100020/config_struct_access/ [Kernel PMU event] smmuv3_pmcg_100020/cycles/ [Kernel PMU event] smmuv3_pmcg_100020/pcie_ats_trans_passed/ [Kernel PMU event] smmuv3_pmcg_100020/pcie_ats_trans_rq/ [Kernel PMU event] smmuv3_pmcg_100020/tlb_miss/ [Kernel PMU event] smmuv3_pmcg_100020/trans_table_walk_access/ [Kernel PMU event] smmuv3_pmcg_100020/transaction/ [Kernel PMU event] [...] smmu v3 pmcg: smmuv3_pmcg.l1_tlb [SMMUv3 PMCG l1_tlb. Unit: smmuv3_pmcg] [...] root@ubuntu:/# ./perf stat -v -e smmuv3_pmcg.l1_tlb sleep 1 Using CPUID 0x00000000480fd010 Using SYSID HIP08 -> smmuv3_pmcg_200100020/event=0x8a/ -> smmuv3_pmcg_200140020/event=0x8a/ -> smmuv3_pmcg_100020/event=0x8a/ -> smmuv3_pmcg_140020/event=0x8a/ -> smmuv3_pmcg_200148020/event=0x8a/ -> smmuv3_pmcg_148020/event=0x8a/ smmuv3_pmcg.l1_tlb: 0 1001221690 1001221690 smmuv3_pmcg.l1_tlb: 0 1001220090 1001220090 smmuv3_pmcg.l1_tlb: 101 1001219660 1001219660 smmuv3_pmcg.l1_tlb: 0 1001219010 1001219010 smmuv3_pmcg.l1_tlb: 0 1001218360 1001218360 smmuv3_pmcg.l1_tlb: 134 1001217850 1001217850 Performance counter stats for 'system wide': 235 smmuv3_pmcg.l1_tlb 1.001263128 seconds time elapsed root@ubuntu:/# Issues with this series which need to be addressed (aware to me): - It would be good to have a universal method to identify the system from sysfs. Nothing exists which I know about. There is DMI, but this is not always available (or has correct info). Maybe systems which want to support this feature will need a "soc" driver, and a /sys/devices/socX/machine file (which I used for testing this series - this driver is out of tree currently). - Maybe it is ok, but for systems which match on the system identifier, uncore PMUs should be in the system mapfile, and, as such, match on the system identifier and not CPU identifier. - We need a better way in jevents.c to give a direct mapping of PMU name aliases, i.e. for any PMU name not prefixed with "uncore_", we need to add this to table unit_to_pmu[]. Not scalable. Having said that, maybe the kernel can introduce some future PMU naming convention in future. John Garry (7): perf jevents: Add support for an extra directory level perf vendor events arm64: Relocate hip08 core events perf jevents: Add support for a system events PMU perf pmu: Rename uncore symbols to include system pmus perf pmu: Support matching by sysid perf vendor events arm64: Relocate uncore events for hip08 perf vendor events arm64: Add hip08 SMMUv3 PMCG IMP DEF events tools/perf/arch/arm64/util/arm-spe.c | 2 +- tools/perf/pmu-events/README | 47 ++++++-- .../hip08/{ => cpu}/core-imp-def.json | 0 .../hisilicon/hip08/sys/smmu-v3-pmcg.json | 9 ++ .../hip08/{ => sys}/uncore-ddrc.json | 0 .../hisilicon/hip08/{ => sys}/uncore-hha.json | 0 .../hisilicon/hip08/{ => sys}/uncore-l3c.json | 0 tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 +- .../pmu-events/arch/arm64/mapfile_sys.csv | 14 +++ tools/perf/pmu-events/jevents.c | 65 ++++++++-- tools/perf/pmu-events/pmu-events.h | 1 + tools/perf/util/evsel.h | 2 +- tools/perf/util/parse-events.c | 12 +- tools/perf/util/pmu.c | 111 +++++++++++++++--- tools/perf/util/pmu.h | 2 +- 15 files changed, 221 insertions(+), 46 deletions(-) rename tools/perf/pmu-events/arch/arm64/hisilicon/hip08/{ => cpu}/core-imp-def.json (100%) create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/sys/smmu-v3-pmcg.json rename tools/perf/pmu-events/arch/arm64/hisilicon/hip08/{ => sys}/uncore-ddrc.json (100%) rename tools/perf/pmu-events/arch/arm64/hisilicon/hip08/{ => sys}/uncore-hha.json (100%) rename tools/perf/pmu-events/arch/arm64/hisilicon/hip08/{ => sys}/uncore-l3c.json (100%) create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile_sys.csv -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com> To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>, <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>, <namhyung@kernel.org>, <will@kernel.org>, <ak@linux.intel.com> Cc: suzuki.poulose@arm.com, John Garry <john.garry@huawei.com>, linuxarm@huawei.com, linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com, james.clark@arm.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH RFC 0/7] perf pmu-events: Support event aliasing for system PMUs Date: Fri, 24 Jan 2020 22:34:58 +0800 [thread overview] Message-ID: <1579876505-113251-1-git-send-email-john.garry@huawei.com> (raw) Currently event aliasing for only CPU and uncore PMUs is supported. In fact, only uncore PMUs aliasing for when the uncore PMUs are fixed for a CPU is supported, which may not always be the case for certain architectures. This series adds support for PMU event aliasing for system and other uncore PMUs which are not fixed to a specific CPU. For this, we introduce support for another per-arch mapfile, which maps a particular system identifier to a set of system PMU events for that system. This is much the same as what we do for CPU event aliasing. To support this, we need to change how we match a PMU to a mapfile, whether it should use a CPU or system mapfile. For this we do the following: - For CPU PMU, we always match for the event mapfile based on the CPUID. This has not changed. - For an uncore or system PMU, we match first based on the SYSID (if set). If this fails, then we match on the CPUID. This works for x86, as x86 would not have any system mapfiles for uncore PMUs (and match on the CPUID). Initial reference support is also added for ARM SMMUv3 PMCG (Performance Monitor Event Group) PMU for HiSilicon hip08 platform with only a single event so far - see driver in drivers/perf/arm_smmuv3_pmu.c for that driver. Here is a sample output with this series: root@ubuntu:/# ./perf list [...] smmuv3_pmcg_100020/config_cache_miss/ [Kernel PMU event] smmuv3_pmcg_100020/config_struct_access/ [Kernel PMU event] smmuv3_pmcg_100020/cycles/ [Kernel PMU event] smmuv3_pmcg_100020/pcie_ats_trans_passed/ [Kernel PMU event] smmuv3_pmcg_100020/pcie_ats_trans_rq/ [Kernel PMU event] smmuv3_pmcg_100020/tlb_miss/ [Kernel PMU event] smmuv3_pmcg_100020/trans_table_walk_access/ [Kernel PMU event] smmuv3_pmcg_100020/transaction/ [Kernel PMU event] [...] smmu v3 pmcg: smmuv3_pmcg.l1_tlb [SMMUv3 PMCG l1_tlb. Unit: smmuv3_pmcg] [...] root@ubuntu:/# ./perf stat -v -e smmuv3_pmcg.l1_tlb sleep 1 Using CPUID 0x00000000480fd010 Using SYSID HIP08 -> smmuv3_pmcg_200100020/event=0x8a/ -> smmuv3_pmcg_200140020/event=0x8a/ -> smmuv3_pmcg_100020/event=0x8a/ -> smmuv3_pmcg_140020/event=0x8a/ -> smmuv3_pmcg_200148020/event=0x8a/ -> smmuv3_pmcg_148020/event=0x8a/ smmuv3_pmcg.l1_tlb: 0 1001221690 1001221690 smmuv3_pmcg.l1_tlb: 0 1001220090 1001220090 smmuv3_pmcg.l1_tlb: 101 1001219660 1001219660 smmuv3_pmcg.l1_tlb: 0 1001219010 1001219010 smmuv3_pmcg.l1_tlb: 0 1001218360 1001218360 smmuv3_pmcg.l1_tlb: 134 1001217850 1001217850 Performance counter stats for 'system wide': 235 smmuv3_pmcg.l1_tlb 1.001263128 seconds time elapsed root@ubuntu:/# Issues with this series which need to be addressed (aware to me): - It would be good to have a universal method to identify the system from sysfs. Nothing exists which I know about. There is DMI, but this is not always available (or has correct info). Maybe systems which want to support this feature will need a "soc" driver, and a /sys/devices/socX/machine file (which I used for testing this series - this driver is out of tree currently). - Maybe it is ok, but for systems which match on the system identifier, uncore PMUs should be in the system mapfile, and, as such, match on the system identifier and not CPU identifier. - We need a better way in jevents.c to give a direct mapping of PMU name aliases, i.e. for any PMU name not prefixed with "uncore_", we need to add this to table unit_to_pmu[]. Not scalable. Having said that, maybe the kernel can introduce some future PMU naming convention in future. John Garry (7): perf jevents: Add support for an extra directory level perf vendor events arm64: Relocate hip08 core events perf jevents: Add support for a system events PMU perf pmu: Rename uncore symbols to include system pmus perf pmu: Support matching by sysid perf vendor events arm64: Relocate uncore events for hip08 perf vendor events arm64: Add hip08 SMMUv3 PMCG IMP DEF events tools/perf/arch/arm64/util/arm-spe.c | 2 +- tools/perf/pmu-events/README | 47 ++++++-- .../hip08/{ => cpu}/core-imp-def.json | 0 .../hisilicon/hip08/sys/smmu-v3-pmcg.json | 9 ++ .../hip08/{ => sys}/uncore-ddrc.json | 0 .../hisilicon/hip08/{ => sys}/uncore-hha.json | 0 .../hisilicon/hip08/{ => sys}/uncore-l3c.json | 0 tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 +- .../pmu-events/arch/arm64/mapfile_sys.csv | 14 +++ tools/perf/pmu-events/jevents.c | 65 ++++++++-- tools/perf/pmu-events/pmu-events.h | 1 + tools/perf/util/evsel.h | 2 +- tools/perf/util/parse-events.c | 12 +- tools/perf/util/pmu.c | 111 +++++++++++++++--- tools/perf/util/pmu.h | 2 +- 15 files changed, 221 insertions(+), 46 deletions(-) rename tools/perf/pmu-events/arch/arm64/hisilicon/hip08/{ => cpu}/core-imp-def.json (100%) create mode 100644 tools/perf/pmu-events/arch/arm64/hisilicon/hip08/sys/smmu-v3-pmcg.json rename tools/perf/pmu-events/arch/arm64/hisilicon/hip08/{ => sys}/uncore-ddrc.json (100%) rename tools/perf/pmu-events/arch/arm64/hisilicon/hip08/{ => sys}/uncore-hha.json (100%) rename tools/perf/pmu-events/arch/arm64/hisilicon/hip08/{ => sys}/uncore-l3c.json (100%) create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile_sys.csv -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-01-24 14:39 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-24 14:34 John Garry [this message] 2020-01-24 14:34 ` [PATCH RFC 0/7] perf pmu-events: Support event aliasing for system PMUs John Garry 2020-01-24 14:34 ` [PATCH RFC 1/7] perf jevents: Add support for an extra directory level John Garry 2020-01-24 14:34 ` John Garry 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 15:47 ` John Garry 2020-02-10 15:47 ` John Garry 2020-01-24 14:35 ` [PATCH RFC 2/7] perf vendor events arm64: Relocate hip08 core events John Garry 2020-01-24 14:35 ` John Garry 2020-01-24 14:35 ` [PATCH RFC 3/7] perf jevents: Add support for a system events PMU John Garry 2020-01-24 14:35 ` John Garry 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 15:55 ` John Garry 2020-02-10 15:55 ` John Garry 2020-02-11 14:46 ` Jiri Olsa 2020-02-11 14:46 ` Jiri Olsa 2020-01-24 14:35 ` [PATCH RFC 4/7] perf pmu: Rename uncore symbols to include system PMUs John Garry 2020-01-24 14:35 ` John Garry 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 15:44 ` John Garry 2020-02-10 15:44 ` John Garry 2020-02-11 14:43 ` Jiri Olsa 2020-02-11 14:43 ` Jiri Olsa 2020-02-11 15:36 ` John Garry 2020-02-11 15:36 ` John Garry 2020-02-12 12:08 ` Jiri Olsa 2020-02-12 12:08 ` Jiri Olsa 2020-01-24 14:35 ` [PATCH RFC 5/7] perf pmu: Support matching by sysid John Garry 2020-01-24 14:35 ` John Garry 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 12:07 ` Jiri Olsa 2020-02-10 16:22 ` John Garry 2020-02-10 16:22 ` John Garry 2020-02-11 13:47 ` Jiri Olsa 2020-02-11 13:47 ` Jiri Olsa 2020-02-11 15:07 ` John Garry 2020-02-11 15:07 ` John Garry 2020-02-12 10:08 ` John Garry 2020-02-12 10:08 ` John Garry 2020-02-12 12:16 ` Jiri Olsa 2020-02-12 12:16 ` Jiri Olsa 2020-02-12 12:24 ` John Garry 2020-02-12 12:24 ` John Garry 2020-01-24 14:35 ` [PATCH RFC 6/7] perf vendor events arm64: Relocate uncore events for hip08 John Garry 2020-01-24 14:35 ` John Garry 2020-01-24 14:35 ` [PATCH RFC 7/7] perf vendor events arm64: Add hip08 SMMUv3 PMCG IMP DEF events John Garry 2020-01-24 14:35 ` John Garry 2020-02-11 15:24 ` [PATCH RFC 0/7] perf pmu-events: Support event aliasing for system PMUs James Clark 2020-02-11 15:24 ` James Clark 2020-02-11 15:41 ` John Garry 2020-02-11 15:41 ` John Garry 2020-02-18 12:57 ` Will Deacon 2020-02-18 12:57 ` Will Deacon 2020-02-18 13:24 ` John Garry 2020-02-18 13:24 ` John Garry 2020-02-18 13:39 ` Will Deacon 2020-02-18 13:39 ` Will Deacon 2020-02-18 16:19 ` John Garry 2020-02-18 16:19 ` John Garry 2020-02-18 17:08 ` Mark Rutland 2020-02-18 17:08 ` Mark Rutland 2020-02-18 17:58 ` John Garry 2020-02-18 17:58 ` John Garry 2020-02-18 18:13 ` Mark Rutland 2020-02-18 18:13 ` Mark Rutland 2020-02-19 1:55 ` Joakim Zhang 2020-02-19 1:55 ` Joakim Zhang 2020-02-19 8:44 ` John Garry 2020-02-19 8:44 ` John Garry 2020-02-19 12:40 ` Joakim Zhang 2020-02-19 12:40 ` Joakim Zhang 2020-02-19 14:28 ` John Garry 2020-02-19 14:28 ` John Garry 2020-02-19 8:50 ` John Garry 2020-02-19 8:50 ` John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1579876505-113251-1-git-send-email-john.garry@huawei.com \ --to=john.garry@huawei.com \ --cc=acme@kernel.org \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=james.clark@arm.com \ --cc=jolsa@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=robin.murphy@arm.com \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ --cc=zhangshaokun@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.