All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] spi: spidev_test: Remove break after exit statement
Date: Thu, 13 Feb 2020 12:16:05 +0800	[thread overview]
Message-ID: <1581567368-8055-1-git-send-email-yangtiezhu@loongson.cn> (raw)

When call print_usage() in parse_opts(), it will exit directly.
Since break is not useful after exit statement, remove it.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 tools/spi/spidev_test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/spi/spidev_test.c b/tools/spi/spidev_test.c
index 3559e76..113b1e1 100644
--- a/tools/spi/spidev_test.c
+++ b/tools/spi/spidev_test.c
@@ -283,7 +283,6 @@ static void parse_opts(int argc, char *argv[])
 			break;
 		default:
 			print_usage(argv[0]);
-			break;
 		}
 	}
 	if (mode & SPI_LOOP) {
-- 
1.8.3.1


             reply	other threads:[~2020-02-13  4:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  4:16 Tiezhu Yang [this message]
2020-02-13  4:16 ` [PATCH 2/4] spi: spidev_test: Check input_tx and input_file first after parse options Tiezhu Yang
2020-02-13  8:26   ` Geert Uytterhoeven
2020-02-13  8:26     ` Geert Uytterhoeven
2020-02-13 13:32   ` Applied "spi: spidev_test: Check input_tx and input_file first after parse options" to the spi tree Mark Brown
2020-02-13 13:32     ` Mark Brown
2020-02-13  4:16 ` [PATCH 3/4] spi: spidev_test: Use perror() only if errno is not 0 Tiezhu Yang
2020-02-13  8:27   ` Geert Uytterhoeven
2020-02-13  8:27     ` Geert Uytterhoeven
2020-02-13 13:32   ` Applied "spi: spidev_test: Use perror() only if errno is not 0" to the spi tree Mark Brown
2020-02-13 13:32     ` Mark Brown
2020-02-13  4:16 ` [PATCH 4/4] spi: spidev_test: Remove the whole "include" directory when make clean Tiezhu Yang
2020-02-13  4:16   ` Tiezhu Yang
2020-02-13 13:32   ` Applied "spi: spidev_test: Remove the whole "include" directory when make clean" to the spi tree Mark Brown
2020-02-13 13:32     ` Mark Brown
2020-02-13  8:23 ` [PATCH 1/4] spi: spidev_test: Remove break after exit statement Geert Uytterhoeven
2020-02-13  8:23   ` Geert Uytterhoeven
2020-02-13 13:32 ` Applied "spi: spidev_test: Remove break after exit statement" to the spi tree Mark Brown
2020-02-13 13:32   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1581567368-8055-1-git-send-email-yangtiezhu@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.