From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] spi: spidev_test: Check input_tx and input_file first after parse options
Date: Thu, 13 Feb 2020 12:16:06 +0800 [thread overview]
Message-ID: <1581567368-8055-2-git-send-email-yangtiezhu@loongson.cn> (raw)
In-Reply-To: <1581567368-8055-1-git-send-email-yangtiezhu@loongson.cn>
It is better to check input_tx and input_file first after parse options.
Otherwise, it will do some useless operations when both -p and --input
are selected.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
tools/spi/spidev_test.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/spi/spidev_test.c b/tools/spi/spidev_test.c
index 113b1e1..5866178 100644
--- a/tools/spi/spidev_test.c
+++ b/tools/spi/spidev_test.c
@@ -404,6 +404,9 @@ int main(int argc, char *argv[])
parse_opts(argc, argv);
+ if (input_tx && input_file)
+ pabort("only one of -p and --input may be selected");
+
fd = open(device, O_RDWR);
if (fd < 0)
pabort("can't open device");
@@ -445,9 +448,6 @@ int main(int argc, char *argv[])
printf("bits per word: %d\n", bits);
printf("max speed: %d Hz (%d KHz)\n", speed, speed/1000);
- if (input_tx && input_file)
- pabort("only one of -p and --input may be selected");
-
if (input_tx)
transfer_escaped_string(fd, input_tx);
else if (input_file)
--
1.8.3.1
next prev parent reply other threads:[~2020-02-13 4:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 4:16 [PATCH 1/4] spi: spidev_test: Remove break after exit statement Tiezhu Yang
2020-02-13 4:16 ` Tiezhu Yang [this message]
2020-02-13 8:26 ` [PATCH 2/4] spi: spidev_test: Check input_tx and input_file first after parse options Geert Uytterhoeven
2020-02-13 8:26 ` Geert Uytterhoeven
2020-02-13 13:32 ` Applied "spi: spidev_test: Check input_tx and input_file first after parse options" to the spi tree Mark Brown
2020-02-13 13:32 ` Mark Brown
2020-02-13 4:16 ` [PATCH 3/4] spi: spidev_test: Use perror() only if errno is not 0 Tiezhu Yang
2020-02-13 8:27 ` Geert Uytterhoeven
2020-02-13 8:27 ` Geert Uytterhoeven
2020-02-13 13:32 ` Applied "spi: spidev_test: Use perror() only if errno is not 0" to the spi tree Mark Brown
2020-02-13 13:32 ` Mark Brown
2020-02-13 4:16 ` [PATCH 4/4] spi: spidev_test: Remove the whole "include" directory when make clean Tiezhu Yang
2020-02-13 4:16 ` Tiezhu Yang
2020-02-13 13:32 ` Applied "spi: spidev_test: Remove the whole "include" directory when make clean" to the spi tree Mark Brown
2020-02-13 13:32 ` Mark Brown
2020-02-13 8:23 ` [PATCH 1/4] spi: spidev_test: Remove break after exit statement Geert Uytterhoeven
2020-02-13 8:23 ` Geert Uytterhoeven
2020-02-13 13:32 ` Applied "spi: spidev_test: Remove break after exit statement" to the spi tree Mark Brown
2020-02-13 13:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581567368-8055-2-git-send-email-yangtiezhu@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.