All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: dhowells@redhat.com
Subject: [PATCH] KEYS: reaching the keys quotas correctly when instanttiating
Date: Thu, 27 Feb 2020 10:25:45 +0000	[thread overview]
Message-ID: <1582799145-16073-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> (raw)

I wrote a regression test[1]to test commit a08bf91ce28ed
("KEYS: allow reaching the keys quotas exactly"), but it
failed even I used lastest kernel. It looks like the previous
patch doesn't remove "=" when we instantiate the key.

[1]http://lists.linux.it/pipermail/ltp/2020-February/015331.html

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 security/keys/key.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/keys/key.c b/security/keys/key.c
index 718bf7217420..e959b3c96b48 100644
--- a/security/keys/key.c
+++ b/security/keys/key.c
@@ -382,7 +382,7 @@ int key_payload_reserve(struct key *key, size_t datalen)
 		spin_lock(&key->user->lock);
 
 		if (delta > 0 &&
-		    (key->user->qnbytes + delta >= maxbytes ||
+		    (key->user->qnbytes + delta > maxbytes ||
 		     key->user->qnbytes + delta < key->user->qnbytes)) {
 			ret = -EDQUOT;
 		}
-- 
2.18.0

             reply	other threads:[~2020-02-27 10:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 10:25 Yang Xu [this message]
2020-02-27 16:26 ` [PATCH] KEYS: reaching the keys quotas correctly when instanttiating Jarkko Sakkinen
2020-02-28  2:32   ` [PATCH v2] KEYS: reaching the keys quotas(max_bytes) correctly Yang Xu
2020-02-28  3:30     ` Eric Biggers
2020-02-28  4:41       ` [PATCH v3] KEYS: reaching the keys quotas correctly Yang Xu
2020-03-02 12:52         ` Jarkko Sakkinen
2020-03-03  4:17         ` Eric Biggers
2020-03-03  4:33         ` Yang Xu
2020-03-03 20:18         ` Jarkko Sakkinen
2020-03-19 15:08         ` David Howells
2020-03-19 21:15         ` Jarkko Sakkinen
2020-03-19 21:30         ` David Howells
2020-03-20  1:45         ` Jarkko Sakkinen
2020-03-20  8:59         ` David Howells
2020-02-28  3:37     ` [PATCH v2] KEYS: reaching the keys quotas(max_bytes) correctly Yang Xu
2020-03-02 12:51     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1582799145-16073-1-git-send-email-xuyang2018.jy@cn.fujitsu.com \
    --to=xuyang2018.jy@cn.fujitsu.com \
    --cc=dhowells@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.