From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@sandeen.net, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org,
Allison Collins <allison.henderson@oracle.com>,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH 2/7] libxfs: complain when write IOs fail
Date: Fri, 28 Feb 2020 15:35:40 -0800 [thread overview]
Message-ID: <158293294019.1548526.987869758026597383.stgit@magnolia> (raw)
In-Reply-To: <158293292760.1548526.16432706349096704475.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Complain whenever a metadata write fails.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
libxfs/rdwr.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 92281d58..4c021316 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -1156,7 +1156,12 @@ libxfs_writebufr(xfs_buf_t *bp)
(long long)LIBXFS_BBTOOFF64(bp->b_bn),
(long long)bp->b_bn, bp, bp->b_error);
#endif
- if (!bp->b_error) {
+ if (bp->b_error) {
+ fprintf(stderr,
+ _("%s: write failed on %s bno 0x%llx/0x%x, err=%d\n"),
+ __func__, bp->b_ops->name,
+ (long long)bp->b_bn, bp->b_bcount, -bp->b_error);
+ } else {
bp->b_flags |= LIBXFS_B_UPTODATE;
bp->b_flags &= ~(LIBXFS_B_DIRTY | LIBXFS_B_EXIT |
LIBXFS_B_UNCHECKED);
next prev parent reply other threads:[~2020-02-28 23:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 23:35 [PATCH v4 0/7] xfsprogs: actually check that writes succeeded Darrick J. Wong
2020-02-28 23:35 ` [PATCH 1/7] libxfs: libxfs_buf_delwri_submit should write buffers immediately Darrick J. Wong
2020-02-28 23:35 ` Darrick J. Wong [this message]
2020-02-28 23:35 ` [PATCH 3/7] libxfs: return flush failures Darrick J. Wong
2020-02-28 23:35 ` [PATCH 4/7] libxfs: flush all dirty buffers and report errors when unmounting filesystem Darrick J. Wong
2020-02-28 23:35 ` [PATCH 5/7] mkfs: check that metadata updates have been committed Darrick J. Wong
2020-02-28 23:36 ` [PATCH 6/7] xfs_repair: " Darrick J. Wong
2020-03-05 16:48 ` Christoph Hellwig
2020-02-28 23:36 ` [PATCH 7/7] libfrog: always fsync when flushing a device Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-02-25 0:10 [PATCH v3 0/7] xfsprogs: actually check that writes succeeded Darrick J. Wong
2020-02-25 0:10 ` [PATCH 2/7] libxfs: complain when write IOs fail Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158293294019.1548526.987869758026597383.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=allison.henderson@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.