All of lore.kernel.org
 help / color / mirror / Atom feed
From: edward6@linux.ibm.com
To: ceph-devel@vger.kernel.org
Cc: Ulrich.Weigand@de.ibm.com, Tuan.Hoang1@ibm.com,
	Eduard Shishkin <edward6@linux.ibm.com>
Subject: [PATCH] ceph: fix up endian bug in managing feature bits
Date: Mon, 27 Apr 2020 23:46:26 +0200	[thread overview]
Message-ID: <1588023986-23672-1-git-send-email-edward6@linux.ibm.com> (raw)

From: Eduard Shishkin <edward6@linux.ibm.com>

In the function handle_session() variable @features always
contains little endian order of bytes. Just because the feature
bits are packed bytewise from left to right in
encode_supported_features().

However, test_bit(), called to check features availability, assumes
the host order of bytes in that variable. This leads to problems on
big endian architectures. Specifically it is impossible to mount
ceph volume on s390.

This patch adds conversion from little endian to the host order
of bytes, thus fixing the problem.

Signed-off-by: Eduard Shishkin <edward6@linux.ibm.com>
---
 fs/ceph/mds_client.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 486f91f..190598d 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -3252,7 +3252,7 @@ static void handle_session(struct ceph_mds_session *session,
 	struct ceph_mds_session_head *h;
 	u32 op;
 	u64 seq;
-	unsigned long features = 0;
+	__le64 features = 0;
 	int wake = 0;
 	bool blacklisted = false;
 
@@ -3301,7 +3301,7 @@ static void handle_session(struct ceph_mds_session *session,
 		if (session->s_state == CEPH_MDS_SESSION_RECONNECTING)
 			pr_info("mds%d reconnect success\n", session->s_mds);
 		session->s_state = CEPH_MDS_SESSION_OPEN;
-		session->s_features = features;
+		session->s_features = le64_to_cpu(features);
 		renewed_caps(mdsc, session, 0);
 		wake = 1;
 		if (mdsc->stopping)
-- 
1.8.3.1

             reply	other threads:[~2020-04-27 21:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 21:46 edward6 [this message]
2020-04-28 12:23 ` [PATCH] ceph: fix up endian bug in managing feature bits Jeff Layton
2020-04-28 12:44   ` Yan, Zheng
2020-04-29  9:46   ` Eduard Shishkin
2020-04-29 15:39     ` Jeff Layton
2020-04-29 16:08       ` Ilya Dryomov
2020-04-30 13:03         ` Jeff Layton
2020-05-04 17:48           ` Ilya Dryomov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1588023986-23672-1-git-send-email-edward6@linux.ibm.com \
    --to=edward6@linux.ibm.com \
    --cc=Tuan.Hoang1@ibm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.