All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com,
	armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	andrey.shinkevich@virtuozzo.com, den@openvz.org,
	mreitz@redhat.com, jsnow@redhat.com
Subject: [PATCH v3 04/15] block: Add chain helper functions
Date: Tue, 12 May 2020 17:53:05 +0300	[thread overview]
Message-ID: <1589295196-773454-5-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1589295196-773454-1-git-send-email-andrey.shinkevich@virtuozzo.com>

From: Max Reitz <mreitz@redhat.com>

Add some helper functions for skipping filters in a chain of block
nodes.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block.c                   | 55 +++++++++++++++++++++++++++++++++++++++++++++++
 include/block/block_int.h |  3 +++
 2 files changed, 58 insertions(+)

diff --git a/block.c b/block.c
index b2aae2e..5b4ebfe 100644
--- a/block.c
+++ b/block.c
@@ -6863,3 +6863,58 @@ BdrvChild *bdrv_primary_child(BlockDriverState *bs)
 {
     return bdrv_filtered_rw_child(bs) ?: bs->file;
 }
+
+static BlockDriverState *bdrv_skip_filters(BlockDriverState *bs,
+                                           bool stop_on_explicit_filter)
+{
+    BdrvChild *filtered;
+
+    if (!bs) {
+        return NULL;
+    }
+
+    while (!(stop_on_explicit_filter && !bs->implicit)) {
+        filtered = bdrv_filtered_rw_child(bs);
+        if (!filtered) {
+            break;
+        }
+        bs = filtered->bs;
+    }
+    /*
+     * Note that this treats nodes with bs->drv == NULL as not being
+     * R/W filters (bs->drv == NULL should be replaced by something
+     * else anyway).
+     * The advantage of this behavior is that this function will thus
+     * always return a non-NULL value (given a non-NULL @bs).
+     */
+
+    return bs;
+}
+
+/*
+ * Return the first BDS that has not been added implicitly or that
+ * does not have an RW-filtered child down the chain starting from @bs
+ * (including @bs itself).
+ */
+BlockDriverState *bdrv_skip_implicit_filters(BlockDriverState *bs)
+{
+    return bdrv_skip_filters(bs, true);
+}
+
+/*
+ * Return the first BDS that does not have an RW-filtered child down
+ * the chain starting from @bs (including @bs itself).
+ */
+BlockDriverState *bdrv_skip_rw_filters(BlockDriverState *bs)
+{
+    return bdrv_skip_filters(bs, false);
+}
+
+/*
+ * For a backing chain, return the first non-filter backing image of
+ * the first non-filter image.
+ */
+BlockDriverState *bdrv_backing_chain_next(BlockDriverState *bs)
+{
+    return bdrv_skip_rw_filters(bdrv_filtered_cow_bs(bdrv_skip_rw_filters(bs)));
+}
diff --git a/include/block/block_int.h b/include/block/block_int.h
index dca59e9..86f7666 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -1347,6 +1347,9 @@ BdrvChild *bdrv_filtered_child(BlockDriverState *bs);
 BdrvChild *bdrv_metadata_child(BlockDriverState *bs);
 BdrvChild *bdrv_storage_child(BlockDriverState *bs);
 BdrvChild *bdrv_primary_child(BlockDriverState *bs);
+BlockDriverState *bdrv_skip_implicit_filters(BlockDriverState *bs);
+BlockDriverState *bdrv_skip_rw_filters(BlockDriverState *bs);
+BlockDriverState *bdrv_backing_chain_next(BlockDriverState *bs);
 
 static inline BlockDriverState *child_bs(BdrvChild *child)
 {
-- 
1.8.3.1



  parent reply	other threads:[~2020-05-12 14:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 14:53 [PATCH v3 00/15] Apply COR-filter to the block-stream permanently Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 01/15] block: Mark commit and mirror as filter drivers Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 02/15] copy-on-read: Support compressed writes Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 03/15] block: Add child access functions Andrey Shinkevich
2020-05-12 14:53 ` Andrey Shinkevich [this message]
2020-05-12 14:53 ` [PATCH v3 05/15] block: Include filters when freezing backing chain Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 06/15] block: Use CAFs in block status functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 07/15] commit: Deal with filters when blocking intermediate nodes Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 08/15] block: Use CAFs when working with backing chains Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 09/15] block: prepare block-stream for using COR-filter Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 10/15] copy-on-read: Support change filename functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 11/15] copy-on-read: Support preadv/pwritev_part functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 12/15] copy-on-read: add filter append/drop functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 13/15] qapi: add filter-node-name to block-stream Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 14/15] iotests: prepare 245 for using filter in block-stream Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 15/15] block: apply COR-filter to block-stream jobs Andrey Shinkevich
2020-05-12 18:20 ` [PATCH v3 00/15] Apply COR-filter to the block-stream permanently no-reply
2020-05-12 18:24 ` no-reply
2020-05-12 18:27 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1589295196-773454-5-git-send-email-andrey.shinkevich@virtuozzo.com \
    --to=andrey.shinkevich@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.