All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com,
	armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	andrey.shinkevich@virtuozzo.com, den@openvz.org,
	mreitz@redhat.com, jsnow@redhat.com
Subject: [PATCH v3 06/15] block: Use CAFs in block status functions
Date: Tue, 12 May 2020 17:53:07 +0300	[thread overview]
Message-ID: <1589295196-773454-7-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1589295196-773454-1-git-send-email-andrey.shinkevich@virtuozzo.com>

From: Max Reitz <mreitz@redhat.com>

Use the child access functions in the block status inquiry functions as
appropriate.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block/io.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/block/io.c b/block/io.c
index 7d30e61..47d8096 100644
--- a/block/io.c
+++ b/block/io.c
@@ -2387,11 +2387,12 @@ static int coroutine_fn bdrv_co_block_status(BlockDriverState *bs,
     if (ret & (BDRV_BLOCK_DATA | BDRV_BLOCK_ZERO)) {
         ret |= BDRV_BLOCK_ALLOCATED;
     } else if (want_zero) {
+        BlockDriverState *cow_bs = bdrv_filtered_cow_bs(bs);
+
         if (bdrv_unallocated_blocks_are_zero(bs)) {
             ret |= BDRV_BLOCK_ZERO;
-        } else if (bs->backing) {
-            BlockDriverState *bs2 = bs->backing->bs;
-            int64_t size2 = bdrv_getlength(bs2);
+        } else if (cow_bs) {
+            int64_t size2 = bdrv_getlength(cow_bs);
 
             if (size2 >= 0 && offset >= size2) {
                 ret |= BDRV_BLOCK_ZERO;
@@ -2457,7 +2458,7 @@ static int coroutine_fn bdrv_co_block_status_above(BlockDriverState *bs,
     bool first = true;
 
     assert(bs != base);
-    for (p = bs; p != base; p = backing_bs(p)) {
+    for (p = bs; p != base; p = bdrv_filtered_bs(p)) {
         ret = bdrv_co_block_status(p, want_zero, offset, bytes, pnum, map,
                                    file);
         if (ret < 0) {
@@ -2543,7 +2544,7 @@ int bdrv_block_status_above(BlockDriverState *bs, BlockDriverState *base,
 int bdrv_block_status(BlockDriverState *bs, int64_t offset, int64_t bytes,
                       int64_t *pnum, int64_t *map, BlockDriverState **file)
 {
-    return bdrv_block_status_above(bs, backing_bs(bs),
+    return bdrv_block_status_above(bs, bdrv_filtered_bs(bs),
                                    offset, bytes, pnum, map, file);
 }
 
@@ -2553,9 +2554,9 @@ int coroutine_fn bdrv_is_allocated(BlockDriverState *bs, int64_t offset,
     int ret;
     int64_t dummy;
 
-    ret = bdrv_common_block_status_above(bs, backing_bs(bs), false, offset,
-                                         bytes, pnum ? pnum : &dummy, NULL,
-                                         NULL);
+    ret = bdrv_common_block_status_above(bs, bdrv_filtered_bs(bs), false,
+                                         offset, bytes, pnum ? pnum : &dummy,
+                                         NULL, NULL);
     if (ret < 0) {
         return ret;
     }
@@ -2618,7 +2619,7 @@ int bdrv_is_allocated_above(BlockDriverState *top,
             break;
         }
 
-        intermediate = backing_bs(intermediate);
+        intermediate = bdrv_filtered_bs(intermediate);
     }
 
     *pnum = n;
-- 
1.8.3.1



  parent reply	other threads:[~2020-05-12 15:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 14:53 [PATCH v3 00/15] Apply COR-filter to the block-stream permanently Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 01/15] block: Mark commit and mirror as filter drivers Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 02/15] copy-on-read: Support compressed writes Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 03/15] block: Add child access functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 04/15] block: Add chain helper functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 05/15] block: Include filters when freezing backing chain Andrey Shinkevich
2020-05-12 14:53 ` Andrey Shinkevich [this message]
2020-05-12 14:53 ` [PATCH v3 07/15] commit: Deal with filters when blocking intermediate nodes Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 08/15] block: Use CAFs when working with backing chains Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 09/15] block: prepare block-stream for using COR-filter Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 10/15] copy-on-read: Support change filename functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 11/15] copy-on-read: Support preadv/pwritev_part functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 12/15] copy-on-read: add filter append/drop functions Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 13/15] qapi: add filter-node-name to block-stream Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 14/15] iotests: prepare 245 for using filter in block-stream Andrey Shinkevich
2020-05-12 14:53 ` [PATCH v3 15/15] block: apply COR-filter to block-stream jobs Andrey Shinkevich
2020-05-12 18:20 ` [PATCH v3 00/15] Apply COR-filter to the block-stream permanently no-reply
2020-05-12 18:24 ` no-reply
2020-05-12 18:27 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1589295196-773454-7-git-send-email-andrey.shinkevich@virtuozzo.com \
    --to=andrey.shinkevich@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.