All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com,
	armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	andrey.shinkevich@virtuozzo.com, den@openvz.org,
	mreitz@redhat.com, jsnow@redhat.com
Subject: [PATCH v5 01/15] block: Mark commit and mirror as filter drivers
Date: Wed, 13 May 2020 12:50:42 +0300	[thread overview]
Message-ID: <1589363456-1035571-2-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1589363456-1035571-1-git-send-email-andrey.shinkevich@virtuozzo.com>

From: Max Reitz <mreitz@redhat.com>

The commit and mirror block nodes are filters, so they should be marked
as such.  (Strictly speaking, BDS.is_filter's documentation states that
a filter's child must be bs->file.  The following patch will relax this
restriction, however.)

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
---
 block/commit.c | 2 ++
 block/mirror.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/block/commit.c b/block/commit.c
index 87f6096..445a280 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -240,6 +240,8 @@ static BlockDriver bdrv_commit_top = {
     .bdrv_co_block_status       = bdrv_co_block_status_from_backing,
     .bdrv_refresh_filename      = bdrv_commit_top_refresh_filename,
     .bdrv_child_perm            = bdrv_commit_top_child_perm,
+
+    .is_filter                  = true,
 };
 
 void commit_start(const char *job_id, BlockDriverState *bs,
diff --git a/block/mirror.c b/block/mirror.c
index aca95c9..b6de24b 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1527,6 +1527,8 @@ static BlockDriver bdrv_mirror_top = {
     .bdrv_co_block_status       = bdrv_co_block_status_from_backing,
     .bdrv_refresh_filename      = bdrv_mirror_top_refresh_filename,
     .bdrv_child_perm            = bdrv_mirror_top_child_perm,
+
+    .is_filter                  = true,
 };
 
 static BlockJob *mirror_start_job(
-- 
1.8.3.1



  reply	other threads:[~2020-05-13  9:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13  9:50 [PATCH v5 00/15] Apply COR-filter to the block-stream permanently Andrey Shinkevich
2020-05-13  9:50 ` Andrey Shinkevich [this message]
2020-05-13  9:50 ` [PATCH v5 02/15] copy-on-read: Support compressed writes Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 03/15] block: Add child access functions Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 04/15] block: Add chain helper functions Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 05/15] block: Include filters when freezing backing chain Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 06/15] block: Use CAFs in block status functions Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 07/15] commit: Deal with filters when blocking intermediate nodes Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 08/15] block: Use CAFs when working with backing chains Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 09/15] block: prepare block-stream for using COR-filter Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 10/15] copy-on-read: Support change filename functions Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 11/15] copy-on-read: Support preadv/pwritev_part functions Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 12/15] copy-on-read: add filter append/drop functions Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 13/15] qapi: add filter-node-name to block-stream Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 14/15] iotests: prepare 245 for using filter in block-stream Andrey Shinkevich
2020-05-13  9:50 ` [PATCH v5 15/15] block: apply COR-filter to block-stream jobs Andrey Shinkevich
2020-06-01 13:57 ` [PATCH v5 00/15] Apply COR-filter to the block-stream permanently Andrey Shinkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1589363456-1035571-2-git-send-email-andrey.shinkevich@virtuozzo.com \
    --to=andrey.shinkevich@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.