All of lore.kernel.org
 help / color / mirror / Atom feed
From: peng.fan@nxp.com
To: shawnguo@kernel.org, s.hauer@pengutronix.de, aisheng.dong@nxp.com
Cc: kernel@pengutronix.de, festevam@gmail.com,
	linux@rempel-privat.de, leonard.crestez@nxp.com,
	daniel.baluta@nxp.com, qiangqing.zhang@nxp.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	franck.lenormand@nxp.com, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V3 1/3] firmware: imx: scu-pd: fix cm40 power domain
Date: Fri,  5 Jun 2020 09:59:30 +0800	[thread overview]
Message-ID: <1591322372-3793-2-git-send-email-peng.fan@nxp.com> (raw)
In-Reply-To: <1591322372-3793-1-git-send-email-peng.fan@nxp.com>

From: Peng Fan <peng.fan@nxp.com>

The postfix needs to be false. Alought compiler use 0 for postfix now,
and take start_from as 0, it is better we add explicit false to postfix.

Fixes: 705dcca91d0a("firmware: imx: scu-pd: add power domain for I2C and INTMUX in CM40 SS")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/firmware/imx/scu-pd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index fb5523aa16ee..d1b313fa7b96 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -167,8 +167,8 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
 	{ "dc0-pll", IMX_SC_R_DC_0_PLL_0, 2, true, 0 },
 
 	/* CM40 SS */
-	{ "cm40_i2c", IMX_SC_R_M4_0_I2C, 1, 0 },
-	{ "cm40_intmux", IMX_SC_R_M4_0_INTMUX, 1, 0 },
+	{ "cm40_i2c", IMX_SC_R_M4_0_I2C, 1, false, 0 },
+	{ "cm40_intmux", IMX_SC_R_M4_0_INTMUX, 1, false, 0 },
 };
 
 static const struct imx_sc_pd_soc imx8qxp_scu_pd = {
-- 
2.16.4


WARNING: multiple messages have this Message-ID (diff)
From: peng.fan@nxp.com
To: shawnguo@kernel.org, s.hauer@pengutronix.de, aisheng.dong@nxp.com
Cc: Peng Fan <peng.fan@nxp.com>,
	festevam@gmail.com, qiangqing.zhang@nxp.com,
	linux@rempel-privat.de, franck.lenormand@nxp.com,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
	leonard.crestez@nxp.com, daniel.baluta@nxp.com,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com
Subject: [PATCH V3 1/3] firmware: imx: scu-pd: fix cm40 power domain
Date: Fri,  5 Jun 2020 09:59:30 +0800	[thread overview]
Message-ID: <1591322372-3793-2-git-send-email-peng.fan@nxp.com> (raw)
In-Reply-To: <1591322372-3793-1-git-send-email-peng.fan@nxp.com>

From: Peng Fan <peng.fan@nxp.com>

The postfix needs to be false. Alought compiler use 0 for postfix now,
and take start_from as 0, it is better we add explicit false to postfix.

Fixes: 705dcca91d0a("firmware: imx: scu-pd: add power domain for I2C and INTMUX in CM40 SS")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/firmware/imx/scu-pd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index fb5523aa16ee..d1b313fa7b96 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -167,8 +167,8 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
 	{ "dc0-pll", IMX_SC_R_DC_0_PLL_0, 2, true, 0 },
 
 	/* CM40 SS */
-	{ "cm40_i2c", IMX_SC_R_M4_0_I2C, 1, 0 },
-	{ "cm40_intmux", IMX_SC_R_M4_0_INTMUX, 1, 0 },
+	{ "cm40_i2c", IMX_SC_R_M4_0_I2C, 1, false, 0 },
+	{ "cm40_intmux", IMX_SC_R_M4_0_INTMUX, 1, false, 0 },
 };
 
 static const struct imx_sc_pd_soc imx8qxp_scu_pd = {
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-05  2:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  1:59 [PATCH V3 0/3] firmware: imx: fix/update cm4 and add resource check peng.fan
2020-06-05  1:59 ` peng.fan
2020-06-05  1:59 ` peng.fan [this message]
2020-06-05  1:59   ` [PATCH V3 1/3] firmware: imx: scu-pd: fix cm40 power domain peng.fan
2020-06-05  1:59 ` [PATCH V3 2/3] firmware: imx: add resource management api peng.fan
2020-06-05  1:59   ` peng.fan
2020-06-05  1:59 ` [PATCH V3 3/3] firmware: imx: scu-pd: add more cm4 resources peng.fan
2020-06-05  1:59   ` peng.fan
2020-06-23  7:38 ` [PATCH V3 0/3] firmware: imx: fix/update cm4 and add resource check Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1591322372-3793-2-git-send-email-peng.fan@nxp.com \
    --to=peng.fan@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=daniel.baluta@nxp.com \
    --cc=festevam@gmail.com \
    --cc=franck.lenormand@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=qiangqing.zhang@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.