From: Mike Christie <michael.christie@oracle.com> To: bvanassche@acm.org, bstroesser@ts.fujitsu.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH 04/17] tcm loop: use target_parse_emulated_name Date: Sun, 07 Jun 2020 20:35:51 +0000 [thread overview] Message-ID: <1591562164-9766-5-git-send-email-michael.christie@oracle.com> (raw) In-Reply-To: <1591562164-9766-1-git-send-email-michael.christie@oracle.com> Use target_parse_emulated_name so the acl and SCSI names are properly formatted. Signed-off-by: Mike Christie <michael.christie@oracle.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Lee Duncan <lduncan@suse.com> --- drivers/target/loopback/tcm_loop.c | 65 ++++++-------------------------------- 1 file changed, 10 insertions(+), 55 deletions(-) diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index 74aded7..64e5f1f 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c @@ -725,7 +725,8 @@ static int tcm_loop_alloc_sess_cb(struct se_portal_group *se_tpg, static int tcm_loop_make_nexus( struct tcm_loop_tpg *tl_tpg, - const char *name) + const char *tpt_id_name, + const char *acl_name) { struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba; struct tcm_loop_nexus *tl_nexus; @@ -742,7 +743,7 @@ static int tcm_loop_make_nexus( tl_nexus->se_sess = target_setup_session(&tl_tpg->tl_se_tpg, 0, 0, TARGET_PROT_DIN_PASS | TARGET_PROT_DOUT_PASS, - name, name, tl_nexus, + tpt_id_name, acl_name, tl_nexus, tcm_loop_alloc_sess_cb); if (IS_ERR(tl_nexus->se_sess)) { ret = PTR_ERR(tl_nexus->se_sess); @@ -751,7 +752,7 @@ static int tcm_loop_make_nexus( } pr_debug("TCM_Loop_ConfigFS: Established I_T Nexus to emulated %s Initiator Port: %s\n", - tcm_loop_dump_proto_id(tl_hba), name); + tcm_loop_dump_proto_id(tl_hba), acl_name); return 0; } @@ -814,7 +815,7 @@ static ssize_t tcm_loop_tpg_nexus_store(struct config_item *item, struct tcm_loop_tpg *tl_tpg = container_of(se_tpg, struct tcm_loop_tpg, tl_se_tpg); struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba; - unsigned char i_port[TL_WWN_ADDR_LEN], *ptr, *port_ptr; + unsigned char i_port[TL_WWN_ADDR_LEN], *tpt_id_name; int ret; /* * Shutdown the active I_T nexus if 'NULL' is passed.. @@ -823,59 +824,13 @@ static ssize_t tcm_loop_tpg_nexus_store(struct config_item *item, ret = tcm_loop_drop_nexus(tl_tpg); return (!ret) ? count : ret; } - /* - * Otherwise make sure the passed virtual Initiator port WWN matches - * the fabric protocol_id set in tcm_loop_make_scsi_hba(), and call - * tcm_loop_make_nexus() - */ - if (strlen(page) >= TL_WWN_ADDR_LEN) { - pr_err("Emulated NAA Sas Address: %s, exceeds max: %d\n", - page, TL_WWN_ADDR_LEN); - return -EINVAL; - } - snprintf(&i_port[0], TL_WWN_ADDR_LEN, "%s", page); - ptr = strstr(i_port, "naa."); - if (ptr) { - if (tl_hba->tl_proto_id != SCSI_PROTOCOL_SAS) { - pr_err("Passed SAS Initiator Port %s does not match target port protoid: %s\n", - i_port, tcm_loop_dump_proto_id(tl_hba)); - return -EINVAL; - } - port_ptr = &i_port[0]; - goto check_newline; - } - ptr = strstr(i_port, "fc."); - if (ptr) { - if (tl_hba->tl_proto_id != SCSI_PROTOCOL_FCP) { - pr_err("Passed FCP Initiator Port %s does not match target port protoid: %s\n", - i_port, tcm_loop_dump_proto_id(tl_hba)); - return -EINVAL; - } - port_ptr = &i_port[3]; /* Skip over "fc." */ - goto check_newline; - } - ptr = strstr(i_port, "iqn."); - if (ptr) { - if (tl_hba->tl_proto_id != SCSI_PROTOCOL_ISCSI) { - pr_err("Passed iSCSI Initiator Port %s does not match target port protoid: %s\n", - i_port, tcm_loop_dump_proto_id(tl_hba)); - return -EINVAL; - } - port_ptr = &i_port[0]; - goto check_newline; - } - pr_err("Unable to locate prefix for emulated Initiator Port: %s\n", - i_port); - return -EINVAL; - /* - * Clear any trailing newline for the NAA WWN - */ -check_newline: - if (i_port[strlen(i_port)-1] = '\n') - i_port[strlen(i_port)-1] = '\0'; + ret = target_parse_emulated_name(tl_hba->tl_proto_id, page, i_port, + TL_WWN_ADDR_LEN, &tpt_id_name); + if (ret) + return ret; - ret = tcm_loop_make_nexus(tl_tpg, port_ptr); + ret = tcm_loop_make_nexus(tl_tpg, tpt_id_name, i_port); if (ret < 0) return ret; -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com> To: bvanassche@acm.org, bstroesser@ts.fujitsu.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH 04/17] tcm loop: use target_parse_emulated_name Date: Sun, 7 Jun 2020 15:35:51 -0500 [thread overview] Message-ID: <1591562164-9766-5-git-send-email-michael.christie@oracle.com> (raw) In-Reply-To: <1591562164-9766-1-git-send-email-michael.christie@oracle.com> Use target_parse_emulated_name so the acl and SCSI names are properly formatted. Signed-off-by: Mike Christie <michael.christie@oracle.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Lee Duncan <lduncan@suse.com> --- drivers/target/loopback/tcm_loop.c | 65 ++++++-------------------------------- 1 file changed, 10 insertions(+), 55 deletions(-) diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index 74aded7..64e5f1f 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c @@ -725,7 +725,8 @@ static int tcm_loop_alloc_sess_cb(struct se_portal_group *se_tpg, static int tcm_loop_make_nexus( struct tcm_loop_tpg *tl_tpg, - const char *name) + const char *tpt_id_name, + const char *acl_name) { struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba; struct tcm_loop_nexus *tl_nexus; @@ -742,7 +743,7 @@ static int tcm_loop_make_nexus( tl_nexus->se_sess = target_setup_session(&tl_tpg->tl_se_tpg, 0, 0, TARGET_PROT_DIN_PASS | TARGET_PROT_DOUT_PASS, - name, name, tl_nexus, + tpt_id_name, acl_name, tl_nexus, tcm_loop_alloc_sess_cb); if (IS_ERR(tl_nexus->se_sess)) { ret = PTR_ERR(tl_nexus->se_sess); @@ -751,7 +752,7 @@ static int tcm_loop_make_nexus( } pr_debug("TCM_Loop_ConfigFS: Established I_T Nexus to emulated %s Initiator Port: %s\n", - tcm_loop_dump_proto_id(tl_hba), name); + tcm_loop_dump_proto_id(tl_hba), acl_name); return 0; } @@ -814,7 +815,7 @@ static ssize_t tcm_loop_tpg_nexus_store(struct config_item *item, struct tcm_loop_tpg *tl_tpg = container_of(se_tpg, struct tcm_loop_tpg, tl_se_tpg); struct tcm_loop_hba *tl_hba = tl_tpg->tl_hba; - unsigned char i_port[TL_WWN_ADDR_LEN], *ptr, *port_ptr; + unsigned char i_port[TL_WWN_ADDR_LEN], *tpt_id_name; int ret; /* * Shutdown the active I_T nexus if 'NULL' is passed.. @@ -823,59 +824,13 @@ static ssize_t tcm_loop_tpg_nexus_store(struct config_item *item, ret = tcm_loop_drop_nexus(tl_tpg); return (!ret) ? count : ret; } - /* - * Otherwise make sure the passed virtual Initiator port WWN matches - * the fabric protocol_id set in tcm_loop_make_scsi_hba(), and call - * tcm_loop_make_nexus() - */ - if (strlen(page) >= TL_WWN_ADDR_LEN) { - pr_err("Emulated NAA Sas Address: %s, exceeds max: %d\n", - page, TL_WWN_ADDR_LEN); - return -EINVAL; - } - snprintf(&i_port[0], TL_WWN_ADDR_LEN, "%s", page); - ptr = strstr(i_port, "naa."); - if (ptr) { - if (tl_hba->tl_proto_id != SCSI_PROTOCOL_SAS) { - pr_err("Passed SAS Initiator Port %s does not match target port protoid: %s\n", - i_port, tcm_loop_dump_proto_id(tl_hba)); - return -EINVAL; - } - port_ptr = &i_port[0]; - goto check_newline; - } - ptr = strstr(i_port, "fc."); - if (ptr) { - if (tl_hba->tl_proto_id != SCSI_PROTOCOL_FCP) { - pr_err("Passed FCP Initiator Port %s does not match target port protoid: %s\n", - i_port, tcm_loop_dump_proto_id(tl_hba)); - return -EINVAL; - } - port_ptr = &i_port[3]; /* Skip over "fc." */ - goto check_newline; - } - ptr = strstr(i_port, "iqn."); - if (ptr) { - if (tl_hba->tl_proto_id != SCSI_PROTOCOL_ISCSI) { - pr_err("Passed iSCSI Initiator Port %s does not match target port protoid: %s\n", - i_port, tcm_loop_dump_proto_id(tl_hba)); - return -EINVAL; - } - port_ptr = &i_port[0]; - goto check_newline; - } - pr_err("Unable to locate prefix for emulated Initiator Port: %s\n", - i_port); - return -EINVAL; - /* - * Clear any trailing newline for the NAA WWN - */ -check_newline: - if (i_port[strlen(i_port)-1] == '\n') - i_port[strlen(i_port)-1] = '\0'; + ret = target_parse_emulated_name(tl_hba->tl_proto_id, page, i_port, + TL_WWN_ADDR_LEN, &tpt_id_name); + if (ret) + return ret; - ret = tcm_loop_make_nexus(tl_tpg, port_ptr); + ret = tcm_loop_make_nexus(tl_tpg, tpt_id_name, i_port); if (ret < 0) return ret; -- 1.8.3.1
next prev parent reply other threads:[~2020-06-07 20:35 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-07 20:35 [PATCH v6 00/17] target: add sysfs support Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-07 20:35 ` [PATCH 01/17] target: check enforce_pr_isids during registration Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-07 20:35 ` [PATCH 02/17] target: separate acl name from port ids Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-09 10:11 ` Stefan Hajnoczi 2020-06-09 10:11 ` Stefan Hajnoczi 2020-06-09 14:13 ` Himanshu Madhani 2020-06-09 14:13 ` Himanshu Madhani 2020-06-07 20:35 ` [PATCH 03/17] target: add helper to parse acl and transport name Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-07 20:35 ` Mike Christie [this message] 2020-06-07 20:35 ` [PATCH 04/17] tcm loop: use target_parse_emulated_name Mike Christie 2020-06-07 20:35 ` [PATCH 05/17] vhost scsi: " Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-09 10:21 ` Stefan Hajnoczi 2020-06-09 10:21 ` Stefan Hajnoczi 2020-06-07 20:35 ` [PATCH 06/17] xen scsiback: " Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-07 20:35 ` [PATCH 07/17] iscsi target: setup transport_id Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-07 20:35 ` [PATCH 08/17] target: use tpt_id in target_stat_iport_port_ident_show Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-07 20:35 ` [PATCH 09/17] target: drop sess_get_initiator_sid from PR code Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-07 20:35 ` [PATCH 10/17] target: drop sess_get_initiator_sid Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-07 20:35 ` [PATCH 11/17] target: add session sysfs class support Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-08 5:32 ` Greg Kroah-Hartman 2020-06-08 5:32 ` Greg Kroah-Hartman 2020-06-08 15:35 ` Mike Christie 2020-06-08 15:35 ` Mike Christie 2020-06-08 16:36 ` Greg Kroah-Hartman 2020-06-08 16:36 ` Greg Kroah-Hartman 2020-06-08 19:02 ` Mike Christie 2020-06-08 19:02 ` Mike Christie 2020-06-09 6:05 ` Greg Kroah-Hartman 2020-06-09 6:05 ` Greg Kroah-Hartman 2020-06-08 6:14 ` Hannes Reinecke 2020-06-08 6:14 ` Hannes Reinecke 2020-06-08 15:21 ` Mike Christie 2020-06-08 15:21 ` Mike Christie 2020-06-08 15:55 ` Michael Christie 2020-06-08 15:55 ` Michael Christie 2020-06-09 3:10 ` Michael Christie 2020-06-09 3:10 ` Michael Christie 2020-06-08 12:06 ` Bodo Stroesser 2020-06-08 12:06 ` Bodo Stroesser 2020-06-08 14:49 ` Mike Christie 2020-06-08 14:49 ` Mike Christie 2020-06-08 12:18 ` Greg Kroah-Hartman 2020-06-08 12:18 ` Greg Kroah-Hartman 2020-06-08 12:18 ` Greg Kroah-Hartman 2020-06-08 12:18 ` Greg Kroah-Hartman 2020-06-07 20:35 ` [PATCH 12/17] target: hook most target users into sysfs API Mike Christie 2020-06-07 20:35 ` Mike Christie 2020-06-08 6:15 ` Hannes Reinecke 2020-06-08 6:15 ` Hannes Reinecke 2020-06-08 10:20 ` kernel test robot 2020-06-08 10:20 ` kernel test robot 2020-06-08 10:20 ` kernel test robot 2020-06-07 20:36 ` [PATCH 13/17] iscsi target: replace module sids with lio's sid Mike Christie 2020-06-07 20:36 ` Mike Christie 2020-06-08 6:16 ` Hannes Reinecke 2020-06-08 6:16 ` Hannes Reinecke 2020-06-07 20:36 ` [PATCH 14/17] target: add free_session callout Mike Christie 2020-06-07 20:36 ` Mike Christie 2020-06-08 6:19 ` Hannes Reinecke 2020-06-08 6:19 ` Hannes Reinecke 2020-06-07 20:36 ` [PATCH 15/17] iscsi target: hook iscsi target into sysfs API Mike Christie 2020-06-07 20:36 ` Mike Christie 2020-06-08 6:20 ` Hannes Reinecke 2020-06-08 6:20 ` Hannes Reinecke 2020-06-07 20:36 ` [PATCH 16/17] iscsi target: export session state and alias in sysfs Mike Christie 2020-06-07 20:36 ` Mike Christie 2020-06-08 6:21 ` Hannes Reinecke 2020-06-08 6:21 ` Hannes Reinecke 2020-06-07 20:36 ` [PATCH 17/17] target: drop sess_get_index Mike Christie 2020-06-07 20:36 ` Mike Christie 2020-06-08 6:21 ` Hannes Reinecke 2020-06-08 6:21 ` Hannes Reinecke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1591562164-9766-5-git-send-email-michael.christie@oracle.com \ --to=michael.christie@oracle.com \ --cc=bstroesser@ts.fujitsu.com \ --cc=bvanassche@acm.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.