All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, lucas.demarchi@intel.com
Subject: [PATCH 2/6] drm/i915/dmc: define firmware URL locally
Date: Fri,  5 Apr 2024 22:37:39 +0300	[thread overview]
Message-ID: <15935837a0c15f861bb2a688cc53514f47153ef3.1712345787.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1712345787.git.jani.nikula@intel.com>

Avoid the dependency on intel_uc_fw.h, and allow removal of xe compat
intel_uc_fw.h. If there needs to be duplication of the URL, at least
have the duplication in a sensible way.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dmc.c             |  4 +++-
 drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h    |  1 -
 drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h | 11 -----------
 3 files changed, 3 insertions(+), 13 deletions(-)
 delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 3fa851b5c7a6..e61e9c1b8947 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -38,6 +38,8 @@
  * low-power state and comes back to normal.
  */
 
+#define INTEL_DMC_FIRMWARE_URL "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"
+
 enum intel_dmc_id {
 	DMC_FW_MAIN = 0,
 	DMC_FW_PIPEA,
@@ -953,7 +955,7 @@ static void dmc_load_work_fn(struct work_struct *work)
 			   " Disabling runtime power management.\n",
 			   dmc->fw_path);
 		drm_notice(&i915->drm, "DMC firmware homepage: %s",
-			   INTEL_UC_FIRMWARE_URL);
+			   INTEL_DMC_FIRMWARE_URL);
 	}
 
 	release_firmware(fw);
diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
index a01d1b869c2d..837e95e3604e 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
@@ -26,7 +26,6 @@
 #include "i915_utils.h"
 #include "intel_gt_types.h"
 #include "intel_step.h"
-#include "intel_uc_fw.h"
 #include "intel_uncore.h"
 #include "intel_runtime_pm.h"
 #include <linux/pm_runtime.h>
diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h
deleted file mode 100644
index 009745328992..000000000000
--- a/drivers/gpu/drm/xe/compat-i915-headers/intel_uc_fw.h
+++ /dev/null
@@ -1,11 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#ifndef _INTEL_UC_FW_H_
-#define _INTEL_UC_FW_H_
-
-#define INTEL_UC_FIRMWARE_URL "https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"
-
-#endif
-- 
2.39.2


  parent reply	other threads:[~2024-04-05 19:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 19:37 [PATCH 0/6] drm/i915 and drm/xe display integration cleanups Jani Nikula
2024-04-05 19:37 ` [PATCH 1/6] drm/i915: use IS_JASPERLAKE()/IS_ELKHARTLAKE() instead of IS_PLATFORM() Jani Nikula
2024-04-05 19:37 ` Jani Nikula [this message]
2024-04-05 20:27   ` [PATCH 2/6] drm/i915/dmc: define firmware URL locally Lucas De Marchi
2024-04-08 16:00     ` Josh Boyer
2024-04-05 19:37 ` [PATCH 3/6] drm/i915: move i915_fixed.h to display/intel_fixed.h Jani Nikula
2024-04-05 19:37 ` [PATCH 4/6] drm/xe/display: clean up a lot of cruft from compat i915_drv.h Jani Nikula
2024-04-05 19:37 ` [PATCH 5/6] drm/xe/display: remove compat i915_gem.h Jani Nikula
2024-04-05 19:37 ` [PATCH 6/6] drm/xe/display: clean up compat i915_vgpu.h Jani Nikula
2024-04-05 20:04 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915 and drm/xe display integration cleanups Patchwork
2024-04-05 20:04 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-05 20:10 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-05 20:33 ` [PATCH 0/6] " Lucas De Marchi
2024-04-08  8:07   ` Jani Nikula
2024-04-05 21:41 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-05 21:41 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-05 21:43 ` ✓ CI.KUnit: success " Patchwork
2024-04-05 21:54 ` ✓ CI.Build: " Patchwork
2024-04-05 21:57 ` ✓ CI.Hooks: " Patchwork
2024-04-05 21:58 ` ✗ CI.checksparse: warning " Patchwork
2024-04-05 22:23 ` ✓ CI.BAT: success " Patchwork
2024-04-06  2:04 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15935837a0c15f861bb2a688cc53514f47153ef3.1712345787.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.