From: Kanchan Joshi <joshi.k@samsung.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Damien.LeMoal@wdc.com, Kanchan Joshi <joshi.k@samsung.com>,
Selvakumar S <selvakuma.s1@samsung.com>,
Nitesh Shetty <nj.shetty@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>
Subject: [PATCH v2] block: fix error code for zone-append
Date: Mon, 6 Jul 2020 00:59:53 +0530 [thread overview]
Message-ID: <1593977393-21446-2-git-send-email-joshi.k@samsung.com> (raw)
In-Reply-To: <1593977393-21446-1-git-send-email-joshi.k@samsung.com>
Avoid returning success when max_append_sectors is zero. This prevents
infinite loop in bio_iov_iter_get_pages().
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
Signed-off-by: Selvakumar S <selvakuma.s1@samsung.com>
Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
Signed-off-by: Javier Gonzalez <javier.gonz@samsung.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
---
block/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bio.c b/block/bio.c
index a7366c0..0cecdbc 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1044,7 +1044,7 @@ static int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter)
size_t offset;
if (WARN_ON_ONCE(!max_append_sectors))
- return 0;
+ return -EINVAL;
/*
* Move page array up in the allocated memory for the bio vecs as far as
--
2.7.4
next prev parent reply other threads:[~2020-07-05 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200705193332epcas5p409173a9d12f203d3817305dd3250ca59@epcas5p4.samsung.com>
2020-07-05 19:29 ` [PATCH v2] Fix zone-append error code Kanchan Joshi
[not found] ` <CGME20200705193337epcas5p4b15eec1bbd6dd687f706f9b8fd93c14a@epcas5p4.samsung.com>
2020-07-05 19:29 ` Kanchan Joshi [this message]
2020-07-21 15:03 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593977393-21446-2-git-send-email-joshi.k@samsung.com \
--to=joshi.k@samsung.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=javier.gonz@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nj.shetty@samsung.com \
--cc=selvakuma.s1@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.