All of lore.kernel.org
 help / color / mirror / Atom feed
From: Souptick Joarder <jrdr.linux@gmail.com>
To: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Souptick Joarder <jrdr.linux@gmail.com>,
	John Hubbard <jhubbard@nvidia.com>,
	Paul Durrant <xadimgnik@gmail.com>
Subject: [PATCH v2 2/3] xen/privcmd: Mark pages as dirty
Date: Mon,  6 Jul 2020 23:46:11 +0530	[thread overview]
Message-ID: <1594059372-15563-3-git-send-email-jrdr.linux@gmail.com> (raw)
In-Reply-To: <1594059372-15563-1-git-send-email-jrdr.linux@gmail.com>

pages need to be marked as dirty before unpinned it in
unlock_pages() which was oversight. This is fixed now.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Suggested-by: John Hubbard <jhubbard@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Paul Durrant <xadimgnik@gmail.com>
---
 drivers/xen/privcmd.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 33677ea..f6c1543 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -612,8 +612,11 @@ static void unlock_pages(struct page *pages[], unsigned int nr_pages)
 {
 	unsigned int i;
 
-	for (i = 0; i < nr_pages; i++)
+	for (i = 0; i < nr_pages; i++) {
+		if (!PageDirty(pages[i]))
+			set_page_dirty_lock(pages[i]);
 		put_page(pages[i]);
+	}
 }
 
 static long privcmd_ioctl_dm_op(struct file *file, void __user *udata)
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Souptick Joarder <jrdr.linux@gmail.com>
To: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org,
	Paul Durrant <xadimgnik@gmail.com>,
	linux-kernel@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>,
	Souptick Joarder <jrdr.linux@gmail.com>
Subject: [PATCH v2 2/3] xen/privcmd: Mark pages as dirty
Date: Mon,  6 Jul 2020 23:46:11 +0530	[thread overview]
Message-ID: <1594059372-15563-3-git-send-email-jrdr.linux@gmail.com> (raw)
In-Reply-To: <1594059372-15563-1-git-send-email-jrdr.linux@gmail.com>

pages need to be marked as dirty before unpinned it in
unlock_pages() which was oversight. This is fixed now.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Suggested-by: John Hubbard <jhubbard@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Paul Durrant <xadimgnik@gmail.com>
---
 drivers/xen/privcmd.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 33677ea..f6c1543 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -612,8 +612,11 @@ static void unlock_pages(struct page *pages[], unsigned int nr_pages)
 {
 	unsigned int i;
 
-	for (i = 0; i < nr_pages; i++)
+	for (i = 0; i < nr_pages; i++) {
+		if (!PageDirty(pages[i]))
+			set_page_dirty_lock(pages[i]);
 		put_page(pages[i]);
+	}
 }
 
 static long privcmd_ioctl_dm_op(struct file *file, void __user *udata)
-- 
1.9.1



  parent reply	other threads:[~2020-07-06 18:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 18:16 [PATCH v2 0/3] Few bug fixes and Convert to pin_user_pages*() Souptick Joarder
2020-07-06 18:16 ` Souptick Joarder
2020-07-06 18:16 ` [PATCH v2 1/3] xen/privcmd: Corrected error handling path Souptick Joarder
2020-07-06 18:16   ` Souptick Joarder
2020-07-07  9:35   ` Jürgen Groß
2020-07-07  9:35     ` Jürgen Groß
2020-07-07 11:40     ` Souptick Joarder
2020-07-07 11:40       ` Souptick Joarder
2020-07-07 11:45       ` Jürgen Groß
2020-07-07 11:45         ` Jürgen Groß
2020-07-08  2:07         ` Souptick Joarder
2020-07-08  2:07           ` Souptick Joarder
2020-07-06 18:16 ` Souptick Joarder [this message]
2020-07-06 18:16   ` [PATCH v2 2/3] xen/privcmd: Mark pages as dirty Souptick Joarder
2020-07-07  9:38   ` Jürgen Groß
2020-07-07  9:38     ` Jürgen Groß
2020-07-07 11:30     ` Souptick Joarder
2020-07-07 11:30       ` Souptick Joarder
2020-07-07 11:43       ` Jürgen Groß
2020-07-07 11:43         ` Jürgen Groß
2020-07-07 19:30         ` John Hubbard
2020-07-07 19:30           ` John Hubbard
2020-07-08  5:40           ` Jürgen Groß
2020-07-08  5:40             ` Jürgen Groß
2020-07-06 18:16 ` [PATCH v2 3/3] xen/privcmd: Convert get_user_pages*() to pin_user_pages*() Souptick Joarder
2020-07-06 18:16   ` Souptick Joarder
2020-07-07 11:49   ` Jürgen Groß
2020-07-07 11:49     ` Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1594059372-15563-3-git-send-email-jrdr.linux@gmail.com \
    --to=jrdr.linux@gmail.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=xadimgnik@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.