All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
	qemu-devel@nongnu.org, mreitz@redhat.com,
	andrey.shinkevich@virtuozzo.com, den@openvz.org
Subject: [PATCH v11 05/11] qcow2_format.py: Dump bitmap directory information
Date: Fri, 17 Jul 2020 11:14:53 +0300	[thread overview]
Message-ID: <1594973699-781898-6-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1594973699-781898-1-git-send-email-andrey.shinkevich@virtuozzo.com>

Read and dump entries from the bitmap directory of QCOW2 image.

Header extension:
magic                     0x23852875 (Bitmaps)
...
Bitmap name               bitmap-1
bitmap_table_offset       0xf0000
bitmap_table_size         1
flags                     0x2 (['auto'])
type                      1
granularity_bits          16
name_size                 8
extra_data_size           0

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 tests/qemu-iotests/qcow2_format.py | 47 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/tests/qemu-iotests/qcow2_format.py b/tests/qemu-iotests/qcow2_format.py
index b447344..05a8aa9 100644
--- a/tests/qemu-iotests/qcow2_format.py
+++ b/tests/qemu-iotests/qcow2_format.py
@@ -134,6 +134,53 @@ class Qcow2BitmapExt(Qcow2Struct):
         tail = struct.calcsize(self.fmt) % 8
         if tail:
             fd.seek(8 - tail, 1)
+        position = fd.tell()
+        self.read_bitmap_directory(fd)
+        fd.seek(position)
+
+    def read_bitmap_directory(self, fd):
+        fd.seek(self.bitmap_directory_offset)
+        self.bitmap_directory = \
+            [Qcow2BitmapDirEntry(fd) for _ in range(self.nb_bitmaps)]
+
+    def dump(self):
+        super().dump()
+        for entry in self.bitmap_directory:
+            print()
+            entry.dump()
+
+
+class Qcow2BitmapDirEntry(Qcow2Struct):
+
+    fields = (
+        ('u64', '{:#x}', 'bitmap_table_offset'),
+        ('u32', '{}', 'bitmap_table_size'),
+        ('u32', BitmapFlags, 'flags'),
+        ('u8',  '{}', 'type'),
+        ('u8',  '{}', 'granularity_bits'),
+        ('u16', '{}', 'name_size'),
+        ('u32', '{}', 'extra_data_size')
+    )
+
+    def __init__(self, fd):
+        super().__init__(fd=fd)
+        # Seek relative to the current position in the file
+        fd.seek(self.extra_data_size, 1)
+        bitmap_name = fd.read(self.name_size)
+        self.name = bitmap_name.decode('ascii')
+        # Move position to the end of the entry in the directory
+        entry_raw_size = self.bitmap_dir_entry_raw_size()
+        padding = ((entry_raw_size + 7) & ~7) - entry_raw_size
+        fd.seek(padding, 1)
+
+    def bitmap_dir_entry_raw_size(self):
+        return struct.calcsize(self.fmt) + self.name_size + \
+            self.extra_data_size
+
+    def dump(self):
+        print(f'{"Bitmap name":<25} {self.name}')
+        super(Qcow2BitmapDirEntry, self).dump()
+
 
 QCOW2_EXT_MAGIC_BITMAPS = 0x23852875
 
-- 
1.8.3.1



  parent reply	other threads:[~2020-07-17  8:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17  8:14 [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 01/11] qcow2: Fix capitalization of header extension constant Andrey Shinkevich
2020-07-23 19:46   ` Eric Blake
2020-07-17  8:14 ` [PATCH v11 02/11] qcow2_format.py: make printable data an extension class member Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method Andrey Shinkevich
2020-07-28  9:39   ` Vladimir Sementsov-Ogievskiy
2020-07-17  8:14 ` [PATCH v11 04/11] qcow2_format.py: dump bitmap flags in human readable way Andrey Shinkevich
2020-07-17  8:14 ` Andrey Shinkevich [this message]
2020-07-17  8:14 ` [PATCH v11 06/11] qcow2_format.py: pass cluster size to substructures Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 07/11] qcow2_format.py: Dump bitmap table serialized entries Andrey Shinkevich
2020-07-28 10:02   ` Vladimir Sementsov-Ogievskiy
2020-07-17  8:14 ` [PATCH v11 08/11] qcow2.py: Introduce '-j' key to dump in JSON format Andrey Shinkevich
2020-07-28 10:07   ` Vladimir Sementsov-Ogievskiy
2020-07-17  8:14 ` [PATCH v11 09/11] qcow2_format.py: collect fields " Andrey Shinkevich
2020-07-28 11:09   ` Vladimir Sementsov-Ogievskiy
2020-07-29  5:56     ` Andrey Shinkevich
2020-08-05  7:49       ` Vladimir Sementsov-Ogievskiy
2020-07-17  8:14 ` [PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class Andrey Shinkevich
2020-07-28 11:36   ` Vladimir Sementsov-Ogievskiy
2020-07-28 13:27     ` Andrey Shinkevich
2020-07-28 14:05       ` Vladimir Sementsov-Ogievskiy
2020-07-30 14:11     ` Andrey Shinkevich
2020-07-30 14:24     ` Andrey Shinkevich
2020-07-17  8:14 ` [PATCH v11 11/11] qcow2_format.py: support dumping metadata in JSON format Andrey Shinkevich
2020-07-28 12:37   ` Vladimir Sementsov-Ogievskiy
2020-07-23 19:42 ` [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Eric Blake
2020-07-23 20:18   ` Eric Blake
2020-07-24 10:50     ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1594973699-781898-6-git-send-email-andrey.shinkevich@virtuozzo.com \
    --to=andrey.shinkevich@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.