From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-devel@nongnu.org, mreitz@redhat.com,
andrey.shinkevich@virtuozzo.com, den@openvz.org
Subject: [PATCH v11 06/11] qcow2_format.py: pass cluster size to substructures
Date: Fri, 17 Jul 2020 11:14:54 +0300 [thread overview]
Message-ID: <1594973699-781898-7-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1594973699-781898-1-git-send-email-andrey.shinkevich@virtuozzo.com>
The cluster size of an image is the QcowHeader class member and may be
obtained by dependent extension structures such as Qcow2BitmapExt for
further bitmap table details print.
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/qcow2_format.py | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/qcow2_format.py b/tests/qemu-iotests/qcow2_format.py
index 05a8aa9..ca0d350 100644
--- a/tests/qemu-iotests/qcow2_format.py
+++ b/tests/qemu-iotests/qcow2_format.py
@@ -129,19 +129,21 @@ class Qcow2BitmapExt(Qcow2Struct):
('u64', '{:#x}', 'bitmap_directory_offset')
)
- def __init__(self, fd):
+ def __init__(self, fd, cluster_size):
super().__init__(fd=fd)
tail = struct.calcsize(self.fmt) % 8
if tail:
fd.seek(8 - tail, 1)
position = fd.tell()
+ self.cluster_size = cluster_size
self.read_bitmap_directory(fd)
fd.seek(position)
def read_bitmap_directory(self, fd):
fd.seek(self.bitmap_directory_offset)
self.bitmap_directory = \
- [Qcow2BitmapDirEntry(fd) for _ in range(self.nb_bitmaps)]
+ [Qcow2BitmapDirEntry(fd, cluster_size=self.cluster_size)
+ for _ in range(self.nb_bitmaps)]
def dump(self):
super().dump()
@@ -162,8 +164,9 @@ class Qcow2BitmapDirEntry(Qcow2Struct):
('u32', '{}', 'extra_data_size')
)
- def __init__(self, fd):
+ def __init__(self, fd, cluster_size):
super().__init__(fd=fd)
+ self.cluster_size = cluster_size
# Seek relative to the current position in the file
fd.seek(self.extra_data_size, 1)
bitmap_name = fd.read(self.name_size)
@@ -203,11 +206,13 @@ class QcowHeaderExtension(Qcow2Struct):
# then padding to next multiply of 8
)
- def __init__(self, magic=None, length=None, data=None, fd=None):
+ def __init__(self, magic=None, length=None, data=None, fd=None,
+ cluster_size=None):
"""
Support both loading from fd and creation from user data.
For fd-based creation current position in a file will be used to read
the data.
+ The cluster_size value may be obtained by dependent structures.
This should be somehow refactored and functionality should be moved to
superclass (to allow creation of any qcow2 struct), but then, fields
@@ -230,7 +235,7 @@ class QcowHeaderExtension(Qcow2Struct):
assert all(v is None for v in (magic, length, data))
super().__init__(fd=fd)
if self.magic == QCOW2_EXT_MAGIC_BITMAPS:
- self.obj = Qcow2BitmapExt(fd=fd)
+ self.obj = Qcow2BitmapExt(fd=fd, cluster_size=cluster_size)
self.data = None
else:
padded = (self.length + 7) & ~7
@@ -319,7 +324,7 @@ class QcowHeader(Qcow2Struct):
end = self.cluster_size
while fd.tell() < end:
- ext = QcowHeaderExtension(fd=fd)
+ ext = QcowHeaderExtension(fd=fd, cluster_size=self.cluster_size)
if ext.magic == 0:
break
else:
--
1.8.3.1
next prev parent reply other threads:[~2020-07-17 8:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 8:14 [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 01/11] qcow2: Fix capitalization of header extension constant Andrey Shinkevich
2020-07-23 19:46 ` Eric Blake
2020-07-17 8:14 ` [PATCH v11 02/11] qcow2_format.py: make printable data an extension class member Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method Andrey Shinkevich
2020-07-28 9:39 ` Vladimir Sementsov-Ogievskiy
2020-07-17 8:14 ` [PATCH v11 04/11] qcow2_format.py: dump bitmap flags in human readable way Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 05/11] qcow2_format.py: Dump bitmap directory information Andrey Shinkevich
2020-07-17 8:14 ` Andrey Shinkevich [this message]
2020-07-17 8:14 ` [PATCH v11 07/11] qcow2_format.py: Dump bitmap table serialized entries Andrey Shinkevich
2020-07-28 10:02 ` Vladimir Sementsov-Ogievskiy
2020-07-17 8:14 ` [PATCH v11 08/11] qcow2.py: Introduce '-j' key to dump in JSON format Andrey Shinkevich
2020-07-28 10:07 ` Vladimir Sementsov-Ogievskiy
2020-07-17 8:14 ` [PATCH v11 09/11] qcow2_format.py: collect fields " Andrey Shinkevich
2020-07-28 11:09 ` Vladimir Sementsov-Ogievskiy
2020-07-29 5:56 ` Andrey Shinkevich
2020-08-05 7:49 ` Vladimir Sementsov-Ogievskiy
2020-07-17 8:14 ` [PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class Andrey Shinkevich
2020-07-28 11:36 ` Vladimir Sementsov-Ogievskiy
2020-07-28 13:27 ` Andrey Shinkevich
2020-07-28 14:05 ` Vladimir Sementsov-Ogievskiy
2020-07-30 14:11 ` Andrey Shinkevich
2020-07-30 14:24 ` Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 11/11] qcow2_format.py: support dumping metadata in JSON format Andrey Shinkevich
2020-07-28 12:37 ` Vladimir Sementsov-Ogievskiy
2020-07-23 19:42 ` [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Eric Blake
2020-07-23 20:18 ` Eric Blake
2020-07-24 10:50 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594973699-781898-7-git-send-email-andrey.shinkevich@virtuozzo.com \
--to=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.