All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: akpm@linux-foundation.org
Cc: Jason Gunthorpe <jgg@mellanox.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	peterz@infradead.org, ard.biesheuvel@linaro.org,
	linux-mm@kvack.org, linux-nvdimm@lists.01.org,
	joao.m.martins@oracle.com, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v4 05/23] resource: Report parent to walk_iomem_res_desc() callback
Date: Sun, 02 Aug 2020 22:02:51 -0700	[thread overview]
Message-ID: <159643097166.4062302.11875688887228572793.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <159643094279.4062302.17779410714418721328.stgit@dwillia2-desk3.amr.corp.intel.com>

In support of detecting whether a resource might have been been claimed,
report the parent to the walk_iomem_res_desc() callback. For example,
the ACPI HMAT parser publishes "hmem" platform devices per target range.
However, if the HMAT is disabled / missing a fallback driver can attach
devices to the raw memory ranges as a fallback if it sees unclaimed /
orphan "Soft Reserved" resources in the resource tree.

Otherwise, find_next_iomem_res() returns a resource with garbage data
from the stack allocation in __walk_iomem_res_desc() for the res->parent
field.

There are currently no users that expect ->child and ->sibling to be
valid, and the resource_lock would be needed to traverse them. Use a
compound literal to implicitly zero initialize the fields that are not
being returned in addition to setting ->parent.

Cc: Jason Gunthorpe <jgg@mellanox.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 kernel/resource.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 841737bbda9e..f1175ce93a1d 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -382,10 +382,13 @@ static int find_next_iomem_res(resource_size_t start, resource_size_t end,
 
 	if (p) {
 		/* copy data */
-		res->start = max(start, p->start);
-		res->end = min(end, p->end);
-		res->flags = p->flags;
-		res->desc = p->desc;
+		*res = (struct resource) {
+			.start = max(start, p->start),
+			.end = min(end, p->end),
+			.flags = p->flags,
+			.desc = p->desc,
+			.parent = p->parent,
+		};
 	}
 
 	read_unlock(&resource_lock);
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: akpm@linux-foundation.org
Cc: Jason Gunthorpe <jgg@mellanox.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Wei Yang <richardw.yang@linux.intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	peterz@infradead.org, vishal.l.verma@intel.com,
	ard.biesheuvel@linaro.org, vishal.l.verma@intel.com,
	linux-mm@kvack.org, linux-nvdimm@lists.01.org,
	joao.m.martins@oracle.com, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v4 05/23] resource: Report parent to walk_iomem_res_desc() callback
Date: Sun, 02 Aug 2020 22:02:51 -0700	[thread overview]
Message-ID: <159643097166.4062302.11875688887228572793.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <159643094279.4062302.17779410714418721328.stgit@dwillia2-desk3.amr.corp.intel.com>

In support of detecting whether a resource might have been been claimed,
report the parent to the walk_iomem_res_desc() callback. For example,
the ACPI HMAT parser publishes "hmem" platform devices per target range.
However, if the HMAT is disabled / missing a fallback driver can attach
devices to the raw memory ranges as a fallback if it sees unclaimed /
orphan "Soft Reserved" resources in the resource tree.

Otherwise, find_next_iomem_res() returns a resource with garbage data
from the stack allocation in __walk_iomem_res_desc() for the res->parent
field.

There are currently no users that expect ->child and ->sibling to be
valid, and the resource_lock would be needed to traverse them. Use a
compound literal to implicitly zero initialize the fields that are not
being returned in addition to setting ->parent.

Cc: Jason Gunthorpe <jgg@mellanox.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 kernel/resource.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 841737bbda9e..f1175ce93a1d 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -382,10 +382,13 @@ static int find_next_iomem_res(resource_size_t start, resource_size_t end,
 
 	if (p) {
 		/* copy data */
-		res->start = max(start, p->start);
-		res->end = min(end, p->end);
-		res->flags = p->flags;
-		res->desc = p->desc;
+		*res = (struct resource) {
+			.start = max(start, p->start),
+			.end = min(end, p->end),
+			.flags = p->flags,
+			.desc = p->desc,
+			.parent = p->parent,
+		};
 	}
 
 	read_unlock(&resource_lock);


WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: akpm@linux-foundation.org
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
	linux-acpi@vger.kernel.org, ard.biesheuvel@linaro.org,
	peterz@infradead.org, vishal.l.verma@intel.com,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-mm@kvack.org, Jason Gunthorpe <jgg@mellanox.com>,
	Wei Yang <richardw.yang@linux.intel.com>,
	joao.m.martins@oracle.com, linux-nvdimm@lists.01.org
Subject: [PATCH v4 05/23] resource: Report parent to walk_iomem_res_desc() callback
Date: Sun, 02 Aug 2020 22:02:51 -0700	[thread overview]
Message-ID: <159643097166.4062302.11875688887228572793.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <159643094279.4062302.17779410714418721328.stgit@dwillia2-desk3.amr.corp.intel.com>

In support of detecting whether a resource might have been been claimed,
report the parent to the walk_iomem_res_desc() callback. For example,
the ACPI HMAT parser publishes "hmem" platform devices per target range.
However, if the HMAT is disabled / missing a fallback driver can attach
devices to the raw memory ranges as a fallback if it sees unclaimed /
orphan "Soft Reserved" resources in the resource tree.

Otherwise, find_next_iomem_res() returns a resource with garbage data
from the stack allocation in __walk_iomem_res_desc() for the res->parent
field.

There are currently no users that expect ->child and ->sibling to be
valid, and the resource_lock would be needed to traverse them. Use a
compound literal to implicitly zero initialize the fields that are not
being returned in addition to setting ->parent.

Cc: Jason Gunthorpe <jgg@mellanox.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 kernel/resource.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 841737bbda9e..f1175ce93a1d 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -382,10 +382,13 @@ static int find_next_iomem_res(resource_size_t start, resource_size_t end,
 
 	if (p) {
 		/* copy data */
-		res->start = max(start, p->start);
-		res->end = min(end, p->end);
-		res->flags = p->flags;
-		res->desc = p->desc;
+		*res = (struct resource) {
+			.start = max(start, p->start),
+			.end = min(end, p->end),
+			.flags = p->flags,
+			.desc = p->desc,
+			.parent = p->parent,
+		};
 	}
 
 	read_unlock(&resource_lock);

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-08-03  5:19 UTC|newest]

Thread overview: 174+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03  5:02 [PATCH v4 00/23] device-dax: Support sub-dividing soft-reserved ranges Dan Williams
2020-08-03  5:02 ` Dan Williams
2020-08-03  5:02 ` Dan Williams
2020-08-03  5:02 ` [PATCH v4 01/23] x86/numa: Cleanup configuration dependent command-line options Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02 ` [PATCH v4 02/23] x86/numa: Add 'nohmat' option Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02 ` [PATCH v4 03/23] efi/fake_mem: Arrange for a resource entry per efi_fake_mem instance Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02 ` [PATCH v4 04/23] ACPI: HMAT: Refactor hmat_register_target_device to hmem_register_device Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02 ` Dan Williams [this message]
2020-08-03  5:02   ` [PATCH v4 05/23] resource: Report parent to walk_iomem_res_desc() callback Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02 ` [PATCH v4 06/23] mm/memory_hotplug: Introduce default phys_to_target_node() implementation Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:02   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 07/23] ACPI: HMAT: Attach a device for each soft-reserved range Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 08/23] device-dax: Drop the dax_region.pfn_flags attribute Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 09/23] device-dax: Move instance creation parameters to 'struct dev_dax_data' Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 10/23] device-dax: Make pgmap optional for instance creation Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 11/23] device-dax: Kill dax_kmem_res Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-21 10:06   ` David Hildenbrand
2020-08-21 10:06     ` David Hildenbrand
2020-08-21 10:06     ` David Hildenbrand
2020-09-08 15:33     ` Joao Martins
2020-09-08 15:33       ` Joao Martins
2020-09-08 15:33       ` Joao Martins
2020-09-08 18:03       ` David Hildenbrand
2020-09-08 18:03         ` David Hildenbrand
2020-09-08 18:03         ` David Hildenbrand
2020-09-23  8:04       ` David Hildenbrand
2020-09-23  8:04         ` David Hildenbrand
2020-09-23  8:04         ` David Hildenbrand
2020-09-23 21:41         ` Dan Williams
2020-09-23 21:41           ` Dan Williams
2020-09-23 21:41           ` Dan Williams
2020-09-23 21:41           ` Dan Williams
2020-09-24  7:25           ` David Hildenbrand
2020-09-24  7:25             ` David Hildenbrand
2020-09-24  7:25             ` David Hildenbrand
2020-09-24  7:25             ` David Hildenbrand
2020-09-24 13:54             ` Dan Williams
2020-09-24 13:54               ` Dan Williams
2020-09-24 13:54               ` Dan Williams
2020-09-24 13:54               ` Dan Williams
2020-09-24 18:12               ` David Hildenbrand
2020-09-24 18:12                 ` David Hildenbrand
2020-09-24 18:12                 ` David Hildenbrand
2020-09-24 18:12                 ` David Hildenbrand
2020-09-24 21:26                 ` Dan Williams
2020-09-24 21:26                   ` Dan Williams
2020-09-24 21:26                   ` Dan Williams
2020-09-24 21:26                   ` Dan Williams
2020-09-24 21:41                   ` David Hildenbrand
2020-09-24 21:41                     ` David Hildenbrand
2020-09-24 21:41                     ` David Hildenbrand
2020-09-24 21:41                     ` David Hildenbrand
2020-09-24 21:50                     ` Dan Williams
2020-09-24 21:50                       ` Dan Williams
2020-09-24 21:50                       ` Dan Williams
2020-09-24 21:50                       ` Dan Williams
2020-09-25  8:54                       ` David Hildenbrand
2020-09-25  8:54                         ` David Hildenbrand
2020-09-25  8:54                         ` David Hildenbrand
2020-09-25  8:54                         ` David Hildenbrand
2020-08-03  5:03 ` [PATCH v4 12/23] device-dax: Add an allocation interface for device-dax instances Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 13/23] device-dax: Introduce 'seed' devices Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 14/23] drivers/base: Make device_find_child_by_name() compatible with sysfs inputs Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 15/23] device-dax: Add resize support Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-21 22:56   ` Andrew Morton
2020-08-21 22:56     ` Andrew Morton
2020-08-21 22:56     ` Andrew Morton
2020-08-03  5:03 ` [PATCH v4 16/23] mm/memremap_pages: Convert to 'struct range' Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03 ` [PATCH v4 17/23] mm/memremap_pages: Support multiple ranges per invocation Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:03   ` Dan Williams
2020-08-03  5:04 ` [PATCH v4 18/23] device-dax: Add dis-contiguous resource support Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04 ` [PATCH v4 19/23] device-dax: Introduce 'mapping' devices Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04 ` [PATCH v4 20/23] device-dax: Make align a per-device property Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04 ` [PATCH v4 21/23] device-dax: Add an 'align' attribute Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04 ` [PATCH v4 22/23] dax/hmem: Introduce dax_hmem.region_idle parameter Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04 ` [PATCH v4 23/23] device-dax: Add a range mapping allocation attribute Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  5:04   ` Dan Williams
2020-08-03  7:47 ` [PATCH v4 00/23] device-dax: Support sub-dividing soft-reserved ranges David Hildenbrand
2020-08-03  7:47   ` David Hildenbrand
2020-08-03  7:47   ` David Hildenbrand
2020-08-20  1:53   ` Dan Williams
2020-08-20  1:53     ` Dan Williams
2020-08-20  1:53     ` Dan Williams
2020-08-20  1:53     ` Dan Williams
2020-08-21 10:15     ` David Hildenbrand
2020-08-21 10:15       ` David Hildenbrand
2020-08-21 10:15       ` David Hildenbrand
2020-08-21 10:15       ` David Hildenbrand
2020-08-21 18:27       ` Dan Williams
2020-08-21 18:27         ` Dan Williams
2020-08-21 18:27         ` Dan Williams
2020-08-21 18:27         ` Dan Williams
2020-08-21 18:30         ` David Hildenbrand
2020-08-21 18:30           ` David Hildenbrand
2020-08-21 18:30           ` David Hildenbrand
2020-08-21 18:30           ` David Hildenbrand
2020-08-21 21:17           ` Dan Williams
2020-08-21 21:17             ` Dan Williams
2020-08-21 21:17             ` Dan Williams
2020-08-21 21:17             ` Dan Williams
2020-08-21 21:33             ` David Hildenbrand
2020-08-21 21:33               ` David Hildenbrand
2020-08-21 21:33               ` David Hildenbrand
2020-08-21 21:33               ` David Hildenbrand
2020-08-21 21:42               ` David Hildenbrand
2020-08-21 21:42                 ` David Hildenbrand
2020-08-21 21:42                 ` David Hildenbrand
2020-08-21 21:42                 ` David Hildenbrand
2020-08-21 21:43               ` David Hildenbrand
2020-08-21 21:43                 ` David Hildenbrand
2020-08-21 21:43                 ` David Hildenbrand
2020-08-21 21:43                 ` David Hildenbrand
2020-08-21 21:46               ` David Hildenbrand
2020-08-21 21:46                 ` David Hildenbrand
2020-08-21 21:46                 ` David Hildenbrand
2020-08-21 21:46                 ` David Hildenbrand
2020-08-21 23:21     ` Andrew Morton
2020-08-21 23:21       ` Andrew Morton
2020-08-21 23:21       ` Andrew Morton
2020-08-21 23:21       ` Andrew Morton
2020-08-22  2:32       ` Leizhen (ThunderTown)
2020-08-22  2:32         ` Leizhen (ThunderTown)
2020-08-22  2:32         ` Leizhen (ThunderTown)
2020-08-22  2:32         ` Leizhen (ThunderTown)
2020-09-08 10:45       ` David Hildenbrand
2020-09-08 10:45         ` David Hildenbrand
2020-09-08 10:45         ` David Hildenbrand
2020-09-08 10:45         ` David Hildenbrand
2020-09-23  0:43         ` Dan Williams
2020-09-23  0:43           ` Dan Williams
2020-09-23  0:43           ` Dan Williams
2020-09-23  0:43           ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159643097166.4062302.11875688887228572793.stgit@dwillia2-desk3.amr.corp.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jgg@mellanox.com \
    --cc=joao.m.martins@oracle.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=peterz@infradead.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.